Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/nginx: fix NGINX pidfile handling systemd
Date: Fri, 28 May 2021 13:39:59 +0200	[thread overview]
Message-ID: <20210528113959.GB2788252@scaer> (raw)
In-Reply-To: <a6b5f2ef-b33a-e300-9e0b-478ea2296969@mind.be>

Arnout, All,

On 2021-05-27 22:49 +0200, Arnout Vandecappelle spake thusly:
> On 26/05/2021 22:48, Yann E. MORIN wrote:
> > On 2021-05-21 09:41 -0500, Matthew Weber via buildroot spake thusly:
> >> Upstream bug: (deferred fix)
> >> https://trac.nginx.org/nginx/ticket/1897?cversion=0&cnum_hist=2
> > So, basically, upstream refused to fix that bug [...]
[--SNIP--]
> > If so, maybe we could then tweak the unit to make use of it, instead of
> > the sleep workaround?
>  I think there was one useful comment on the Ubuntu bug [1]:
> >>>
> As far as I can tell, this daemonization is not needed for the systemd service
> use-case. The service should be Type=simple, and 'daemon off'. The standard file
> handles get redirected by systemd anyway, and non-stop upgrade cannot be used in
> this case either. (See:
> http://nginx.org/en/docs/faq/daemon_master_process_off.html )
> <<<
>  So I rather think we should go for that solution.

Indeed, that seems an even better solution, and probably an actual fix.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-05-28 11:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 14:41 [Buildroot] [PATCH] package/nginx: fix NGINX pidfile handling systemd Matthew Weber
2021-05-26 20:48 ` Yann E. MORIN
2021-05-27 20:49   ` Arnout Vandecappelle
2021-05-28 11:39     ` Yann E. MORIN [this message]
2021-05-28 11:51       ` Arnout Vandecappelle
2021-05-28 13:12         ` Yann E. MORIN
2021-05-28 13:24           ` Arnout Vandecappelle
2021-05-28 15:48             ` Peter Korsgaard
2021-05-28 16:10               ` Arnout Vandecappelle
2021-05-28 16:42                 ` Peter Korsgaard
2021-05-28 15:46         ` Peter Korsgaard
2021-05-28 16:05           ` Arnout Vandecappelle
2021-05-28 19:41             ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210528113959.GB2788252@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox