[Buildroot] [PATCH] quagga

[Buildroot] [PATCH] quagga

[Tim Harvey]

Greetings,

I'm pretty new to buildroot but I've found that a great number of packages
don't build (at least for my armeb platform).  I'm happy to submit patches for
those I fix, so let me know if I'm not using the correct format.

Attached is a patch for quagga that addresses the following issues:
 - bumps version to 0.99.8 
   which fixes the 'error: expected specifier-qualifier-list before '__u64' 
   build issue
 - fixes link issue of not using MALLOC_GLIBC_COMPAT
 - removes static libs from target after install

Hope this is useful,

Tim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 06-quagga.patch
Type: text/x-patch
Size: 1052 bytes
Desc: 2255237146-06-quagga.patch
Url : http://busybox.net/lists/buildroot/attachments/20070830/776bdc20/attachment.bin 

[Buildroot] [PATCH] quagga

[Bernhard Fischer]

On Thu, Aug 30, 2007 at 10:32:14PM -0700, Tim Harvey wrote:
>Greetings,
>
>I'm pretty new to buildroot but I've found that a great number of packages
>don't build (at least for my armeb platform).  I'm happy to submit patches for
>those I fix, so let me know if I'm not using the correct format.
>
>Attached is a patch for quagga that addresses the following issues:
> - bumps version to 0.99.8 
>   which fixes the 'error: expected specifier-qualifier-list before '__u64' 
>   build issue
> - fixes link issue of not using MALLOC_GLIBC_COMPAT
> - removes static libs from target after install
>
>Hope this is useful,
>
>Tim
Content-Description: 2255237146-06-quagga.patch
>--- buildroot-svn/package/quagga/quagga.mk	2007-08-30 20:38:18.000000000 -0700
>+++ buildroot-patched/package/quagga/quagga.mk	2007-08-30 22:18:40.000000000 -0700
>@@ -3,7 +3,7 @@
> # quagga suite
> #
> #############################################################
>-QUAGGA_VERSION:=0.99.7
>+QUAGGA_VERSION:=0.99.8
> QUAGGA_SOURCE:=quagga-$(QUAGGA_VERSION).tar.gz
> QUAGGA_SITE:=http://www.quagga.net/download
> QUAGGA_DIR:=$(BUILD_DIR)/quagga-$(QUAGGA_VERSION)
>@@ -138,6 +138,8 @@
> 	(cd $(QUAGGA_DIR); rm -rf config.cache; \
> 		$(TARGET_CONFIGURE_OPTS) \
> 		$(TARGET_CONFIGURE_ARGS) \
>+		ac_cv_func_malloc_0_nonnull=yes \
>+		ac_cv_func_realloc_0_nonnull=yes \

These have to depend on a uClibc setting, IIRC, and should be set to
sensible values in TARGET_CONFIGURE_ARGS for use in all packages.
> 		./configure \
> 		--target=$(GNU_TARGET_NAME) \
> 		--host=$(GNU_TARGET_NAME) \
>@@ -156,6 +158,8 @@
> 
> $(TARGET_DIR)/usr/sbin/$(QUAGGA_TARGET_BINARY): $(QUAGGA_BINARY)
> 	$(MAKE) DESTDIR=$(TARGET_DIR) -C $(QUAGGA_DIR) install
>+	rm -rf $(TARGET_DIR)/usr/lib/libzebra.a
>+	rm -rf $(TARGET_DIR)/usr/lib/libzebra.la

And I'd like this to depend on a knob that only erases static libs and
headers if an option like BR2_HAVE_STATIC_LIBS (to be introduced) is not
set.

> ifneq ($(BR2_PACKAGE_QUAGGA_HEADERS),y)
> 	rm -rf $(TARGET_DIR)/usr/include/quagga
> endif

[Buildroot] [PATCH] quagga

[Tim Harvey]

--- Bernhard Fischer <rep.dot.nop@gmail.com> wrote:

> On Thu, Aug 30, 2007 at 10:32:14PM -0700, Tim Harvey wrote:
> >Greetings,
> >
> >I'm pretty new to buildroot but I've found that a great number of packages
> >don't build (at least for my armeb platform).  I'm happy to submit patches
> for
> >those I fix, so let me know if I'm not using the correct format.
> >
> >Attached is a patch for quagga that addresses the following issues:
> > - bumps version to 0.99.8 
> >   which fixes the 'error: expected specifier-qualifier-list before '__u64' 
> >   build issue
> > - fixes link issue of not using MALLOC_GLIBC_COMPAT
> > - removes static libs from target after install
> >
> >Hope this is useful,
> >
> >Tim
> Content-Description: 2255237146-06-quagga.patch
> >--- buildroot-svn/package/quagga/quagga.mk	2007-08-30 20:38:18.000000000
> -0700
> >+++ buildroot-patched/package/quagga/quagga.mk	2007-08-30 22:18:40.000000000
> -0700
> >@@ -3,7 +3,7 @@
> > # quagga suite
> > #
> > #############################################################
> >-QUAGGA_VERSION:=0.99.7
> >+QUAGGA_VERSION:=0.99.8
> > QUAGGA_SOURCE:=quagga-$(QUAGGA_VERSION).tar.gz
> > QUAGGA_SITE:=http://www.quagga.net/download
> > QUAGGA_DIR:=$(BUILD_DIR)/quagga-$(QUAGGA_VERSION)
> >@@ -138,6 +138,8 @@
> > 	(cd $(QUAGGA_DIR); rm -rf config.cache; \
> > 		$(TARGET_CONFIGURE_OPTS) \
> > 		$(TARGET_CONFIGURE_ARGS) \
> >+		ac_cv_func_malloc_0_nonnull=yes \
> >+		ac_cv_func_realloc_0_nonnull=yes \
> 
> These have to depend on a uClibc setting, IIRC, and should be set to
> sensible values in TARGET_CONFIGURE_ARGS for use in all packages.

Agreed, however I did not see that done for other packages that do this (grep
-ri ac_cv_func_malloc_0_nonnull package/*/*.mk).  

Do you have a suggestion?  As far as I know (see busybox FAQ
http://www.busybox.net/cgi-bin/viewcvs.cgi/trunk/uClibc/docs/uclibc.org/FAQ.html?rev=11976#gnu_malloc)
 this depends on MALLOC_GLIBC_COMPAT defined in the uclibc.config file which is
defined in my setup yet the undefined rpl_malloc and rpl_realloc occu

> > 		./configure \
> > 		--target=$(GNU_TARGET_NAME) \
> > 		--host=$(GNU_TARGET_NAME) \
> >@@ -156,6 +158,8 @@
> > 
> > $(TARGET_DIR)/usr/sbin/$(QUAGGA_TARGET_BINARY): $(QUAGGA_BINARY)
> > 	$(MAKE) DESTDIR=$(TARGET_DIR) -C $(QUAGGA_DIR) install
> >+	rm -rf $(TARGET_DIR)/usr/lib/libzebra.a
> >+	rm -rf $(TARGET_DIR)/usr/lib/libzebra.la
> 
> And I'd like this to depend on a knob that only erases static libs and
> headers if an option like BR2_HAVE_STATIC_LIBS (to be introduced) is not
> set.

Agreed as well - I see a lot of packages that install static libs, headers, man
pages and info pages to the target which seems silly.  

Are you suggesting that I also supply a patch to introduce
BR2_HAVE_STATIC_LIBS?  That might be a bit much to ask someone like myself who
is very new to buildroot - I certainly wouldn't be able to implement the use of
it in all the packages.

Tim

> 
> > ifneq ($(BR2_PACKAGE_QUAGGA_HEADERS),y)
> > 	rm -rf $(TARGET_DIR)/usr/include/quagga
> > endif
>