Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Kuten <ivan.kuten@promwad.com>
To: buildroot@busybox.net
Subject: [Buildroot] PATCH: set BR2_INET_RPC dependency for nfs-utils and portmap
Date: Sun, 14 Oct 2007 15:35:37 +0300	[thread overview]
Message-ID: <47120D19.8070807@promwad.com> (raw)
In-Reply-To: <200710141130.49413.yann.morin.1998@anciens.enib.fr>

Yann E. MORIN wrote:
> On Sunday 14 October 2007 01:50:32 Ivan Kuten wrote:
>> Set BR2_INET_RPC dependency for nfs-utils and portmap:
> 
> We had the same issue in BusyBox, and solved it the other way around: have
> tools needing RPC do a 'select' on RPC, such as (this is not a patch!):
> 
> ---8<---
> Index: package/nfs-utils/Config.in
> ===================================================================
> --- package/nfs-utils/Config.in (revision 20237)
> +++ package/nfs-utils/Config.in (working copy)
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_NFS_UTILS
>  	bool "nfs-utils"
>  	default n
> +	select BR2_INET_RPC
>  	help
>  	  The NFS Linux kernel server.
>  	  Warning: We do not force largefile support on here on purpose.
> Index: package/portmap/Config.in
> ===================================================================
> --- package/portmap/Config.in   (revision 20237)
> +++ package/portmap/Config.in   (working copy)
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_PORTMAP
>  	bool "portmap"
>  	default n
> +	select BR2_INET_RPC
>  	help
>  	  The standard portmapper for RPC services.
> 
> ---8<---
> 
> This is, imho, better this way because what people really want is NFS or
> portmap, and might not know that RPC is needed to make those two available.
> 
> Having NFS and portmap visible and 'select' the needed RPC support is more
> straightforward. But again, this is my humble opinion.
> 

Hello Yann,

I completely agree with you, your approach is better.

BR,
Ivan

  reply	other threads:[~2007-10-14 12:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-13 23:50 [Buildroot] PATCH: set BR2_INET_RPC dependency for nfs-utils and portmap Ivan Kuten
2007-10-14  9:30 ` Yann E. MORIN
2007-10-14 12:35   ` Ivan Kuten [this message]
2007-10-15 21:39     ` Ulf Samuelsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47120D19.8070807@promwad.com \
    --to=ivan.kuten@promwad.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox