[Buildroot] Ignored patches - WHY?

[Buildroot] Ignored patches - WHY?

[Sushi Sensei]

I have send some patches ( 0001534, 0001533, 0001532) this week with
the Patch Tracking page, the week before I have send the same patches
without notices of this inclusion or error, some patch was send 2 or 3
week before and was ignored... There are some problem with this
patches??
-- 
------------------------------------------------------
--- Timeo Danaos et dona ferentes ---
------------------------------------------------------

[Buildroot] Ignored patches - WHY?

[Ulf Samuelsson]

>I have send some patches ( 0001534, 0001533, 0001532) this week with
> the Patch Tracking page, the week before I have send the same patches
> without notices of this inclusion or error, some patch was send 2 or 3
> week before and was ignored... There are some problem with this
> patches??



Not neccessarily, noone is "responsible" for applying patches,
so if noone's got the time or  the interest, they wont be applied.
If you happen to send then when someone is in a mood, they will  be.

Best Regards
Ulf Samuelsson

[Buildroot] Ignored patches - WHY?

[Ulf Samuelsson]

> Sushi Sensei wrote:
>> I have send some patches ( 0001534, 0001533, 0001532) this week with
>> the Patch Tracking page, the week before I have send the same patches
>> without notices of this inclusion or error, some patch was send 2 or 3
>> week before and was ignored... There are some problem with this
>> patches??
>
> The problem is that there is only 2 people who can commit (have write 
> premissions):
> Bernhard Fischer and Ulf Samuelsson.
>

No, there are several others, but I guess at present, Bernhard and I are the
most frequent submitters. I have much, much less time now than I had
during the summer.

> I asked Erik Andersen (who is maintainer of buildroot.uclibc.org)
> about buildroot svn write access but still no reply from him.
>

He is very busy, so dont expect answers soon.


> Usually if you post some patch to buildroot mailing list or to bugtracking
> - it's just ignored.
>


Best Regards
Ulf Samuelsson

[Buildroot] Ignored patches - WHY?

[Sushi Sensei]

OK, then we have 3 posibilities:

1) Wait that some of the mantainers send some patch if they are inspired
2) Send the patch and pray
3) Only pray

:-)


2007/10/18, Ulf Samuelsson <ulf@atmel.com>:
>
>
> > Sushi Sensei wrote:
> >> I have send some patches ( 0001534, 0001533, 0001532) this week with
> >> the Patch Tracking page, the week before I have send the same patches
> >> without notices of this inclusion or error, some patch was send 2 or 3
> >> week before and was ignored... There are some problem with this
> >> patches??
> >
> > The problem is that there is only 2 people who can commit (have write
> > premissions):
> > Bernhard Fischer and Ulf Samuelsson.
> >
>
> No, there are several others, but I guess at present, Bernhard and I are the
> most frequent submitters. I have much, much less time now than I had
> during the summer.
>
> > I asked Erik Andersen (who is maintainer of buildroot.uclibc.org)
> > about buildroot svn write access but still no reply from him.
> >
>
> He is very busy, so dont expect answers soon.
>
>
> > Usually if you post some patch to buildroot mailing list or to bugtracking
> > - it's just ignored.
> >
>
>
> Best Regards
> Ulf Samuelsson
>
>


-- 
------------------------------------------------------
--- Timeo Danaos et dona ferentes ---
------------------------------------------------------

[Buildroot] Ignored patches - WHY?

[Kuten Ivan]

Sushi Sensei wrote:
> I have send some patches ( 0001534, 0001533, 0001532) this week with
> the Patch Tracking page, the week before I have send the same patches
> without notices of this inclusion or error, some patch was send 2 or 3
> week before and was ignored... There are some problem with this
> patches??

The problem is that there is only 2 people who can commit (have write premissions):
Bernhard Fischer and Ulf Samuelsson.

I asked Erik Andersen (who is maintainer of buildroot.uclibc.org)
about buildroot svn write access but still no reply from him.

Usually if you post some patch to buildroot mailing list or to bugtracking
- it's just ignored.

Best regards,
Ivan
--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------

[Buildroot] Ignored patches - WHY?

[Erik Andersen]

On Thu Oct 18, 2007 at 10:47:37AM -0300, Sushi Sensei wrote:
> OK, then we have 3 posibilities:
> 
> 1) Wait that some of the mantainers send some patch if they are inspired
> 2) Send the patch and pray
> 3) Only pray

4) apply for svn commit access (then wait and pray)

Best to think of it like a casino.  You roll the dice and
take your chances, just like everyone else.  You wouldn't
expect to win every single time, would you?  ;-)

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--

[Buildroot] Ignored patches - WHY?

[Sushi Sensei]

GREAT THING!!!

Now I know in name of who pray!!! :-)

2007/10/18, Ivan Kuten <ivan.kuten@promwad.com>:
> Erik Andersen wrote:
> > On Thu Oct 18, 2007 at 10:47:37AM -0300, Sushi Sensei wrote:
> >> OK, then we have 3 posibilities:
> >>
> >> 1) Wait that some of the mantainers send some patch if they are inspired
> >> 2) Send the patch and pray
> >> 3) Only pray
> >
> > 4) apply for svn commit access (then wait and pray)
> >
> > Best to think of it like a casino.  You roll the dice and
> > take your chances, just like everyone else.  You wouldn't
> > expect to win every single time, would you?  ;-)
> >
> >  -Erik
> >
> > --
> > Erik B. Andersen             http://codepoet-consulting.com/
> > --This message was written using 73% post-consumer electrons--
> > _______________________________________________
> > buildroot mailing list
> > buildroot at uclibc.org
> > http://busybox.net/mailman/listinfo/buildroot
>
> Finally Erik gave me svn write access. Thank Erik!
> And I'm able to commit a few patches :-)
>
>
> Best regards,
> Ivan
> --------------------------------
> Embedded Linux engineer,
> Promwad Company: http://www.promwad.com/
> Homepage : http://www.ivankuten.com/
> --------------------------------
>


-- 
------------------------------------------------------
--- Timeo Danaos et dona ferentes ---
------------------------------------------------------

[Buildroot] Ignored patches - WHY?

[Ivan Kuten]

Erik Andersen wrote:
> On Thu Oct 18, 2007 at 10:47:37AM -0300, Sushi Sensei wrote:
>> OK, then we have 3 posibilities:
>>
>> 1) Wait that some of the mantainers send some patch if they are inspired
>> 2) Send the patch and pray
>> 3) Only pray
> 
> 4) apply for svn commit access (then wait and pray)
> 
> Best to think of it like a casino.  You roll the dice and
> take your chances, just like everyone else.  You wouldn't
> expect to win every single time, would you?  ;-)
> 
>  -Erik
> 
> --
> Erik B. Andersen             http://codepoet-consulting.com/
> --This message was written using 73% post-consumer electrons--
> _______________________________________________
> buildroot mailing list
> buildroot at uclibc.org
> http://busybox.net/mailman/listinfo/buildroot

Finally Erik gave me svn write access. Thank Erik!
And I'm able to commit a few patches :-)


Best regards,
Ivan
--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------

[Buildroot] Ignored patches - WHY?

[Rex Luscus]

An HTML attachment was scrubbed...
URL: http://busybox.net/lists/buildroot/attachments/20071018/df4ff934/attachment.htm 

[Buildroot] Ignored patches - WHY?

[Ivan Kuten]

Sushi Sensei wrote:
> I have send some patches ( 0001534, 0001533, 0001532) this week with
> the Patch Tracking page, the week before I have send the same patches
> without notices of this inclusion or error, some patch was send 2 or 3
> week before and was ignored... There are some problem with this
> patches??

Hi Sushi,

I'm sorry I can not apply this patch : br2-olsr.patch:

Index: package/olsr/S50olsr
===================================================================
--- package/olsr/S50olsr        (revisi?n: 20228)
+++ package/olsr/S50olsr        (copia de trabajo)
@@ -6,7 +6,7 @@
 case "$1" in
   start)
        echo "Starting OLSRd daemon: "
-       /usr/sbin/olsrd -d 0 -nofork &
+       /usr/bin/olsrd -d 0 -nofork &
        ;;
   stop)
        echo "Stopping OLSRd daemon: "

-- 

Because an daemon should reside in /usr/sbin directory ,
please check other buildroot packages such as dropbear, mdnsresponder, and so on - they are all in sbin dir.
You should change OLSR_TARGET_BINARY:=usr/bin/olsrd instead.

Please adjust and resubmit.
Thanks!

Best regards,
Ivan
--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------

[Buildroot] Ignored patches - WHY?

[Ivan Kuten]

Sushi Sensei wrote:
> I have send some patches ( 0001534, 0001533, 0001532) this week with
> the Patch Tracking page, the week before I have send the same patches
> without notices of this inclusion or error, some patch was send 2 or 3
> week before and was ignored... There are some problem with this
> patches??

Sushi, regading this lockfile-progs patch:


Index: package/lockfile-progs/lockfile-progs.mk
===================================================================
--- package/lockfile-progs/lockfile-progs.mk	(revisi?n: 20228)
+++ package/lockfile-progs/lockfile-progs.mk	(copia de trabajo)
@@ -3,11 +3,12 @@
 # lockfile-progs
 #
 #############################################################
-LOCKFILE_PROGS_VERSION=0.1.10
+LOCKFILE_PROGS_VERSION=0.1.11
 LOCKFILE_PROGS_SOURCE:=lockfile-progs_$(LOCKFILE_PROGS_VERSION).tar.gz
 LOCKFILE_PROGS_SITE:=http://ftp.debian.org/debian/pool/main/l/lockfile-progs/
 LOCKFILE_PROGS_CAT:=$(ZCAT)
-LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/lockfile-progs-$(LOCKFILE_PROGS_VERSION)
+#LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/lockfile-progs-$(LOCKFILE_PROGS_VERSION)/sid
+LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/sid
 LOCKFILE_PROGS_BINARY:=usr/bin/lockfile-create
....

What the meaning of
-LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/lockfile-progs-$(LOCKFILE_PROGS_VERSION)
+LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/sid

What does it mean "sid" ???

LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/lockfile-progs-$(LOCKFILE_PROGS_VERSION)

this line is pretty good and I do not see a reason to change it. Do you?

Best regards,
Ivan
--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------

[Buildroot] Ignored patches - WHY?

[Ivan Kuten]

Ivan Kuten wrote:
> ....
> 
> What the meaning of
> -LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/lockfile-progs-$(LOCKFILE_PROGS_VERSION)
> +LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/sid
> 
> What does it mean "sid" ???
> 
> LOCKFILE_PROGS_DIR:=$(BUILD_DIR)/lockfile-progs-$(LOCKFILE_PROGS_VERSION)
> 
> this line is pretty good and I do not see a reason to change it. Do you?
> 

Ah, ok I see that they changed a dir name inside archive.

-- 

--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------

[Buildroot] Ignored patches - WHY?

[Ivan Kuten]

Rex Luscus wrote:
> Ok. This patch only change the dir of the bin of daemon.
> 
> Can you change this or you want that I make a new patch?
> 
> 
> PD: ok, ok, my english is HORRIBLE, but I don't use this too often for write, 
> only for read :-)
> 
> 
> Ivan Kuten escribi?:
>> Sushi Sensei wrote:
>>   
>>> I have send some patches ( 0001534, 0001533, 0001532) this week with
>>> the Patch Tracking page, the week before I have send the same patches
>>> without notices of this inclusion or error, some patch was send 2 or 3
>>> week before and was ignored... There are some problem with this
>>> patches??
>>>     
>>
>> Hi Sushi,
>>
>> I'm sorry I can not apply this patch : br2-olsr.patch:
>>
>> Index: package/olsr/S50olsr
>> ===================================================================
>> --- package/olsr/S50olsr        (revisi?n: 20228)
>> +++ package/olsr/S50olsr        (copia de trabajo)
>> @@ -6,7 +6,7 @@
>>  case "$1" in
>>    start)
>>         echo "Starting OLSRd daemon: "
>> -       /usr/sbin/olsrd -d 0 -nofork &
>> +       /usr/bin/olsrd -d 0 -nofork &
>>         ;;
>>    stop)
>>         echo "Stopping OLSRd daemon: "
>>
>>   
> 

>>Because an daemon should reside in /usr/sbin directory ,
>>please check other buildroot packages such as dropbear, mdnsresponder, and so on - they are all in sbin dir.
>>You should change OLSR_TARGET_BINARY:=usr/bin/olsrd instead.

Unfortunately I could not manage to build OLSR correctly:

/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip olsrd_dot_draw.so.0.3
install -D -m 755 olsrd_dot_draw.so.0.3 /usr/lib/olsrd_dot_draw.so.0.3; /sbin/ldconfig -n /usr/lib
install: cannot create regular file `/usr/lib/olsrd_dot_draw.so.0.3': Permission denied
...
make[2]: Entering directory `/opt/buildroot/build_arm/olsrd-0.5.3/lib/dyn_gw'
/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip olsrd_dyn_gw.so.0.4
install -D -m 755 olsrd_dyn_gw.so.0.4 /usr/lib/olsrd_dyn_gw.so.0.4; /sbin/ldconfig -n /usr/lib
install: cannot create regular file `/usr/lib/olsrd_dyn_gw.so.0.4': Permission denied
make[2]: Leaving directory `/opt/buildroot/build_arm/olsrd-0.5.3/lib/dyn_gw'
...
 make[2]: Entering directory `/opt/buildroot/build_arm/olsrd-0.5.3/lib/secure'
/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip olsrd_secure.so.0.5
install -D -m 755 olsrd_secure.so.0.5 /usr/lib/olsrd_secure.so.0.5; /sbin/ldconfig -n /usr/lib
install: cannot create regular file `/usr/lib/olsrd_secure.so.0.5': Permission denied
make[2]: Leaving directory `/opt/buildroot/build_arm/olsrd-0.5.3/lib/secure'

Could you provide a patch?

BR,
Ivan
--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------

[Buildroot] Ignored patches - WHY?

[Ulf Samuelsson]

fre 2007-10-19 klockan 02:36 +0300 skrev Ivan Kuten:
> Rex Luscus wrote:
> > Ok. This patch only change the dir of the bin of daemon.
> > 
> > Can you change this or you want that I make a new patch?
> > 
> > 
> > PD: ok, ok, my english is HORRIBLE, but I don't use this too often for write, 
> > only for read :-)
> > 
> > 
> > Ivan Kuten escribi?:
> >> Sushi Sensei wrote:
> >>   
> >>> I have send some patches ( 0001534, 0001533, 0001532) this week with
> >>> the Patch Tracking page, the week before I have send the same patches
> >>> without notices of this inclusion or error, some patch was send 2 or 3
> >>> week before and was ignored... There are some problem with this
> >>> patches??
> >>>     
> >>
> >> Hi Sushi,
> >>
> >> I'm sorry I can not apply this patch : br2-olsr.patch:
> >>
> >> Index: package/olsr/S50olsr
> >> ===================================================================
> >> --- package/olsr/S50olsr        (revisi?n: 20228)
> >> +++ package/olsr/S50olsr        (copia de trabajo)
> >> @@ -6,7 +6,7 @@
> >>  case "$1" in
> >>    start)
> >>         echo "Starting OLSRd daemon: "
> >> -       /usr/sbin/olsrd -d 0 -nofork &
> >> +       /usr/bin/olsrd -d 0 -nofork &
> >>         ;;
> >>    stop)
> >>         echo "Stopping OLSRd daemon: "
> >>
> >>   
> > 
> 
> >>Because an daemon should reside in /usr/sbin directory ,
> >>please check other buildroot packages such as dropbear, mdnsresponder, and so on - they are all in sbin dir.
> >>You should change OLSR_TARGET_BINARY:=usr/bin/olsrd instead.
> 
> Unfortunately I could not manage to build OLSR correctly:
> 
> /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip olsrd_dot_draw.so.0.3
> install -D -m 755 olsrd_dot_draw.so.0.3 /usr/lib/olsrd_dot_draw.so.0.3; /sbin/ldconfig -n /usr/lib
> install: cannot create regular file `/usr/lib/olsrd_dot_draw.so.0.3': Permission denied
> ...
> make[2]: Entering directory `/opt/buildroot/build_arm/olsrd-0.5.3/lib/dyn_gw'
> /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip olsrd_dyn_gw.so.0.4
> install -D -m 755 olsrd_dyn_gw.so.0.4 /usr/lib/olsrd_dyn_gw.so.0.4; /sbin/ldconfig -n /usr/lib
> install: cannot create regular file `/usr/lib/olsrd_dyn_gw.so.0.4': Permission denied
> make[2]: Leaving directory `/opt/buildroot/build_arm/olsrd-0.5.3/lib/dyn_gw'
> ...
>  make[2]: Entering directory `/opt/buildroot/build_arm/olsrd-0.5.3/lib/secure'
> /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip olsrd_secure.so.0.5
> install -D -m 755 olsrd_secure.so.0.5 /usr/lib/olsrd_secure.so.0.5; /sbin/ldconfig -n /usr/lib
> install: cannot create regular file `/usr/lib/olsrd_secure.so.0.5': Permission denied
> make[2]: Leaving directory `/opt/buildroot/build_arm/olsrd-0.5.3/lib/secure'
> 
> Could you provide a patch?
> 

OLSR will do an install in $(DESTDIR)/usr/lib
You need to add DESTDIR=$(STAGING_DIR) to the make.

I.E:

$(OLSR_DIR)/$(OLSR_BINARY): $(OLSR_DIR)/.unpacked
	$(MAKE) $(TARGET_CONFIGURE_OPTS) DESTDIR=$(STAGING_DIR) -C$(OLSR_DIR)
olsrd $(OLSR_PLUGINS)



-- 
Best Regards,
Ulf Samuelsson