From: Will Wagner <will_wagner@carallon.com>
To: buildroot@busybox.net
Subject: [Buildroot] alsa lib problem
Date: Tue, 27 Jan 2009 12:47:31 +0000 [thread overview]
Message-ID: <497F0263.80302@carallon.com> (raw)
In-Reply-To: <20090127134408.2c74b516@hcegtvedt>
Hans-Christian Egtvedt wrote:
> On Tue, 27 Jan 2009 12:32:28 +0000
> Will Wagner <will_wagner@carallon.com> wrote:
>
>> Peter Korsgaard wrote:
>>> We unconditinally add the largefile stuff to TARGET_CFLAGS, which
>>> apparently isn't a good idea for alsa.
>>>
>>> If the kernel interface is always with an 32bit offset, then
>>> asound.h should probably be changed to use a 32bit data type
>>> instead. Could you try changing it to an unsigned int and recompile?
>> Yes is I change the asound.h header it does work.
>>
>> What is the best way to proceed from here? Just patch alsa?
>>
>
> Make a patch for alsa, and send it upstream to the alsa maintainers.
> They need to fix broken code like this anyway.
Happy to prepare a patch for upstream. However can someone explain to me what is broken in
alsa? Looking at the code the declaration of the struct is identical in the kernel code
and the copy of the header in alsa. How is it that the size of off_t is different?
Thanks,
Will.
>
> <snipp>
>
--
------------------------------------------------------------------------
Will Wagner will_wagner at carallon.com
Development Manager Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------
next prev parent reply other threads:[~2009-01-27 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 19:12 [Buildroot] alsa lib problem Will Wagner
2009-01-27 5:49 ` Peter Korsgaard
2009-01-27 12:32 ` Will Wagner
2009-01-27 12:44 ` Hans-Christian Egtvedt
2009-01-27 12:47 ` Will Wagner [this message]
2009-01-27 12:56 ` Peter Korsgaard
2009-01-27 12:45 ` Peter Korsgaard
2009-01-28 15:34 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497F0263.80302@carallon.com \
--to=will_wagner@carallon.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox