From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] alsa lib problem
Date: Tue, 27 Jan 2009 13:56:16 +0100 [thread overview]
Message-ID: <87mydc29hr.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <497F0263.80302@carallon.com> (Will Wagner's message of "Tue\, 27 Jan 2009 12\:47\:31 +0000")
>>>>> "Will" == Will Wagner <will_wagner@carallon.com> writes:
>> Make a patch for alsa, and send it upstream to the alsa maintainers.
>> They need to fix broken code like this anyway.
Will> Happy to prepare a patch for upstream. However can someone explain to
Will> me what is broken in alsa? Looking at the code the declaration of the
Will> struct is identical in the kernel code and the copy of the header in
Will> alsa. How is it that the size of off_t is different?
Without largefile enabled off_t is a 32bit type (on 32bit archs), but
with largefile enabled it's a 64bit type. The kernel only accepts a
32bit type, so things break.
Looking closer at it, off_t in the kernel is a typedef of
__kernel_off_t, which seems to be a long on all archs.
In other words, the fix seems to be a simple s/off_t/long/
You are welcome to CC me on the mail to the alsa list.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-01-27 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 19:12 [Buildroot] alsa lib problem Will Wagner
2009-01-27 5:49 ` Peter Korsgaard
2009-01-27 12:32 ` Will Wagner
2009-01-27 12:44 ` Hans-Christian Egtvedt
2009-01-27 12:47 ` Will Wagner
2009-01-27 12:56 ` Peter Korsgaard [this message]
2009-01-27 12:45 ` Peter Korsgaard
2009-01-28 15:34 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mydc29hr.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox