[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[jacmet at uclibc.org]

Author: jacmet
Date: 2009-03-05 14:17:55 +0000 (Thu, 05 Mar 2009)
New Revision: 25547

Log:
package: convert some Config.in selects to depends

Patch by Olaf Rempel <razzor@kopf-tisch.de>.

quick grep showed theses invalid selects of toolchain options.

Modified:
   trunk/buildroot/package/fuse/Config.in
   trunk/buildroot/package/lzma/Config.in
   trunk/buildroot/package/netkitbase/Config.in
   trunk/buildroot/package/qtopia4/Config.in


Changeset:
Modified: trunk/buildroot/package/fuse/Config.in
===================================================================
--- trunk/buildroot/package/fuse/Config.in	2009-03-05 13:48:29 UTC (rev 25546)
+++ trunk/buildroot/package/fuse/Config.in	2009-03-05 14:17:55 UTC (rev 25547)
@@ -1,7 +1,10 @@
 config BR2_PACKAGE_LIBFUSE
 	bool "libfuse"
-	select BR2_LARGEFILE
+	depends on BR2_LARGEFILE
 	help
 	  FUSE (Filesystem in UserSpacE)
 
 	  http://fuse.sourceforge.net/
+
+comment "libfuse requires a toolchain with LARGEFILE support"
+        depends on !BR2_LARGEFILE

Modified: trunk/buildroot/package/lzma/Config.in
===================================================================
--- trunk/buildroot/package/lzma/Config.in	2009-03-05 13:48:29 UTC (rev 25546)
+++ trunk/buildroot/package/lzma/Config.in	2009-03-05 14:17:55 UTC (rev 25547)
@@ -1,11 +1,14 @@
 config BR2_PACKAGE_LZMA_TARGET
 	bool "Install lzma for the target system"
-	select BR2_GCC_CROSS_CXX
+	depends on BR2_GCC_CROSS_CXX
 	help
 	  lzma utils on the target
 
 	  http://tukaani.org/lzma/
 
+comment "lzma requires a toolchain with C++ support"
+        depends on !BR2_GCC_CROSS_CXX
+
 config BR2_PACKAGE_LZMA_TARGET_HEADERS
 	bool "lzma headers in target"
 	depends on BR2_PACKAGE_LZMA_TARGET

Modified: trunk/buildroot/package/netkitbase/Config.in
===================================================================
--- trunk/buildroot/package/netkitbase/Config.in	2009-03-05 13:48:29 UTC (rev 25546)
+++ trunk/buildroot/package/netkitbase/Config.in	2009-03-05 14:17:55 UTC (rev 25547)
@@ -1,7 +1,10 @@
 config BR2_PACKAGE_NETKITBASE
 	bool "netkitbase"
-	select BR2_INET_RPC
+	depends on BR2_INET_RPC
 	help
 	  Old-style inetd.
 
 	  ftp://ftp.uk.linux.org/pub/linux/Networking/netkit/
+
+comment "netkitbase requires a toolchain with RPC support"
+        depends on !BR2_INET_RPC

Modified: trunk/buildroot/package/qtopia4/Config.in
===================================================================
--- trunk/buildroot/package/qtopia4/Config.in	2009-03-05 13:48:29 UTC (rev 25546)
+++ trunk/buildroot/package/qtopia4/Config.in	2009-03-05 14:17:55 UTC (rev 25547)
@@ -1,14 +1,14 @@
 config BR2_PACKAGE_QTOPIA4
 	bool "qtopia4"
 	depends on BR2_INSTALL_LIBSTDCPP
-	select BR2_PTHREADS_NATIVE
+	depends on BR2_PTHREADS_NATIVE
 	help
 	  Qtopia core 4.
 
 	  http://www.trolltech.com/
 
-comment "qtopia4 requires a toolchain with C++ support enabled"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "qtopia4 requires a toolchain with C++ and NPTL support enabled"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PTHREADS_NATIVE
 
 if BR2_PACKAGE_QTOPIA4
 

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Hans-Christian Egtvedt]

jacmet at uclibc.org wrote:

<snipp>

> -comment "qtopia4 requires a toolchain with C++ support enabled"
> -	depends on !BR2_INSTALL_LIBSTDCPP
> +comment "qtopia4 requires a toolchain with C++ and NPTL support enabled"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PTHREADS_NATIVE
>  

No, it does not require NPTL. Qtopia builds fine on AVR32 which does not 
support NPTL. I think you might run into problems with webkit, so 
enabling webkit might depend on BR2_PTHREADS_NATIVE.

<snipp>

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Peter Korsgaard]

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

 Hans-Christian> jacmet at uclibc.org wrote:
 Hans-Christian> <snipp>

 >> -comment "qtopia4 requires a toolchain with C++ support enabled"
 >> -	depends on !BR2_INSTALL_LIBSTDCPP
 >> +comment "qtopia4 requires a toolchain with C++ and NPTL support enabled"
 >> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PTHREADS_NATIVE
 >> 

 Hans-Christian> No, it does not require NPTL. Qtopia builds fine on
 Hans-Christian> AVR32 which does not support NPTL. I think you might
 Hans-Christian> run into problems with webkit, so enabling webkit
 Hans-Christian> might depend on BR2_PTHREADS_NATIVE.

So how did that work with the select BR2_PTHREADS_NATIVE?

-- 
Bye, Peter Korsgaard

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Hans-Christian Egtvedt]

Peter Korsgaard wrote:
>>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:
> 
>  Hans-Christian> jacmet at uclibc.org wrote:
>  Hans-Christian> <snipp>
> 
>  >> -comment "qtopia4 requires a toolchain with C++ support enabled"
>  >> -	depends on !BR2_INSTALL_LIBSTDCPP
>  >> +comment "qtopia4 requires a toolchain with C++ and NPTL support enabled"
>  >> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PTHREADS_NATIVE
>  >> 
> 
>  Hans-Christian> No, it does not require NPTL. Qtopia builds fine on
>  Hans-Christian> AVR32 which does not support NPTL. I think you might
>  Hans-Christian> run into problems with webkit, so enabling webkit
>  Hans-Christian> might depend on BR2_PTHREADS_NATIVE.
> 
> So how did that work with the select BR2_PTHREADS_NATIVE?
> 

Probably because I did not compile qtopia4 from mainstream trunk after 
that select was introduced.

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Peter Korsgaard]

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

 >> So how did that work with the select BR2_PTHREADS_NATIVE?
 >> 

 Hans-Christian> Probably because I did not compile qtopia4 from
 Hans-Christian> mainstream trunk after that select was introduced.

Really?

Author: aldot <aldot@69ca8d6d-28ef-0310-b511-8ec308f3f277>
Date:   Wed Dec 13 19:59:07 2006 +0000

    - Thomas Lundquist added qtopia4 support. Untested.

    git-svn-id: svn+ssh://uclibc.org/svn/trunk/buildroot at 16904

+config BR2_PACKAGE_QTOPIA4
+       bool "qtopia4"
+       default n
+       select BR2_INSTALL_LIBSTDCPP
+       select BR2_PTHREADS_NATIVE
+       select BR2_PACKAGE_JPEG

E.G. it has always been like that.

-- 
Bye, Peter Korsgaard

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Will Wagner]

Peter Korsgaard wrote:
>>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:
> 
>  >> So how did that work with the select BR2_PTHREADS_NATIVE?
>  >> 
> 
>  Hans-Christian> Probably because I did not compile qtopia4 from
>  Hans-Christian> mainstream trunk after that select was introduced.
> 
> Really?
> 
> Author: aldot <aldot@69ca8d6d-28ef-0310-b511-8ec308f3f277>
> Date:   Wed Dec 13 19:59:07 2006 +0000
> 
>     - Thomas Lundquist added qtopia4 support. Untested.
> 
>     git-svn-id: svn+ssh://uclibc.org/svn/trunk/buildroot at 16904
> 
> +config BR2_PACKAGE_QTOPIA4
> +       bool "qtopia4"
> +       default n
> +       select BR2_INSTALL_LIBSTDCPP
> +       select BR2_PTHREADS_NATIVE
> +       select BR2_PACKAGE_JPEG
> 
> E.G. it has always been like that.
> 

I have been patching qtopia4 config for a long time to remove the NPTL select. Works fine 
on arm and x86 with both old linux threads and linux threads.

-- 
------------------------------------------------------------------------
Will Wagner                                     will_wagner at carallon.com
Development Manager                      Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Peter Korsgaard]

>>>>> "Will" == Will Wagner <will_wagner@carallon.com> writes:

Hi,

 Will> I have been patching qtopia4 config for a long time to remove
 Will> the NPTL select. Works fine on arm and x86 with both old linux
 Will> threads and linux threads.

Ok, thanks - Will remove.

-- 
Bye, Peter Korsgaard

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Hans-Christian Egtvedt]

Peter Korsgaard wrote:
>>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:
> 
>  >> So how did that work with the select BR2_PTHREADS_NATIVE?
>  >> 
> 
>  Hans-Christian> Probably because I did not compile qtopia4 from
>  Hans-Christian> mainstream trunk after that select was introduced.
> 
> Really?
> 
> Author: aldot <aldot@69ca8d6d-28ef-0310-b511-8ec308f3f277>
> Date:   Wed Dec 13 19:59:07 2006 +0000
> 
>     - Thomas Lundquist added qtopia4 support. Untested.
> 
>     git-svn-id: svn+ssh://uclibc.org/svn/trunk/buildroot at 16904
> 
> +config BR2_PACKAGE_QTOPIA4
> +       bool "qtopia4"
> +       default n
> +       select BR2_INSTALL_LIBSTDCPP
> +       select BR2_PTHREADS_NATIVE
> +       select BR2_PACKAGE_JPEG
> 
> E.G. it has always been like that.
> 

I have no idea what have happened, but the select does not trigger...

~ > grep NATIVE .config
# BR2_PTHREADS_NATIVE is not set

~ > grep NATIVE toolchain_build_avr32/uClibc-0.9.30/.config
~ >

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] svn commit: trunk/buildroot/package: fuse lzma netkitbase qtopia4

[Peter Korsgaard]

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

Hi,

 Hans-Christian> I have no idea what have happened, but the select
 Hans-Christian> does not trigger...

 Hans-Christian> ~ > grep NATIVE .config
 Hans-Christian> # BR2_PTHREADS_NATIVE is not set

 Hans-Christian> ~ > grep NATIVE toolchain_build_avr32/uClibc-0.9.30/.config
 Hans-Christian> ~ >

Strange - Anyway, I'll remove it.

-- 
Bye, Peter Korsgaard