Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libusb: Fix host autotools dependency
@ 2009-03-31 21:12 Michael Roth
  2009-04-02  1:24 ` Hamish Moffatt
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Roth @ 2009-03-31 21:12 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Michael Roth <mroth@nessie.de>
---
 package/libusb/libusb.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
index bf831da..f7cad77 100644
--- a/package/libusb/libusb.mk
+++ b/package/libusb/libusb.mk
@@ -23,7 +23,7 @@ $(DL_DIR)/$(LIBUSB_SOURCE): $(LIBUSB_PATCH)
 libusb-source: $(DL_DIR)/$(LIBUSB_SOURCE) $(LIBUSB_PATCH)
 
 libusb-unpacked: $(LIBUSB_DIR)/.unpacked
-$(LIBUSB_DIR)/.unpacked: $(AUTOCONF) $(AUTOMAKE) $(LIBTOOL) $(DL_DIR)/$(LIBUSB_SOURCE)
+$(LIBUSB_DIR)/.unpacked: $(DL_DIR)/$(LIBUSB_SOURCE)
 	$(LIBUSB_CAT) $(DL_DIR)/$(LIBUSB_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
 ifneq ($(LIBUSB_PATCH_FILE),)
 	(cd $(LIBUSB_DIR) && $(LIBUSB_CAT) $(LIBUSB_PATCH) | patch -p1)
@@ -58,7 +58,7 @@ $(TARGET_DIR)/$(LIBUSB_BINARY): $(STAGING_DIR)/usr/lib/libusb.so
 	cp -dpf $(STAGING_DIR)/usr/lib/libusb*.so* $(TARGET_DIR)/usr/lib/
 	$(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/lib/libusb*.so*
 
-libusb: uclibc host-pkgconfig $(TARGET_DIR)/$(LIBUSB_BINARY)
+libusb: uclibc host-pkgconfig host-automake host-autoconf host-libtool $(TARGET_DIR)/$(LIBUSB_BINARY)
 
 libusb-clean:
 	rm -f $(STAGING_DIR)/bin/libusb-config
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] libusb: Fix host autotools dependency
  2009-03-31 21:12 [Buildroot] [PATCH] libusb: Fix host autotools dependency Michael Roth
@ 2009-04-02  1:24 ` Hamish Moffatt
  2009-04-02  9:32   ` Michael Roth
  0 siblings, 1 reply; 3+ messages in thread
From: Hamish Moffatt @ 2009-04-02  1:24 UTC (permalink / raw)
  To: buildroot

On Tue, Mar 31, 2009 at 11:12:34PM +0200, Michael Roth wrote:
> Signed-off-by: Michael Roth <mroth@nessie.de>
> ---
>  package/libusb/libusb.mk |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
> index bf831da..f7cad77 100644
> --- a/package/libusb/libusb.mk
> +++ b/package/libusb/libusb.mk
> @@ -23,7 +23,7 @@ $(DL_DIR)/$(LIBUSB_SOURCE): $(LIBUSB_PATCH)
>  libusb-source: $(DL_DIR)/$(LIBUSB_SOURCE) $(LIBUSB_PATCH)
>  
>  libusb-unpacked: $(LIBUSB_DIR)/.unpacked
> -$(LIBUSB_DIR)/.unpacked: $(AUTOCONF) $(AUTOMAKE) $(LIBTOOL) $(DL_DIR)/$(LIBUSB_SOURCE)
> +$(LIBUSB_DIR)/.unpacked: $(DL_DIR)/$(LIBUSB_SOURCE)
>  	$(LIBUSB_CAT) $(DL_DIR)/$(LIBUSB_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
>  ifneq ($(LIBUSB_PATCH_FILE),)
>  	(cd $(LIBUSB_DIR) && $(LIBUSB_CAT) $(LIBUSB_PATCH) | patch -p1)
> @@ -58,7 +58,7 @@ $(TARGET_DIR)/$(LIBUSB_BINARY): $(STAGING_DIR)/usr/lib/libusb.so
>  	cp -dpf $(STAGING_DIR)/usr/lib/libusb*.so* $(TARGET_DIR)/usr/lib/
>  	$(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/lib/libusb*.so*
>  
> -libusb: uclibc host-pkgconfig $(TARGET_DIR)/$(LIBUSB_BINARY)
> +libusb: uclibc host-pkgconfig host-automake host-autoconf host-libtool $(TARGET_DIR)/$(LIBUSB_BINARY)

What does this fix?

I had lots of problems with libusb being rebuilt every time a while ago
with a change like the above. It might be better now with $(HOST_DIR)
etc. Please check.

Hamish
-- 
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] libusb: Fix host autotools dependency
  2009-04-02  1:24 ` Hamish Moffatt
@ 2009-04-02  9:32   ` Michael Roth
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Roth @ 2009-04-02  9:32 UTC (permalink / raw)
  To: buildroot

> What does this fix?

Problem was, that autotools were not build because $(AUTOCONF),
$(AUTOMAKE) and $(LIBTOOL) don't have any dependency.

Maybe I should make the commit messages more explicit.


> I had lots of problems with libusb being rebuilt every time a while ago
> with a change like the above. It might be better now with $(HOST_DIR)
> etc. Please check.

Hmm. I will check this.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-04-02  9:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-31 21:12 [Buildroot] [PATCH] libusb: Fix host autotools dependency Michael Roth
2009-04-02  1:24 ` Hamish Moffatt
2009-04-02  9:32   ` Michael Roth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox