[Buildroot] x86_64 error2

[Buildroot] x86_64 error2

[Mark Constable]

Continuing on from the previous error with a manual make, uclibc
and gcc apparently built but the build ended with this error...

...
/home/sources/srcpkgs/eth-os/cli/buildroot/src/buildroot-2009.05/build_x86_64/makedevs-host
/usr/bin/gcc -Wall -Werror -O2 /home/sources/srcpkgs/eth-os/cli/buildroot/src/buildroot-2009.05/build_x86_64/makedevs-host/makedevs.c -o /home/sources/srcpkgs/eth-os/cli/buildroot/src/buildroot-2009.05/build_x86_64/makedevs-host/makedevs
/usr/bin/install -m 755 /home/sources/srcpkgs/eth-os/cli/buildroot/src/buildroot-2009.05/build_x86_64/makedevs-host/makedevs /home/sources/srcpkgs/eth-os/cli/buildroot/src/buildroot-2009.05/build_x86_64/host_dir/usr/bin/makedevs
make: /usr/bin/install: Command not found
make: *** [/home/sources/srcpkgs/eth-os/cli/buildroot/src/buildroot-2009.05/build_x86_64/host_dir/usr/bin/makedevs] Error 127

My Archlinux based hosts coreutils package installs "install"
as /bin/install. Sure I can make a softlink, but shouldn't the
buildroot procedure just use "install" from the $PATH?

--markc

[Buildroot] x86_64 error2

[Thomas Petazzoni]

Le Fri, 31 Jul 2009 14:19:03 +1000,
Mark Constable <markc@renta.net> a ?crit :

> My Archlinux based hosts coreutils package installs "install"
> as /bin/install. Sure I can make a softlink, but shouldn't the
> buildroot procedure just use "install" from the $PATH?

Something like the patch below should fix it. If it does, please
confirm, I'll send out a pull request for this patch.

Sincerly,

Thomas

commit 1a2433b58e841f36790bd4015e1a19e5b9793d9a
Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date:   Fri Jul 31 08:48:03 2009 +0200

    makefile: don't hardcore install utility location
    
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

diff --git a/package/Makefile.in b/package/Makefile.in
index 3dcdfe1..0829e8f 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -181,7 +181,7 @@ ifeq ($(BR2_STRIP_none),y)
 TARGET_STRIP=true -Not_stripping
 STRIPCMD=$(TARGET_STRIP)
 endif
-INSTALL=/usr/bin/install
+INSTALL=$(shell which install || type -p install)
 FLEX:=$(shell which flex || type -p flex)
 BISON:=$(shell which bison || type -p bison)


-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com