[Buildroot] [PATCH] "libdir" variable is not set correctly in (generated) $(STAGING_DIR)/usr/lib/libSDL.la

[Buildroot] [PATCH] "libdir" variable is not set correctly in (generated) $(STAGING_DIR)/usr/lib/libSDL.la

[julien.boibessot at free.fr]

From: Julien Boibessot <julien.boibessot@armadeus.com>

"libdir" is set to "/xxx/output/build/staging_dir/usr/xxx/output/build/staging_dir/usr/lib"
instead of "/xxx/output/build/staging_dir/usr/lib". This prevents other apps to link against SDL.
This patch try to correct/workaround that (is it the best way to do it ?).

Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
---
 package/sdl/sdl.mk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
index 959be7e..60eccaa 100644
--- a/package/sdl/sdl.mk
+++ b/package/sdl/sdl.mk
@@ -97,6 +97,9 @@ $(STAGING_DIR)/usr/lib/libSDL.so: $(SDL_DIR)/.compiled
 # use correct rpath for linking
 	$(SED) 's^libdir=\$${exec_prefix}^libdir=/usr^' \
 		$(STAGING_DIR)/usr/bin/sdl-config
+# set correct libdir path in libSDL.la
+	$(SED) "s^libdir='$(STAGING_DIR)/usr^libdir='^" \
+		$(STAGING_DIR)/usr/lib/libSDL.la
 	touch -c $@
 
 $(TARGET_DIR)/usr/lib/libSDL.so: $(STAGING_DIR)/usr/lib/libSDL.so
-- 
1.6.0.4

[Buildroot] [PATCH] "libdir" variable is not set correctly in (generated) $(STAGING_DIR)/usr/lib/libSDL.la

[Lionel Landwerlin]

It already handled in Makefile.autotools.in. That's why you see the path to
the staging directory twice, it's twice processed.
You can just remove the line.

--
Lionel

On Wed, Jan 27, 2010 at 3:54 PM, <julien.boibessot@free.fr> wrote:

> From: Julien Boibessot <julien.boibessot@armadeus.com>
>
> "libdir" is set to
> "/xxx/output/build/staging_dir/usr/xxx/output/build/staging_dir/usr/lib"
> instead of "/xxx/output/build/staging_dir/usr/lib". This prevents other
> apps to link against SDL.
> This patch try to correct/workaround that (is it the best way to do it ?).
>
> Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
> ---
>  package/sdl/sdl.mk |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> index 959be7e..60eccaa 100644
> --- a/package/sdl/sdl.mk
> +++ b/package/sdl/sdl.mk
> @@ -97,6 +97,9 @@ $(STAGING_DIR)/usr/lib/libSDL.so: $(SDL_DIR)/.compiled
>  # use correct rpath for linking
>        $(SED) 's^libdir=\$${exec_prefix}^libdir=/usr^' \
>                $(STAGING_DIR)/usr/bin/sdl-config
> +# set correct libdir path in libSDL.la
> +       $(SED) "s^libdir='$(STAGING_DIR)/usr^libdir='^" \
> +               $(STAGING_DIR)/usr/lib/libSDL.la
>        touch -c $@
>
>  $(TARGET_DIR)/usr/lib/libSDL.so: $(STAGING_DIR)/usr/lib/libSDL.so
> --
> 1.6.0.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100127/e97b5d9f/attachment.htm>

[Buildroot] [PATCH] "libdir" variable is not set correctly in (generated) $(STAGING_DIR)/usr/lib/libSDL.la

[Julien Boibessot]

Hi Lionel,

Lionel Landwerlin a ?crit :
> It already handled in Makefile.autotools.in
> <http://Makefile.autotools.in>. That's why you see the path to the
> staging directory twice, it's twice processed.
> You can just remove the line.
you mean: converting package/sdl/sdl.mk to autotools infrastructure will
solve the problem ?

Regards,
Julien