* [Buildroot] [pull request] Pull request for branch for-2010.11
@ 2010-11-23 18:10 Gustavo Zacarias
2010-11-23 19:30 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Zacarias @ 2010-11-23 18:10 UTC (permalink / raw)
To: buildroot
Misc fixes for 2010.11...
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pull-request.txt
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101123/012bcee9/attachment.txt>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [pull request] Pull request for branch for-2010.11
2010-11-23 18:10 [Buildroot] [pull request] Pull request for branch for-2010.11 Gustavo Zacarias
@ 2010-11-23 19:30 ` Thomas Petazzoni
2010-11-24 14:15 ` Gustavo Zacarias
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2010-11-23 19:30 UTC (permalink / raw)
To: buildroot
On Tue, 23 Nov 2010 15:10:39 -0300
Gustavo Zacarias <gustavo@zacarias.com.ar> wrote:
> Misc fixes for 2010.11...
Could you try to post the patches themselves ?
In "squid: bump to version 3.1.9", I don't agree with:
SQUID_MAKE_OPT = CXX_FOR_BUILD=g++
CXX_FOR_BUILD is already passed in $(TARGET_CONFIGURE_OPTS), so this
shouldn't be necessary. And if it really is, then $(HOSTCXX) should be
used instead.
The rest looks ok to me.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [pull request] Pull request for branch for-2010.11
2010-11-23 19:30 ` Thomas Petazzoni
@ 2010-11-24 14:15 ` Gustavo Zacarias
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo Zacarias @ 2010-11-24 14:15 UTC (permalink / raw)
To: buildroot
On 11/23/10 16:30, Thomas Petazzoni wrote:
> Could you try to post the patches themselves ?
>
> In "squid: bump to version 3.1.9", I don't agree with:
>
> SQUID_MAKE_OPT = CXX_FOR_BUILD=g++
>
> CXX_FOR_BUILD is already passed in $(TARGET_CONFIGURE_OPTS), so this
> shouldn't be necessary. And if it really is, then $(HOSTCXX) should be
> used instead.
>
> The rest looks ok to me.
>
> Thomas
Sure thing, resent as v2.
Ditched it, no longer required, was a leftover.
Regards.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-24 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-23 18:10 [Buildroot] [pull request] Pull request for branch for-2010.11 Gustavo Zacarias
2010-11-23 19:30 ` Thomas Petazzoni
2010-11-24 14:15 ` Gustavo Zacarias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox