Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] New package: sdparm
@ 2010-12-06 10:58 Yegor Yefremov
  2010-12-06 20:05 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Yegor Yefremov @ 2010-12-06 10:58 UTC (permalink / raw)
  To: buildroot

Add utility to accesses SCSI device parameters.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Index: b/package/sdparm/Config.in
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ b/package/sdparm/Config.in	2010-12-06 11:14:41.000000000 +0100
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_SDPARM
+	bool "sdparm"
+	help
+	  Utility to accesses SCSI device parameters.
Index: b/package/sdparm/sdparm.mk
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ b/package/sdparm/sdparm.mk	2010-12-06 08:33:16.000000000 +0100
@@ -0,0 +1,7 @@
+SDPARM_VERSION = 1.06
+SDPARM_SOURCE = sdparm-$(SDPARM_VERSION).tgz
+SDPARM_SITE = http://sg.danny.cz/sg/p/
+SDPARM_INSTALL_STAGING = NO
+SDPARM_INSTALL_TARGET = YES
+
+$(eval $(call AUTOTARGETS,package,sdparm))
Index: b/package/Config.in
===================================================================
--- a/package/Config.in	2010-11-08 12:09:05.000000000 +0100
+++ b/package/Config.in	2010-12-03 17:37:41.000000000 +0100
@@ -184,6 +184,7 @@
 source "package/ntfsprogs/Config.in"
 source "package/pciutils/Config.in"
 source "package/rng-tools/Config.in"
+source "package/sdparm/Config.in"
 source "package/setserial/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 # busybox has fdisk

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] New package: sdparm
  2010-12-06 10:58 [Buildroot] [PATCH] New package: sdparm Yegor Yefremov
@ 2010-12-06 20:05 ` Thomas Petazzoni
  2010-12-07  9:07   ` Yegor Yefremov
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2010-12-06 20:05 UTC (permalink / raw)
  To: buildroot

Hello Yegor,

On Mon, 06 Dec 2010 11:58:33 +0100
Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:

> Index: b/package/sdparm/Config.in
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ b/package/sdparm/Config.in	2010-12-06 11:14:41.000000000
> +0100 @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_SDPARM
> +	bool "sdparm"
> +	help
> +	  Utility to accesses SCSI device parameters.

We generally put the URL of the project here in the help text.

> Index: b/package/sdparm/sdparm.mk
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ b/package/sdparm/sdparm.mk	2010-12-06 08:33:16.000000000
> +0100 @@ -0,0 +1,7 @@
> +SDPARM_VERSION = 1.06
> +SDPARM_SOURCE = sdparm-$(SDPARM_VERSION).tgz
> +SDPARM_SITE = http://sg.danny.cz/sg/p/
> +SDPARM_INSTALL_STAGING = NO
> +SDPARM_INSTALL_TARGET = YES

You can get rid of those last two lines, they are the default behaviour.

Once you have fixed those two minors comment, you get my:

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Peter: it builds fine here with a minimal Buildroot toolchain (no
largefile, no IPv6, no locale, etc.).

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] New package: sdparm
  2010-12-06 20:05 ` Thomas Petazzoni
@ 2010-12-07  9:07   ` Yegor Yefremov
  0 siblings, 0 replies; 3+ messages in thread
From: Yegor Yefremov @ 2010-12-07  9:07 UTC (permalink / raw)
  To: buildroot

Hello Thomas,

> Hello Yegor,
>
> On Mon, 06 Dec 2010 11:58:33 +0100
> Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:
>
>> Index: b/package/sdparm/Config.in
>> ===================================================================
>> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
>> +++ b/package/sdparm/Config.in	2010-12-06 11:14:41.000000000
>> +0100 @@ -0,0 +1,4 @@
>> +config BR2_PACKAGE_SDPARM
>> +	bool "sdparm"
>> +	help
>> +	  Utility to accesses SCSI device parameters.
> We generally put the URL of the project here in the help text.
>
>> Index: b/package/sdparm/sdparm.mk
>> ===================================================================
>> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
>> +++ b/package/sdparm/sdparm.mk	2010-12-06 08:33:16.000000000
>> +0100 @@ -0,0 +1,7 @@
>> +SDPARM_VERSION = 1.06
>> +SDPARM_SOURCE = sdparm-$(SDPARM_VERSION).tgz
>> +SDPARM_SITE = http://sg.danny.cz/sg/p/
>> +SDPARM_INSTALL_STAGING = NO
>> +SDPARM_INSTALL_TARGET = YES
> You can get rid of those last two lines, they are the default behaviour.
>

I made the changes. Thanks for reviewing.

Yegor

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-07  9:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-06 10:58 [Buildroot] [PATCH] New package: sdparm Yegor Yefremov
2010-12-06 20:05 ` Thomas Petazzoni
2010-12-07  9:07   ` Yegor Yefremov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox