[Buildroot] [Bug 3007] New: kexec doesn't build: Missing regdef.h file

[Buildroot] [Bug 3007] New: kexec doesn't build: Missing regdef.h file

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=3007

           Summary: kexec doesn't build:  Missing regdef.h file
           Product: buildroot
           Version: unspecified
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: andy.kennedy at adtran.com
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


Target is mips-32r2

kexec/arch/mips/mips-setup-simple.S:17:20: fatal error: regdef.h: No such file
or directory
compilation terminated.


Simple fix is to copy the file from
output/toolchain/uClibc-0.9.31/libc/sysdeps/linux/mips/sys/regdef.h

to:
output/build/kexec-2.0.1/kexec/arch/mips/include

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 3007] kexec doesn't build: Missing regdef.h file

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=3007

--- Comment #1 from Andy Kennedy <andy.kennedy@adtran.com>  ---
After further playing, I have found that for kexec to build properly, one needs
to bring the regdef.h file from the Linux Kernel (in the case of mips that
would be:  arch/mips/include/asm/regdef.h)  There are some interesting ifdef's
around sections of the one that is under the toolchain included files.  There
are about 3 different versions of this file -- the one in the kernel source is
the only one I can make work with kexec.

Andy

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 3007] kexec doesn't build: Missing regdef.h file

[ANDY KENNEDY]

> -----Original Message-----
> From: buildroot-bounces at busybox.net [mailto:buildroot-
> bounces at busybox.net] On Behalf Of bugzilla at busybox.net
> Sent: Tuesday, December 28, 2010 4:59 PM
> To: buildroot at uclibc.org
> Subject: [Buildroot] [Bug 3007] kexec doesn't build: Missing regdef.h
> file
> 
> https://bugs.busybox.net/show_bug.cgi?id=3007
> 
> --- Comment #1 from Andy Kennedy <andy.kennedy@adtran.com>  ---
> After further playing, I have found that for kexec to build properly,
> one needs
> to bring the regdef.h file from the Linux Kernel (in the case of mips
> that
> would be:  arch/mips/include/asm/regdef.h)  There are some interesting
> ifdef's
> around sections of the one that is under the toolchain included files.
> There
> are about 3 different versions of this file -- the one in the kernel
> source is
> the only one I can make work with kexec.
> 
> Andy
> 
> --
> Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

The following patch is against Gustavo's latest toolchain_rebuild.


--- a/package/Makefile.package.in       2010-12-30 09:57:01.000000000
-0600
+++ b/package/Makefile.package.in       2010-12-30 00:47:21.000000000
-0600
@@ -260,6 +260,11 @@
 $(BUILD_DIR)/%/.stamp_patched: NAMEVER =
$($(NOHOSTPKG)_NAME)-$($(PKG)_VERSION)
 $(BUILD_DIR)/%/.stamp_patched:
        @$(call MESSAGE,"Patching $($(PKG)_DIR_PREFIX)/$($(PKG)_NAME)")
+ifeq ($(BR2_ARCH),"mips")
+       $(Q)if test "$($(NOHOSTPKG)_NAME)" == "kexec" ; then \
+         cp -f
output/toolchain/linux-$(BR2_DEFAULT_KERNEL_HEADERS)/arch/mips/include/a
sm/regdef.h $(@D)/kexec/arch/mips/include ; \
+       fi
+endif
        $(if $($(PKG)_PATCH),toolchain/patch-kernel.sh $(@D) $(DL_DIR)
$($(PKG)_PATCH))
        $(Q)( \
        if test -d $($(PKG)_DIR_PREFIX)/$($(NOHOSTPKG)_NAME); then \



There's a lot of hard-coded links in it, but I don't know the whole
build system enough to use the environmental variables.

Gustavo -- if you want to "fix" this patch and plug it in to your
branch, that'd be great ;).


Andy

[Buildroot] [Bug 3007] kexec doesn't build: Missing regdef.h file

[Gustavo Zacarias]

On 12/30/10 13:02, ANDY KENNEDY wrote:

> There's a lot of hard-coded links in it, but I don't know the whole
> build system enough to use the environmental variables.
> 
> Gustavo -- if you want to "fix" this patch and plug it in to your
> branch, that'd be great ;).
> 
> 
> Andy

Tried with kexec-tools 2.0.2?
Seems it doesn't depend on regdef.h any more...

[Buildroot] [Bug 3007] kexec doesn't build: Missing regdef.h file

[ANDY KENNEDY]

> On 12/30/10 13:02, ANDY KENNEDY wrote:
> 
> > There's a lot of hard-coded links in it, but I don't know the whole
> > build system enough to use the environmental variables.
> >
> > Gustavo -- if you want to "fix" this patch and plug it in to your
> > branch, that'd be great ;).
> >
> >
> > Andy
> 
> Tried with kexec-tools 2.0.2?
> Seems it doesn't depend on regdef.h any more...

Okay, why then do we not have:

diff -Naur a/package/kexec/Config.in b/package/kexec/Config.in
--- a/package/kexec/Config.in   2010-12-30 09:57:01.000000000 -0600
+++ b/package/kexec/Config.in   2010-12-30 11:44:52.000000000 -0600
@@ -6,6 +6,11 @@
 
 
http://www.kernel.org/pub/linux/kernel/people/horms/kexec-tools/
 
+config BR2_PACKAGE_KEXEC_VERSION
+       string "kexec version to build"
+       depends on BR2_PACKAGE_KEXEC
+       default "2.0.1"
+
 config BR2_PACKAGE_KEXEC_ZLIB
        bool "Kexec with zlib support"
        depends on BR2_PACKAGE_KEXEC
diff -Naur a/package/kexec/kexec.mk b/package/kexec/kexec.mk
--- a/package/kexec/kexec.mk    2010-12-30 09:57:01.000000000 -0600
+++ b/package/kexec/kexec.mk    2010-12-30 12:04:31.000000000 -0600
@@ -3,9 +3,9 @@
 # kexec
 #
 #############################################################
-KEXEC_VERSION = 2.0.1
+KEXEC_VERSION = $(BR2_PACKAGE_KEXEC_VERSION)
 KEXEC_SOURCE = kexec-tools-$(KEXEC_VERSION).tar.bz2
-KEXEC_SITE =
$(BR2_KERNEL_MIRROR)/linux/kernel/people/horms/kexec-tools/
+KEXEC_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kexec
 
 ifeq ($(BR2_PACKAGE_KEXEC_ZLIB),y)
 KEXEC_CONF_OPT += --with-zlib

[Buildroot] [Bug 3007] kexec doesn't build: Missing regdef.h file

[Gustavo Zacarias]

On 12/30/2010 03:15 PM, ANDY KENNEDY wrote:

> Okay, why then do we not have:
> 
> diff -Naur a/package/kexec/Config.in b/package/kexec/Config.in
> --- a/package/kexec/Config.in   2010-12-30 09:57:01.000000000 -0600
> +++ b/package/kexec/Config.in   2010-12-30 11:44:52.000000000 -0600
> @@ -6,6 +6,11 @@
>  
>  
> http://www.kernel.org/pub/linux/kernel/people/horms/kexec-tools/
>  
> +config BR2_PACKAGE_KEXEC_VERSION
> +       string "kexec version to build"
> +       depends on BR2_PACKAGE_KEXEC
> +       default "2.0.1"
> +
>  config BR2_PACKAGE_KEXEC_ZLIB
>         bool "Kexec with zlib support"
>         depends on BR2_PACKAGE_KEXEC
> diff -Naur a/package/kexec/kexec.mk b/package/kexec/kexec.mk
> --- a/package/kexec/kexec.mk    2010-12-30 09:57:01.000000000 -0600
> +++ b/package/kexec/kexec.mk    2010-12-30 12:04:31.000000000 -0600
> @@ -3,9 +3,9 @@
>  # kexec
>  #
>  #############################################################
> -KEXEC_VERSION = 2.0.1
> +KEXEC_VERSION = $(BR2_PACKAGE_KEXEC_VERSION)
>  KEXEC_SOURCE = kexec-tools-$(KEXEC_VERSION).tar.bz2
> -KEXEC_SITE =
> $(BR2_KERNEL_MIRROR)/linux/kernel/people/horms/kexec-tools/
> +KEXEC_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kexec
>  
>  ifeq ($(BR2_PACKAGE_KEXEC_ZLIB),y)
>  KEXEC_CONF_OPT += --with-zlib

Easier to just use the latest if there are no drawbacks, otherwise we
get a moving target and avoid the "option overload" situation too.

[Buildroot] [Bug 3007] kexec doesn't build: Missing regdef.h file

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=3007

Peter Korsgaard <jacmet@uclibc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Peter Korsgaard <jacmet@uclibc.org>  ---
Fixed by kexec version bump in git, thanks

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.