[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Luca Ceresoli]

Daniel Nystr?m wrote:
> > In other words, which use case is this solving ? If it's a general font
> > location problem, maybe this should not be a Liberation-specific option.
> 
> In my opinion, letting default installation directory keep using font
> named subdir but still configurable would cover most cases.

I think Thomas is right: a unique setting should be used to override
the font install dir.

It might look like this in menuconfig:

      *** X libraries and helper libraries ***
  ()  Force all fonts to be installed here {*}
  [*] DejaVu (Free fonts)  --->
  [ ] Liberation (Free fonts) 
      *** X Window managers ***

{*} if this is empty, each font .mk will install in the default directory,
as liberation does in current head;
otherwise all fonts will be copied in the directory specified.

How about this?

Luca

[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Thomas Petazzoni]

Hello,

On Wed, 12 Jan 2011 14:51:09 +0100
"Luca Ceresoli" <list@lucaceresoli.net> wrote:

> I think Thomas is right: a unique setting should be used to override
> the font install dir.
> 
> It might look like this in menuconfig:
> 
>       *** X libraries and helper libraries ***
>   ()  Force all fonts to be installed here {*}
>   [*] DejaVu (Free fonts)  --->
>   [ ] Liberation (Free fonts) 
>       *** X Window managers ***
> 
> {*} if this is empty, each font .mk will install in the default directory,
> as liberation does in current head;
> otherwise all fonts will be copied in the directory specified.
> 
> How about this?

That could be one solution. The other solution would be to hide this
from the user, i.e an unvisible configuration option to select the
installation location of the fonts (i.e ? fonts in subdirs ? or ? all
fonts in /usr/share/fonts ?). ? fonts in subdirs ? would be the
default, and ? all fonts in /usr/share/fonts/ ? would be selected by
Nano-X/Microwindows. This way, the user wouldn't have to worry about
the installation location of fonts.

But for the moment, we don't have any microwin package. It got removed
in september 2010, due to upstream inactivity. But it seems that the
project is active again, and a new release has been made. So obviously,
we could re-add such a package if someone submits it.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Luca Ceresoli]

Thomas Petazzoni wrote:
> Hello,
> 
> On Wed, 12 Jan 2011 14:51:09 +0100
> "Luca Ceresoli" <list@lucaceresoli.net> wrote:
> 
> > I think Thomas is right: a unique setting should be used to override
> > the font install dir.
> > 
> > It might look like this in menuconfig:
> > 
> >       *** X libraries and helper libraries ***
> >   ()  Force all fonts to be installed here {*}
> >   [*] DejaVu (Free fonts)  --->
> >   [ ] Liberation (Free fonts) 
> >       *** X Window managers ***
> > 
> > {*} if this is empty, each font .mk will install in the default directory,
> > as liberation does in current head;
> > otherwise all fonts will be copied in the directory specified.
> > 
> > How about this?
> 
> That could be one solution. The other solution would be to hide this
> from the user, i.e an unvisible configuration option to select the
> installation location of the fonts (i.e ? fonts in subdirs ? or ? all
> fonts in /usr/share/fonts ?). ? fonts in subdirs ? would be the
> default, and ? all fonts in /usr/share/fonts/ ? would be selected by
> Nano-X/Microwindows. This way, the user wouldn't have to worry about
> the installation location of fonts.

That would not be enough in my case.
I don't use Nano-x/Microwin, my setup is based on qt + directfb + freetype.
I am not sure which of these components needs fonts in a specific dir,
but if fonts are in subdirs they won't be found.

Luca

[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Thomas Petazzoni]

On Fri, 14 Jan 2011 17:48:45 +0100
"Luca Ceresoli" <list@lucaceresoli.net> wrote:

> > That could be one solution. The other solution would be to hide this
> > from the user, i.e an unvisible configuration option to select the
> > installation location of the fonts (i.e ? fonts in subdirs ? or ? all
> > fonts in /usr/share/fonts ?). ? fonts in subdirs ? would be the
> > default, and ? all fonts in /usr/share/fonts/ ? would be selected by
> > Nano-X/Microwindows. This way, the user wouldn't have to worry about
> > the installation location of fonts.
> 
> That would not be enough in my case.
> I don't use Nano-x/Microwin, my setup is based on qt + directfb + freetype.
> I am not sure which of these components needs fonts in a specific dir,
> but if fonts are in subdirs they won't be found.

Sorry, but I do not understand why it wouldn't be enough. If you need
all the fonts in a single directory, you would just select the ? all
fonts in /usr/share/fonts ? case, and that would work, no ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Luca Ceresoli]

Thomas Petazzoni wrote:
> On Fri, 14 Jan 2011 17:48:45 +0100
> "Luca Ceresoli" <list@lucaceresoli.net> wrote:
>
>   
>>> That could be one solution. The other solution would be to hide this
>>> from the user, i.e an unvisible configuration option to select the
>>> installation location of the fonts (i.e ? fonts in subdirs ? or ? all
>>> fonts in /usr/share/fonts ?). ? fonts in subdirs ? would be the
>>> default, and ? all fonts in /usr/share/fonts/ ? would be selected by
>>> Nano-X/Microwindows. This way, the user wouldn't have to worry about
>>> the installation location of fonts.
>>>       
>> That would not be enough in my case.
>> I don't use Nano-x/Microwin, my setup is based on qt + directfb + freetype.
>> I am not sure which of these components needs fonts in a specific dir,
>> but if fonts are in subdirs they won't be found.
>>     
>
> Sorry, but I do not understand why it wouldn't be enough. If you need
> all the fonts in a single directory, you would just select the ? all
> fonts in /usr/share/fonts ? case, and that would work, no ?
>   

I was commenting on the *automatic* choice of the font location. You 
proposed an algorithm that would install fonts in a unique directory if 
microwin is installed. I only wanted ti point out that the condition 
should include other packages, i.e. it should install in a unique dir if 
microwin or qt or directfb or freetype are installed.

I am not against automatic choice, but the buildroot user would be more 
conscious of what's going on if there were an explicit item in 
menuconfig. Of course the most reasonable default value for such an item 
would be "microwin or qt or...", and a couple lines explaining that in 
the help would be wise.


Luca

[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Daniel Nyström]

Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
---
 package/liberation/Config.in     |    9 +++++++++
 package/liberation/liberation.mk |    2 +-
 2 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/package/liberation/Config.in b/package/liberation/Config.in
index 48d4195..9295b4e 100644
--- a/package/liberation/Config.in
+++ b/package/liberation/Config.in
@@ -5,3 +5,12 @@ config BR2_PACKAGE_LIBERATION
 	  three most commonly used fonts on Microsoft systems:
 	  Times New Roman, Arial, and Courier New.
 
+if BR2_PACKAGE_LIBERATION
+
+config BR2_PACKAGE_LIBERATION_INSTALL_DIR
+	string "Install directory"
+	default "/usr/share/fonts/liberation"
+	help
+	  Target directory where the fonts should be installed
+
+endif
diff --git a/package/liberation/liberation.mk b/package/liberation/liberation.mk
index 89987d6..53b817d 100644
--- a/package/liberation/liberation.mk
+++ b/package/liberation/liberation.mk
@@ -7,7 +7,7 @@ LIBERATION_VERSION = 1.06.0.20100721
 LIBERATION_SITE = http://www.fedorahosted.org/releases/l/i/liberation-fonts
 LIBERATION_SOURCE = liberation-fonts-ttf-$(LIBERATION_VERSION).tar.gz
 
-LIBERATION_TARGET_DIR = $(TARGET_DIR)/usr/share/fonts/liberation
+LIBERATION_TARGET_DIR = $(TARGET_DIR)/$(BR2_PACKAGE_LIBERATION_INSTALL_DIR)
 
 define LIBERATION_INSTALL_TARGET_CMDS
 	mkdir -p $(LIBERATION_TARGET_DIR)
-- 
1.7.1

[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Thomas Petazzoni]

Hello,

On Wed, 12 Jan 2011 12:03:14 +0100
Daniel Nystr?m <daniel.nystrom@timeterminal.se> wrote:

> +if BR2_PACKAGE_LIBERATION
> +
> +config BR2_PACKAGE_LIBERATION_INSTALL_DIR
> +	string "Install directory"
> +	default "/usr/share/fonts/liberation"
> +	help
> +	  Target directory where the fonts should be installed
> +
> +endif

Why would this be necessary ?

In other words, which use case is this solving ? If it's a general font
location problem, maybe this should not be a Liberation-specific option.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/2] liberation: add support for custom target directory

[Daniel Nyström]

2011/1/12 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
>> +if BR2_PACKAGE_LIBERATION
>> +
>> +config BR2_PACKAGE_LIBERATION_INSTALL_DIR
>> + ? ? string "Install directory"
>> + ? ? default "/usr/share/fonts/liberation"
>> + ? ? help
>> + ? ? ? Target directory where the fonts should be installed
>> +
>> +endif
>
> Why would this be necessary ?

In my case, I'm running Nano-X/Microwindows which doesn't handle fonts
in subdirs and therefore requires them being all installed in the same
directory. This was actually inspired by Luca Ceresolis' Dejavu font
contribution.

> In other words, which use case is this solving ? If it's a general font
> location problem, maybe this should not be a Liberation-specific option.

In my opinion, letting default installation directory keep using font
named subdir but still configurable would cover most cases.

/ Daniel