[Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd

Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
@ 2011-04-20  7:21 fabien.marteau at armadeus.com
  2011-04-20  8:05 ` Daniel Nyström
  2011-04-20  8:12 ` Daniel Nyström
  0 siblings, 2 replies; 12+ messages in thread
From: fabien.marteau at armadeus.com @ 2011-04-20  7:21 UTC (permalink / raw)
  To: buildroot

From: Fabien Marteau <fabien.marteau@armadeus.com>


Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>
---
 package/Config.in        |    1 +
 package/ngircd/Config.in |    6 ++++++
 package/ngircd/ngircd.mk |   11 +++++++++++
 3 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 package/ngircd/Config.in
 create mode 100644 package/ngircd/ngircd.mk

diff --git a/package/Config.in b/package/Config.in
index 014c2c0..cd49bc9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -409,6 +409,7 @@ source "package/netplug/Config.in"
 source "package/netsnmp/Config.in"
 source "package/netstat-nat/Config.in"
 source "package/nfs-utils/Config.in"
+source "package/ngircd/Config.in"
 source "package/ntp/Config.in"
 source "package/nuttcp/Config.in"
 source "package/olsr/Config.in"
diff --git a/package/ngircd/Config.in b/package/ngircd/Config.in
new file mode 100644
index 0000000..db13c41
--- /dev/null
+++ b/package/ngircd/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NGIRCD
+	bool "ngircd"
+	help
+		Next Generation IRC server deamon.
+		http://ngircd.barton.de
+
diff --git a/package/ngircd/ngircd.mk b/package/ngircd/ngircd.mk
new file mode 100644
index 0000000..0b70455
--- /dev/null
+++ b/package/ngircd/ngircd.mk
@@ -0,0 +1,11 @@
+#############################################################
+#
+# ngIRCd: Next Generation IRC Daemon
+#
+#############################################################
+NGIRCD_VERSION = 17.1
+NGIRCD_SOURCE = ngircd-17.1.tar.gz
+NGIRCD_SITE = ftp://ftp.berlios.de/pub/ngircd/
+NGIRCD_CONF_OPT =
+
+$(eval $(call AUTOTARGETS,package,ngircd))
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
  2011-04-20  7:21 [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd fabien.marteau at armadeus.com
@ 2011-04-20  8:05 ` Daniel Nyström
  2011-04-20  8:12 ` Daniel Nyström
  1 sibling, 0 replies; 12+ messages in thread
From: Daniel Nyström @ 2011-04-20  8:05 UTC (permalink / raw)
  To: buildroot

Hi Fabien!

Thanks for contributing. Just a few comments below:

2011/4/20  <fabien.marteau@armadeus.com>:
> From: Fabien Marteau <fabien.marteau@armadeus.com>
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_NGIRCD
> + ? ? ? bool "ngircd"
> + ? ? ? help
> + ? ? ? ? ? ? ? Next Generation IRC server deamon.
> + ? ? ? ? ? ? ? http://ngircd.barton.de
> +

The current format uses 1 tab for identation (as you've done) but 1
tab + 2 spaces for help text. And please put the blank line between
the description and the URL instead. :)
An ideal example: http://git.buildroot.net/buildroot/tree/package/file/Config.in

> +++ b/package/ngircd/ngircd.mk
> @@ -0,0 +1,11 @@
> +NGIRCD_CONF_OPT =

Since you do not specify any CONF_OPT you could just remove the line completely.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
  2011-04-20  7:21 [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd fabien.marteau at armadeus.com
  2011-04-20  8:05 ` Daniel Nyström
@ 2011-04-20  8:12 ` Daniel Nyström
  2011-04-20  8:49   ` Fabien Marteau
  1 sibling, 1 reply; 12+ messages in thread
From: Daniel Nyström @ 2011-04-20  8:12 UTC (permalink / raw)
  To: buildroot

Oops, one last thing:

> +NGIRCD_VERSION = 17.1
> +NGIRCD_SOURCE = ngircd-17.1.tar.gz

This should be:

+NGIRCD_VERSION = 17.1
+NGIRCD_SOURCE = ngircd-$(NGIRCD_VERSION).tar.gz

Or, as the tarball follows standard naming convention, you could just
strip the _SOURCE line as seen here:
http://git.buildroot.net/buildroot/tree/package/file/file.mk

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
  2011-04-20  8:12 ` Daniel Nyström
@ 2011-04-20  8:49   ` Fabien Marteau
  0 siblings, 0 replies; 12+ messages in thread
From: Fabien Marteau @ 2011-04-20  8:49 UTC (permalink / raw)
  To: buildroot

On 20/04/2011 10:12, Daniel Nystr?m wrote:
> Oops, one last thing:
> 
>> +NGIRCD_VERSION = 17.1
>> +NGIRCD_SOURCE = ngircd-17.1.tar.gz
> 
> This should be:
> 
> +NGIRCD_VERSION = 17.1
> +NGIRCD_SOURCE = ngircd-$(NGIRCD_VERSION).tar.gz
> 
> Or, as the tarball follows standard naming convention, you could just
> strip the _SOURCE line as seen here:
> http://git.buildroot.net/buildroot/tree/package/file/file.mk
> 

Thanks for your remarks, i will commit a new version of the patch

Fabien

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
@ 2011-04-20  8:55 fabien.marteau at armadeus.com
  2011-04-20  9:02 ` Thomas Petazzoni
  0 siblings, 1 reply; 12+ messages in thread
From: fabien.marteau at armadeus.com @ 2011-04-20  8:55 UTC (permalink / raw)
  To: buildroot

From: Fabien Marteau <fabien.marteau@armadeus.com>


Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>
---
 package/Config.in        |    1 +
 package/ngircd/Config.in |    6 ++++++
 package/ngircd/ngircd.mk |   18 ++++++++++++++++++
 3 files changed, 25 insertions(+), 0 deletions(-)
 create mode 100644 package/ngircd/Config.in
 create mode 100644 package/ngircd/ngircd.mk

diff --git a/package/Config.in b/package/Config.in
index 014c2c0..cd49bc9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -409,6 +409,7 @@ source "package/netplug/Config.in"
 source "package/netsnmp/Config.in"
 source "package/netstat-nat/Config.in"
 source "package/nfs-utils/Config.in"
+source "package/ngircd/Config.in"
 source "package/ntp/Config.in"
 source "package/nuttcp/Config.in"
 source "package/olsr/Config.in"
diff --git a/package/ngircd/Config.in b/package/ngircd/Config.in
new file mode 100644
index 0000000..1ee8dac
--- /dev/null
+++ b/package/ngircd/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NGIRCD
+	bool "ngircd"
+	help
+	  Next Generation IRC server deamon.
+
+	  http://ngircd.barton.de
diff --git a/package/ngircd/ngircd.mk b/package/ngircd/ngircd.mk
new file mode 100644
index 0000000..5e4c30b
--- /dev/null
+++ b/package/ngircd/ngircd.mk
@@ -0,0 +1,18 @@
+#############################################################
+#
+# ngIRCd: Next Generation IRC Daemon
+#
+#############################################################
+NGIRCD_VERSION = 17.1
+NGIRCD_SITE = ftp://ftp.berlios.de/pub/ngircd/
+NGIRCD_DEPENDENCIES = zlib
+
+define NGIRCD_SUPPRESS_DOCUMENTATION
+	rm -rf $(TARGET_DIR)/usr/share/doc/ngircd
+	rm -rf $(TARGET_DIR)/usr/share/man/man5/arm-linux-ngircd.conf.5
+	rm -rf $(TARGET_DIR)/usr/share/man/man8/arm-linux-ngircd.8
+endef
+
+NGIRCD_POST_INSTALL_TARGET_HOOKS+=NGIRCD_SUPPRESS_DOCUMENTATION
+
+$(eval $(call AUTOTARGETS,package,ngircd))
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
  2011-04-20  8:55 fabien.marteau at armadeus.com
@ 2011-04-20  9:02 ` Thomas Petazzoni
  0 siblings, 0 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2011-04-20  9:02 UTC (permalink / raw)
  To: buildroot

On Wed, 20 Apr 2011 10:55:56 +0200
fabien.marteau at armadeus.com wrote:

> +config BR2_PACKAGE_NGIRCD

Here you should add:

	select BR2_PACKAGE_ZLIB

since the package depends on zlib.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
@ 2011-04-20  9:18 fabien.marteau at armadeus.com
  2011-04-20 10:15 ` Daniel Nyström
  0 siblings, 1 reply; 12+ messages in thread
From: fabien.marteau at armadeus.com @ 2011-04-20  9:18 UTC (permalink / raw)
  To: buildroot

From: Fabien Marteau <fabien.marteau@armadeus.com>


Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>
---
 package/Config.in        |    1 +
 package/ngircd/Config.in |    7 +++++++
 package/ngircd/ngircd.mk |   18 ++++++++++++++++++
 3 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 package/ngircd/Config.in
 create mode 100644 package/ngircd/ngircd.mk

diff --git a/package/Config.in b/package/Config.in
index 014c2c0..cd49bc9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -409,6 +409,7 @@ source "package/netplug/Config.in"
 source "package/netsnmp/Config.in"
 source "package/netstat-nat/Config.in"
 source "package/nfs-utils/Config.in"
+source "package/ngircd/Config.in"
 source "package/ntp/Config.in"
 source "package/nuttcp/Config.in"
 source "package/olsr/Config.in"
diff --git a/package/ngircd/Config.in b/package/ngircd/Config.in
new file mode 100644
index 0000000..e8fc3d0
--- /dev/null
+++ b/package/ngircd/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_NGIRCD
+	bool "ngircd"
+	select BR2_PACKAGE_ZLIB
+	help
+	  Next Generation IRC server deamon.
+
+	  http://ngircd.barton.de
diff --git a/package/ngircd/ngircd.mk b/package/ngircd/ngircd.mk
new file mode 100644
index 0000000..5e4c30b
--- /dev/null
+++ b/package/ngircd/ngircd.mk
@@ -0,0 +1,18 @@
+#############################################################
+#
+# ngIRCd: Next Generation IRC Daemon
+#
+#############################################################
+NGIRCD_VERSION = 17.1
+NGIRCD_SITE = ftp://ftp.berlios.de/pub/ngircd/
+NGIRCD_DEPENDENCIES = zlib
+
+define NGIRCD_SUPPRESS_DOCUMENTATION
+	rm -rf $(TARGET_DIR)/usr/share/doc/ngircd
+	rm -rf $(TARGET_DIR)/usr/share/man/man5/arm-linux-ngircd.conf.5
+	rm -rf $(TARGET_DIR)/usr/share/man/man8/arm-linux-ngircd.8
+endef
+
+NGIRCD_POST_INSTALL_TARGET_HOOKS+=NGIRCD_SUPPRESS_DOCUMENTATION
+
+$(eval $(call AUTOTARGETS,package,ngircd))
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
  2011-04-20  9:18 fabien.marteau at armadeus.com
@ 2011-04-20 10:15 ` Daniel Nyström
  2011-04-26  7:14   ` Fabien Marteau
  0 siblings, 1 reply; 12+ messages in thread
From: Daniel Nyström @ 2011-04-20 10:15 UTC (permalink / raw)
  To: buildroot

2011/4/20  <fabien.marteau@armadeus.com>:
> From: Fabien Marteau <fabien.marteau@armadeus.com>
>
>
> Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>

Acked-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
  2011-04-20 10:15 ` Daniel Nyström
@ 2011-04-26  7:14   ` Fabien Marteau
  2011-04-26  8:01     ` Daniel Nyström
  0 siblings, 1 reply; 12+ messages in thread
From: Fabien Marteau @ 2011-04-26  7:14 UTC (permalink / raw)
  To: buildroot

Hi
On 20/04/2011 12:15, Daniel Nystr?m wrote:
> 2011/4/20  <fabien.marteau@armadeus.com>:
>> From: Fabien Marteau <fabien.marteau@armadeus.com>
>>
>>
>> Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>
> 
> Acked-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
That mean you will integrate it ? Or I have to resend the patch with this Acked-by ?

Fabien M

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
  2011-04-26  7:14   ` Fabien Marteau
@ 2011-04-26  8:01     ` Daniel Nyström
  0 siblings, 0 replies; 12+ messages in thread
From: Daniel Nyström @ 2011-04-26  8:01 UTC (permalink / raw)
  To: buildroot

Den 26 april 2011 09:14 skrev Fabien Marteau <fabien.marteau@armadeus.com>:
>> Acked-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
> That mean you will integrate it ? Or I have to resend the patch with this Acked-by ?

I just told the maintainer that I had a look at the patch and that it
looked good. You do not have to do anything.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
@ 2011-05-06  9:23 fabien.marteau at armadeus.com
  2011-05-06  9:49 ` Peter Korsgaard
  0 siblings, 1 reply; 12+ messages in thread
From: fabien.marteau at armadeus.com @ 2011-05-06  9:23 UTC (permalink / raw)
  To: buildroot

From: Fabien Marteau <fabien.marteau@armadeus.com>

Acked-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>
---
 package/Config.in        |    1 +
 package/ngircd/Config.in |    7 +++++++
 package/ngircd/ngircd.mk |   18 ++++++++++++++++++
 3 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 package/ngircd/Config.in
 create mode 100644 package/ngircd/ngircd.mk

diff --git a/package/Config.in b/package/Config.in
index 6f3384c..5e48ab7 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -416,6 +416,7 @@ source "package/netplug/Config.in"
 source "package/netsnmp/Config.in"
 source "package/netstat-nat/Config.in"
 source "package/nfs-utils/Config.in"
+source "package/ngircd/Config.in"
 source "package/ntp/Config.in"
 source "package/nuttcp/Config.in"
 source "package/olsr/Config.in"
diff --git a/package/ngircd/Config.in b/package/ngircd/Config.in
new file mode 100644
index 0000000..e8fc3d0
--- /dev/null
+++ b/package/ngircd/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_NGIRCD
+	bool "ngircd"
+	select BR2_PACKAGE_ZLIB
+	help
+	  Next Generation IRC server deamon.
+
+	  http://ngircd.barton.de
diff --git a/package/ngircd/ngircd.mk b/package/ngircd/ngircd.mk
new file mode 100644
index 0000000..5e4c30b
--- /dev/null
+++ b/package/ngircd/ngircd.mk
@@ -0,0 +1,18 @@
+#############################################################
+#
+# ngIRCd: Next Generation IRC Daemon
+#
+#############################################################
+NGIRCD_VERSION = 17.1
+NGIRCD_SITE = ftp://ftp.berlios.de/pub/ngircd/
+NGIRCD_DEPENDENCIES = zlib
+
+define NGIRCD_SUPPRESS_DOCUMENTATION
+	rm -rf $(TARGET_DIR)/usr/share/doc/ngircd
+	rm -rf $(TARGET_DIR)/usr/share/man/man5/arm-linux-ngircd.conf.5
+	rm -rf $(TARGET_DIR)/usr/share/man/man8/arm-linux-ngircd.8
+endef
+
+NGIRCD_POST_INSTALL_TARGET_HOOKS+=NGIRCD_SUPPRESS_DOCUMENTATION
+
+$(eval $(call AUTOTARGETS,package,ngircd))
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd
  2011-05-06  9:23 fabien.marteau at armadeus.com
@ 2011-05-06  9:49 ` Peter Korsgaard
  0 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2011-05-06  9:49 UTC (permalink / raw)
  To: buildroot

>>>>> "fabien" == fabien marteau <fabien.marteau@armadeus.com> writes:

 fabien> From: Fabien Marteau <fabien.marteau@armadeus.com>
 fabien> Acked-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
 fabien> Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>

Thanks, committed with a minor change.

 fabien> +#############################################################
 fabien> +#
 fabien> +# ngIRCd: Next Generation IRC Daemon
 fabien> +#
 fabien> +#############################################################
 fabien> +NGIRCD_VERSION = 17.1
 fabien> +NGIRCD_SITE = ftp://ftp.berlios.de/pub/ngircd/
 fabien> +NGIRCD_DEPENDENCIES = zlib
 fabien> +
 fabien> +define NGIRCD_SUPPRESS_DOCUMENTATION
 fabien> +	rm -rf $(TARGET_DIR)/usr/share/doc/ngircd
 fabien> +	rm -rf $(TARGET_DIR)/usr/share/man/man5/arm-linux-ngircd.conf.5
 fabien> +	rm -rf $(TARGET_DIR)/usr/share/man/man8/arm-linux-ngircd.8
 fabien> +endef
 fabien> +
 fabien> +NGIRCD_POST_INSTALL_TARGET_HOOKS+=NGIRCD_SUPPRESS_DOCUMENTATION

This is handled automatically on a global level - See target-finalize in
the toplevel Makefile.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2011-05-06  9:49 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-20  7:21 [Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd fabien.marteau at armadeus.com
2011-04-20  8:05 ` Daniel Nyström
2011-04-20  8:12 ` Daniel Nyström
2011-04-20  8:49   ` Fabien Marteau
  -- strict thread matches above, loose matches on Subject: below --
2011-04-20  8:55 fabien.marteau at armadeus.com
2011-04-20  9:02 ` Thomas Petazzoni
2011-04-20  9:18 fabien.marteau at armadeus.com
2011-04-20 10:15 ` Daniel Nyström
2011-04-26  7:14   ` Fabien Marteau
2011-04-26  8:01     ` Daniel Nyström
2011-05-06  9:23 fabien.marteau at armadeus.com
2011-05-06  9:49 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox