* [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils
@ 2011-10-10 13:31 Klaus Schwarzkopf
2011-10-10 14:10 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Klaus Schwarzkopf @ 2011-10-10 13:31 UTC (permalink / raw)
To: buildroot
Signed-off-by: Klaus Schwarzkopf <schwarzkopf@sensortherm.de>
---
package/Config.in | 1 +
package/icon-naming-utils/icon-naming-utils.mk | 11 +++++++++++
package/tango-icon-theme/Config.in | 6 ++++++
package/tango-icon-theme/tango-icon-theme.mk | 15 +++++++++++++++
4 files changed, 33 insertions(+), 0 deletions(-)
create mode 100644 package/icon-naming-utils/icon-naming-utils.mk
create mode 100644 package/tango-icon-theme/Config.in
create mode 100644 package/tango-icon-theme/tango-icon-theme.mk
diff --git a/package/Config.in b/package/Config.in
index 7112e05..4516fb9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -114,6 +114,7 @@ source "package/sdl_sound/Config.in"
source "package/sdl_net/Config.in"
source "package/sdl_ttf/Config.in"
source "package/sdl_gfx/Config.in"
+source "package/tango-icon-theme/Config.in"
comment "other GUIs"
source "package/qt/Config.in"
diff --git a/package/icon-naming-utils/icon-naming-utils.mk b/package/icon-naming-utils/icon-naming-utils.mk
new file mode 100644
index 0000000..556b826
--- /dev/null
+++ b/package/icon-naming-utils/icon-naming-utils.mk
@@ -0,0 +1,11 @@
+#############################################################
+#
+# icon-naming-utils
+#
+#############################################################
+ICON_NAMING_UTILS_VERSION = 0.8.90
+ICON_NAMING_UTILS_SOURCE = icon-naming-utils-$(ICON_NAMING_UTILS_VERSION).tar.gz
+ICON_NAMING_UTILS_SITE = http://tango.freedesktop.org/releases/
+HOST_ICON_NAMING_UTILS_CONF_OPT = --datarootdir=$(HOST_DIR)/usr/lib
+
+$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))
diff --git a/package/tango-icon-theme/Config.in b/package/tango-icon-theme/Config.in
new file mode 100644
index 0000000..cf20e9b
--- /dev/null
+++ b/package/tango-icon-theme/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_TANGO_ICON_THEME
+ bool "tango icon theme"
+ help
+ Icons from the tango desktop project.
+
+ http://tango.freedesktop.org/Tango_Desktop_Project
diff --git a/package/tango-icon-theme/tango-icon-theme.mk b/package/tango-icon-theme/tango-icon-theme.mk
new file mode 100644
index 0000000..ed5a8b2
--- /dev/null
+++ b/package/tango-icon-theme/tango-icon-theme.mk
@@ -0,0 +1,15 @@
+#############################################################
+#
+# tango-icon-theme
+#
+#############################################################
+TANGO_ICON_THEME_VERSION = 0.8.90
+TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
+TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
+
+TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig
+TANGO_ICON_THEME_CONF_OPT = --disable-icon-framing
+
+TANGO_ICON_THEME_DEPENDENCIES = host-icon-naming-utils host-pkg-config
+
+$(eval $(call AUTOTARGETS,package,tango-icon-theme))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils
2011-10-10 13:31 [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils Klaus Schwarzkopf
@ 2011-10-10 14:10 ` Thomas Petazzoni
2011-10-10 14:23 ` Klaus Schwarzkopf
2011-10-10 17:32 ` Klaus Schwarzkopf
2011-10-10 18:07 ` [Buildroot] [PATCH 1/2 v2] add package tango-icon-theme Klaus Schwarzkopf
2011-10-10 18:08 ` [Buildroot] [PATCH 2/2 v2] icon-naming-utils for tango-icon-theme Klaus Schwarzkopf
2 siblings, 2 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2011-10-10 14:10 UTC (permalink / raw)
To: buildroot
Hello Klaus,
Le Mon, 10 Oct 2011 15:31:36 +0200,
Klaus Schwarzkopf <schwarzkopf@sensortherm.de> a ?crit :
> Signed-off-by: Klaus Schwarzkopf <schwarzkopf@sensortherm.de>
> ---
> package/Config.in | 1 +
> package/icon-naming-utils/icon-naming-utils.mk | 11 +++++++++++
> package/tango-icon-theme/Config.in | 6 ++++++
> package/tango-icon-theme/tango-icon-theme.mk | 15 +++++++++++++++
We usually have one patch per new package.
> +$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))
This should be:
$(eval $(call AUTOTARGETS))
in the Git version of Buildroot. The documentation has not yet been
updated in that regard.
> +TANGO_ICON_THEME_VERSION = 0.8.90
> +TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
> +TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
> +
> +TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig
Here you're going to build a target package (tango-icon-theme) based on
library informations of the host. This looks wrong. pkg-config already
looks in $(STAGING_DIR)/usr/lib/pkgconfig.
Could you detail why this is needed ?
> +$(eval $(call AUTOTARGETS,package,tango-icon-theme))
$(eval $(call AUTOTARGETS))
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils
2011-10-10 14:10 ` Thomas Petazzoni
@ 2011-10-10 14:23 ` Klaus Schwarzkopf
2011-10-10 17:32 ` Klaus Schwarzkopf
1 sibling, 0 replies; 8+ messages in thread
From: Klaus Schwarzkopf @ 2011-10-10 14:23 UTC (permalink / raw)
To: buildroot
Am 10.10.2011 16:10, schrieb Thomas Petazzoni:
> Hello Klaus,
>
> Le Mon, 10 Oct 2011 15:31:36 +0200,
> Klaus Schwarzkopf<schwarzkopf@sensortherm.de> a ?crit :
>
>> Signed-off-by: Klaus Schwarzkopf<schwarzkopf@sensortherm.de>
>> ---
>> package/Config.in | 1 +
>> package/icon-naming-utils/icon-naming-utils.mk | 11 +++++++++++
>> package/tango-icon-theme/Config.in | 6 ++++++
>> package/tango-icon-theme/tango-icon-theme.mk | 15 +++++++++++++++
>
> We usually have one patch per new package.
>
The icon-naming-utils is a helper package, only for the
tango-icon-theme. The program generates the right names and make links
in the target filesystem.
>> +$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))
>
> This should be:
>
> $(eval $(call AUTOTARGETS))
>
> in the Git version of Buildroot. The documentation has not yet been
> updated in that regard.
>
OK
>> +TANGO_ICON_THEME_VERSION = 0.8.90
>> +TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
>> +TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
>> +
>> +TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig
>
> Here you're going to build a target package (tango-icon-theme) based on
> library informations of the host. This looks wrong. pkg-config already
> looks in $(STAGING_DIR)/usr/lib/pkgconfig.
>
> Could you detail why this is needed ?
The icon-naming-utils only need for the host, so tango-icon-theme can
not find the utils. Have you an better idea?
>
>> +$(eval $(call AUTOTARGETS,package,tango-icon-theme))
>
> $(eval $(call AUTOTARGETS))
>
OK
> Regards,
>
> Thomas
Regards,
Klaus
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils
2011-10-10 14:10 ` Thomas Petazzoni
2011-10-10 14:23 ` Klaus Schwarzkopf
@ 2011-10-10 17:32 ` Klaus Schwarzkopf
2011-10-10 17:38 ` Thomas Petazzoni
1 sibling, 1 reply; 8+ messages in thread
From: Klaus Schwarzkopf @ 2011-10-10 17:32 UTC (permalink / raw)
To: buildroot
Hello Thomas,
if made the changes, and test it with the latest git tree. But i get an
error:
>>> tango-icon-theme 0.8.90 Extracting
gzip -d -c
/home/klaus/ti-dvsdk_dm365/buildroot/dl/tango-icon-theme-0.8.90.tar.gz |
tar --strip-components=1 -C
/home/klaus/ti-dvsdk_dm365/buildroot/output/build/tango-icon-theme-0.8.90
-xf -
>>> tango-icon-theme 0.8.90 Patching package//tango-icon-theme
>>> tango-icon-theme 0.8.90 Updating config.sub and config.guess
for file in config.guess config.sub; do for i in $(find
/home/klaus/ti-dvsdk_dm365/buildroot/output/build/tango-icon-theme-0.8.90 -name
$file); do cp support/gnuconfig/$file $i; done; done
>>> tango-icon-theme 0.8.90 Patching libtool
make: *** No rule to make target `host-icon-naming-utils', needed by
`tango-icon-theme-depends'. Stop.
Can you help?
Regards,
Klaus
Am 10.10.2011 16:10, schrieb Thomas Petazzoni:
> Hello Klaus,
>
> Le Mon, 10 Oct 2011 15:31:36 +0200,
> Klaus Schwarzkopf<schwarzkopf@sensortherm.de> a ?crit :
>
>> Signed-off-by: Klaus Schwarzkopf<schwarzkopf@sensortherm.de>
>> ---
>> package/Config.in | 1 +
>> package/icon-naming-utils/icon-naming-utils.mk | 11 +++++++++++
>> package/tango-icon-theme/Config.in | 6 ++++++
>> package/tango-icon-theme/tango-icon-theme.mk | 15 +++++++++++++++
>
> We usually have one patch per new package.
>
>> +$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))
>
> This should be:
>
> $(eval $(call AUTOTARGETS))
>
> in the Git version of Buildroot. The documentation has not yet been
> updated in that regard.
>
>> +TANGO_ICON_THEME_VERSION = 0.8.90
>> +TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
>> +TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
>> +
>> +TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig
>
> Here you're going to build a target package (tango-icon-theme) based on
> library informations of the host. This looks wrong. pkg-config already
> looks in $(STAGING_DIR)/usr/lib/pkgconfig.
>
> Could you detail why this is needed ?
>
>> +$(eval $(call AUTOTARGETS,package,tango-icon-theme))
>
> $(eval $(call AUTOTARGETS))
>
> Regards,
>
> Thomas
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils
2011-10-10 17:32 ` Klaus Schwarzkopf
@ 2011-10-10 17:38 ` Thomas Petazzoni
2011-10-10 18:09 ` Klaus Schwarzkopf
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2011-10-10 17:38 UTC (permalink / raw)
To: buildroot
Le Mon, 10 Oct 2011 19:32:13 +0200,
Klaus Schwarzkopf <schwarzkopf@sensortherm.de> a ?crit :
> make: *** No rule to make target `host-icon-naming-utils', needed by
> `tango-icon-theme-depends'. Stop.
>
> Can you help?
Yes, see below.
> > We usually have one patch per new package.
> >
> >> +$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))
> >
> > This should be:
> >
> > $(eval $(call AUTOTARGETS))
I should have said:
$(eval $(call AUTOTARGETS,host))
i.e, only the second and third argument have been removed. The optional
fourth argument, which says whether we instantiate a host or target
package, remains. Its default value is "target", so with just $(eval
$(call AUTOTARGETS)) you create a target package and not the host
package.
Sorry for the mistake.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils
2011-10-10 17:38 ` Thomas Petazzoni
@ 2011-10-10 18:09 ` Klaus Schwarzkopf
0 siblings, 0 replies; 8+ messages in thread
From: Klaus Schwarzkopf @ 2011-10-10 18:09 UTC (permalink / raw)
To: buildroot
Hi Thomas,
thanks very much.
Regards,
Klaus
Am 10.10.2011 19:38, schrieb Thomas Petazzoni:
> Le Mon, 10 Oct 2011 19:32:13 +0200,
> Klaus Schwarzkopf<schwarzkopf@sensortherm.de> a ?crit :
>
>> make: *** No rule to make target `host-icon-naming-utils', needed by
>> `tango-icon-theme-depends'. Stop.
>>
>> Can you help?
>
> Yes, see below.
>
>>> We usually have one patch per new package.
>>>
>>>> +$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))
>>>
>>> This should be:
>>>
>>> $(eval $(call AUTOTARGETS))
>
> I should have said:
>
> $(eval $(call AUTOTARGETS,host))
>
> i.e, only the second and third argument have been removed. The optional
> fourth argument, which says whether we instantiate a host or target
> package, remains. Its default value is "target", so with just $(eval
> $(call AUTOTARGETS)) you create a target package and not the host
> package.
>
> Sorry for the mistake.
>
> Thomas
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2 v2] add package tango-icon-theme
2011-10-10 13:31 [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils Klaus Schwarzkopf
2011-10-10 14:10 ` Thomas Petazzoni
@ 2011-10-10 18:07 ` Klaus Schwarzkopf
2011-10-10 18:08 ` [Buildroot] [PATCH 2/2 v2] icon-naming-utils for tango-icon-theme Klaus Schwarzkopf
2 siblings, 0 replies; 8+ messages in thread
From: Klaus Schwarzkopf @ 2011-10-10 18:07 UTC (permalink / raw)
To: buildroot
This package need icon-naming-utils.
Signed-off-by: Klaus Schwarzkopf <schwarzkopf@sensortherm.de>
---
package/Config.in | 1 +
package/tango-icon-theme/Config.in | 6 ++++++
package/tango-icon-theme/tango-icon-theme.mk | 15 +++++++++++++++
3 files changed, 22 insertions(+), 0 deletions(-)
create mode 100644 package/tango-icon-theme/Config.in
create mode 100644 package/tango-icon-theme/tango-icon-theme.mk
diff --git a/package/Config.in b/package/Config.in
index 7dc8887..1cc953c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -115,6 +115,7 @@ source "package/sdl_sound/Config.in"
source "package/sdl_net/Config.in"
source "package/sdl_ttf/Config.in"
source "package/sdl_gfx/Config.in"
+source "package/tango-icon-theme/Config.in"
comment "other GUIs"
source "package/qt/Config.in"
diff --git a/package/tango-icon-theme/Config.in b/package/tango-icon-theme/Config.in
new file mode 100644
index 0000000..cf20e9b
--- /dev/null
+++ b/package/tango-icon-theme/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_TANGO_ICON_THEME
+ bool "tango icon theme"
+ help
+ Icons from the tango desktop project.
+
+ http://tango.freedesktop.org/Tango_Desktop_Project
diff --git a/package/tango-icon-theme/tango-icon-theme.mk b/package/tango-icon-theme/tango-icon-theme.mk
new file mode 100644
index 0000000..2c1a5a5
--- /dev/null
+++ b/package/tango-icon-theme/tango-icon-theme.mk
@@ -0,0 +1,15 @@
+#############################################################
+#
+# tango-icon-theme
+#
+#############################################################
+TANGO_ICON_THEME_VERSION = 0.8.90
+TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
+TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
+
+TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig
+TANGO_ICON_THEME_CONF_OPT = --disable-icon-framing
+
+TANGO_ICON_THEME_DEPENDENCIES = host-icon-naming-utils host-pkg-config
+
+$(eval $(call AUTOTARGETS))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/2 v2] icon-naming-utils for tango-icon-theme
2011-10-10 13:31 [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils Klaus Schwarzkopf
2011-10-10 14:10 ` Thomas Petazzoni
2011-10-10 18:07 ` [Buildroot] [PATCH 1/2 v2] add package tango-icon-theme Klaus Schwarzkopf
@ 2011-10-10 18:08 ` Klaus Schwarzkopf
2 siblings, 0 replies; 8+ messages in thread
From: Klaus Schwarzkopf @ 2011-10-10 18:08 UTC (permalink / raw)
To: buildroot
---
package/icon-naming-utils/icon-naming-utils.mk | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
create mode 100644 package/icon-naming-utils/icon-naming-utils.mk
diff --git a/package/icon-naming-utils/icon-naming-utils.mk b/package/icon-naming-utils/icon-naming-utils.mk
new file mode 100644
index 0000000..1ac359a
--- /dev/null
+++ b/package/icon-naming-utils/icon-naming-utils.mk
@@ -0,0 +1,11 @@
+#############################################################
+#
+# icon-naming-utils
+#
+#############################################################
+ICON_NAMING_UTILS_VERSION = 0.8.90
+ICON_NAMING_UTILS_SOURCE = icon-naming-utils-$(ICON_NAMING_UTILS_VERSION).tar.gz
+ICON_NAMING_UTILS_SITE = http://tango.freedesktop.org/releases/
+HOST_ICON_NAMING_UTILS_CONF_OPT = --datarootdir=$(HOST_DIR)/usr/lib
+
+$(eval $(call AUTOTARGETS,host))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-10-10 18:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-10 13:31 [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils Klaus Schwarzkopf
2011-10-10 14:10 ` Thomas Petazzoni
2011-10-10 14:23 ` Klaus Schwarzkopf
2011-10-10 17:32 ` Klaus Schwarzkopf
2011-10-10 17:38 ` Thomas Petazzoni
2011-10-10 18:09 ` Klaus Schwarzkopf
2011-10-10 18:07 ` [Buildroot] [PATCH 1/2 v2] add package tango-icon-theme Klaus Schwarzkopf
2011-10-10 18:08 ` [Buildroot] [PATCH 2/2 v2] icon-naming-utils for tango-icon-theme Klaus Schwarzkopf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox