[Buildroot] [PATCH 0/4] Improved uClibc support with ct-ng generated toolchain

[Buildroot] [PATCH 0/4] Improved uClibc support with ct-ng generated toolchain

[Will Wagner]

Currently there is a hard coded uClibc config file when building
with crosstools-ng. This patch:
- Allows user to pick uClibc version when using ct-ng
- Allows user to select nptl when using 0.9.32
- Supplys better default uClibc config files (Using same config files as for in$
- Allows user to specify a custom uClibc config file 

Split patch into four and made changes suggested from Yann's feedback

[Buildroot] [PATCH 1/4] Allow user to pick uClibc version when using ct-ng

[Will Wagner]

Signed-off-by: Will Wagner <will_wagner@carallon.com>
---
 toolchain/toolchain-crosstool-ng/Config.in       |   14 ++++++++++++++
 toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    7 +++++++
 2 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/toolchain/toolchain-crosstool-ng/Config.in b/toolchain/toolchain-crosstool-ng/Config.in
index 2d1e801..e774caf 100644
--- a/toolchain/toolchain-crosstool-ng/Config.in
+++ b/toolchain/toolchain-crosstool-ng/Config.in
@@ -50,6 +50,20 @@ if BR2_TOOLCHAIN_CTNG_uClibc
 
 comment "Toolchain Options"
 
+choice
+	prompt "uClibc C library Version"
+	default BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
+	help
+	  Select the version of uClibc you wish to use.
+
+	config BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
+		bool "uClibc 0.9.30.x"
+
+	config BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_32
+		bool "uClibc 0.9.32.x"
+
+endchoice
+
 config BR2_TOOLCHAIN_CTNG_uClibc_LARGEFILE
 	bool "Enable large file (files > 2 GB) support"
 	select BR2_LARGEFILE
diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
index 3a205dd..192c6ff 100644
--- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
+++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
@@ -267,6 +267,13 @@ CTNG_FIX_DOT_CONFIG_PATHS_SED += s:^(CT_SYSROOT_DIR_PREFIX)=.*:\1="":;
 # uClibc specific options
 ifeq ($(BR2_TOOLCHAIN_CTNG_uClibc),y)
 
+# Set version
+ifeq ($(call qstrip,$(BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_32)),y)
+CTNG_FIX_DOT_CONFIG_SED += s:^(CT_LIBC_UCLIBC_V)(.+)=y$$:\# \1\2 is not set\n\1_0_9_32=y:;
+else ifeq ($(call qstrip,$(BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30)),y)
+CTNG_FIX_DOT_CONFIG_SED += s:^(CT_LIBC_UCLIBC_V)(.+)=y$$:\# \1\2 is not set\n\1_0_9_30_3=y:;
+endif
+
 # Handle the locales option
 ifneq ($(call qstrip,$(BR2_ENABLE_LOCALE)),)
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_LIBC_UCLIBC_LOCALES) is not set:\1=y\n\# CT_LIBC_UCLIBC_LOCALES_PREGEN_DATA is not set:;
-- 
1.7.2.5

[Buildroot] [PATCH 1/4] Allow user to pick uClibc version when using ct-ng

[Yann E. MORIN]

Will, All,

On Monday 05 December 2011 19:08:15 Will Wagner wrote:
[--SNIP--]
> diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> index 3a205dd..192c6ff 100644
> --- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> +++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> @@ -267,6 +267,13 @@ CTNG_FIX_DOT_CONFIG_PATHS_SED += s:^(CT_SYSROOT_DIR_PREFIX)=.*:\1="":;
>  # uClibc specific options
>  ifeq ($(BR2_TOOLCHAIN_CTNG_uClibc),y)
>  
> +# Set version
> +ifeq ($(call qstrip,$(BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_32)),y)
> +CTNG_FIX_DOT_CONFIG_SED += s:^(CT_LIBC_UCLIBC_V)(.+)=y$$:\# \1\2 is not set\n\1_0_9_32=y:;
-------------------------------------------------^^

You missed the trailing underscore. Without it, the folowing option
would also match: CT_LIBC_UCLIBC_VERBOSITY_0 (and _1 and _2, too).

Yes, I also forgot it in my answer to your initial mail, but I just
wrote that regexp directly in the mail, and said:
    "untested, may need some tweaking"

;-)

> +else ifeq ($(call qstrip,$(BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30)),y)
> +CTNG_FIX_DOT_CONFIG_SED += s:^(CT_LIBC_UCLIBC_V)(.+)=y$$:\# \1\2 is not set\n\1_0_9_30_3=y:;
-------------------------------------------------^^
Ditto.

You can resping an ammended patch with my:
    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>

Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/4] Supply better default uClibc config file when using ct-ng

[Will Wagner]

Signed-off-by: Will Wagner <will_wagner@carallon.com>
---
 toolchain/toolchain-crosstool-ng/Config.in       |    4 +
 toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    2 +-
 toolchain/toolchain-crosstool-ng/uClibc.config   |  246 ----------------------
 3 files changed, 5 insertions(+), 247 deletions(-)
 delete mode 100644 toolchain/toolchain-crosstool-ng/uClibc.config

diff --git a/toolchain/toolchain-crosstool-ng/Config.in b/toolchain/toolchain-crosstool-ng/Config.in
index e774caf..bc14d75 100644
--- a/toolchain/toolchain-crosstool-ng/Config.in
+++ b/toolchain/toolchain-crosstool-ng/Config.in
@@ -64,6 +64,10 @@ choice
 
 endchoice
 
+config BR2_TOOLCHAIN_CTNG_uClibc_CONFIG
+	default "toolchain/uClibc/uClibc-0.9.30.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
+	default "toolchain/uClibc/uClibc-0.9.32.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_32
+
 config BR2_TOOLCHAIN_CTNG_uClibc_LARGEFILE
 	bool "Enable large file (files > 2 GB) support"
 	select BR2_LARGEFILE
diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
index 192c6ff..484a838 100644
--- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
+++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
@@ -10,7 +10,7 @@
 
 CTNG_DIR := $(BUILD_DIR)/build-toolchain
 
-CTNG_UCLIBC_CONFIG_FILE := $(TOPDIR)/toolchain/toolchain-crosstool-ng/uClibc.config
+CTNG_UCLIBC_CONFIG_FILE := $(call qstrip,$(BR2_TOOLCHAIN_CTNG_uClibc_CONFIG))
 CTNG_CONFIG_FILE:=$(call qstrip,$(BR2_TOOLCHAIN_CTNG_CONFIG))
 
 # Hack! ct-ng is in fact a Makefile script. As such, it accepts all
diff --git a/toolchain/toolchain-crosstool-ng/uClibc.config b/toolchain/toolchain-crosstool-ng/uClibc.config
deleted file mode 100644
index 76a3427..0000000
--- a/toolchain/toolchain-crosstool-ng/uClibc.config
+++ /dev/null
@@ -1,246 +0,0 @@
-#
-# Automatically generated make config: don't edit
-# Version: 0.9.30
-# Fri Nov 21 09:26:34 2008
-#
-# TARGET_alpha is not set
-# TARGET_arm is not set
-# TARGET_avr32 is not set
-# TARGET_bfin is not set
-# TARGET_cris is not set
-# TARGET_e1 is not set
-# TARGET_frv is not set
-# TARGET_h8300 is not set
-# TARGET_hppa is not set
-# TARGET_i386 is not set
-# TARGET_i960 is not set
-# TARGET_ia64 is not set
-# TARGET_m68k is not set
-# TARGET_microblaze is not set
-# TARGET_mips is not set
-# TARGET_nios is not set
-# TARGET_nios2 is not set
-# TARGET_powerpc is not set
-# TARGET_sh is not set
-# TARGET_sh64 is not set
-# TARGET_sparc is not set
-# TARGET_v850 is not set
-# TARGET_vax is not set
-TARGET_x86_64=y
-# TARGET_xtensa is not set
-
-#
-# Target Architecture Features and Options
-#
-TARGET_ARCH="x86_64"
-FORCE_OPTIONS_FOR_ARCH=y
-# CONFIG_ARM_OABI is not set
-# CONFIG_ARM_EABI is not set
-# CONFIG_GENERIC_ARM is not set
-# CONFIG_ARM610 is not set
-# CONFIG_ARM710 is not set
-# CONFIG_ARM7TDMI is not set
-# CONFIG_ARM720T is not set
-# CONFIG_ARM920T is not set
-# CONFIG_ARM922T is not set
-# CONFIG_ARM926T is not set
-# CONFIG_ARM10T is not set
-# CONFIG_ARM1136JF_S is not set
-# CONFIG_ARM1176JZ_S is not set
-# CONFIG_ARM1176JZF_S is not set
-# CONFIG_ARM_CORTEX_M3 is not set
-# CONFIG_ARM_CORTEX_M1 is not set
-# CONFIG_ARM_SA110 is not set
-# CONFIG_ARM_SA1100 is not set
-# CONFIG_ARM_XSCALE is not set
-# CONFIG_ARM_IWMMXT is not set
-TARGET_SUBARCH=""
-
-#
-# Using ELF file format
-#
-ARCH_LITTLE_ENDIAN=y
-# ARCH_WANTS_BIG_ENDIAN is not set
-# ARCH_WANTS_LITTLE_ENDIAN is not set
-
-#
-# Using Little Endian
-#
-ARCH_HAS_MMU=y
-ARCH_USE_MMU=y
-UCLIBC_HAS_FLOATS=y
-UCLIBC_HAS_FPU=y
-DO_C99_MATH=y
-UCLIBC_HAS_FENV=y
-UCLIBC_HAS_LONG_DOUBLE_MATH=y
-KERNEL_HEADERS="/usr/include"
-HAVE_DOT_CONFIG=y
-
-#
-# General Library Settings
-#
-# HAVE_NO_PIC is not set
-DOPIC=y
-# ARCH_HAS_NO_SHARED is not set
-# ARCH_HAS_NO_LDSO is not set
-HAVE_SHARED=y
-# FORCE_SHAREABLE_TEXT_SEGMENTS is not set
-LDSO_LDD_SUPPORT=y
-LDSO_CACHE_SUPPORT=y
-# LDSO_PRELOAD_FILE_SUPPORT is not set
-LDSO_BASE_FILENAME="ld.so"
-UCLIBC_STATIC_LDCONFIG=y
-# LDSO_RUNPATH is not set
-UCLIBC_CTOR_DTOR=y
-# LDSO_GNU_HASH_SUPPORT is not set
-# HAS_NO_THREADS is not set
-UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
-LINUXTHREADS_OLD=y
-UCLIBC_HAS_SYSLOG=y
-UCLIBC_HAS_LFS=y
-# MALLOC is not set
-# MALLOC_SIMPLE is not set
-MALLOC_STANDARD=y
-# MALLOC_GLIBC_COMPAT is not set
-UCLIBC_DYNAMIC_ATEXIT=y
-# COMPAT_ATEXIT is not set
-# UCLIBC_SUSV3_LEGACY is not set
-# UCLIBC_SUSV3_LEGACY_MACROS is not set
-# UCLIBC_HAS_STUBS is not set
-UCLIBC_HAS_SHADOW=y
-UCLIBC_HAS_PROGRAM_INVOCATION_NAME=y
-UCLIBC_HAS___PROGNAME=y
-UCLIBC_HAS_PTY=y
-ASSUME_DEVPTS=y
-UNIX98PTY_ONLY=y
-# UCLIBC_HAS_GETPT is not set
-UCLIBC_HAS_TM_EXTENSIONS=y
-UCLIBC_HAS_TZ_CACHING=y
-UCLIBC_HAS_TZ_FILE=y
-UCLIBC_HAS_TZ_FILE_READ_MANY=y
-UCLIBC_TZ_FILE_PATH="/etc/TZ"
-
-#
-# Advanced Library Settings
-#
-UCLIBC_PWD_BUFFER_SIZE=256
-UCLIBC_GRP_BUFFER_SIZE=256
-
-#
-# Support various families of functions
-#
-UCLIBC_LINUX_MODULE_24=y
-UCLIBC_LINUX_SPECIFIC=y
-UCLIBC_HAS_GNU_ERROR=y
-# UCLIBC_BSD_SPECIFIC is not set
-UCLIBC_HAS_BSD_ERR=y
-# UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is not set
-# UCLIBC_HAS_OBSOLETE_SYSV_SIGNAL is not set
-# UCLIBC_NTP_LEGACY is not set
-# UCLIBC_SV4_DEPRECATED is not set
-UCLIBC_HAS_REALTIME=y
-UCLIBC_HAS_ADVANCED_REALTIME=y
-UCLIBC_HAS_EPOLL=y
-UCLIBC_HAS_XATTR=y
-UCLIBC_HAS_PROFILING=y
-UCLIBC_HAS_CRYPT_IMPL=y
-UCLIBC_HAS_CRYPT=y
-UCLIBC_HAS_NETWORK_SUPPORT=y
-UCLIBC_HAS_SOCKET=y
-UCLIBC_HAS_IPV4=y
-# UCLIBC_HAS_IPV6 is not set
-UCLIBC_HAS_RPC=y
-UCLIBC_HAS_FULL_RPC=y
-UCLIBC_HAS_REENTRANT_RPC=y
-UCLIBC_USE_NETLINK=y
-UCLIBC_SUPPORT_AI_ADDRCONFIG=y
-# UCLIBC_HAS_BSD_RES_CLOSE is not set
-
-#
-# String and Stdio Support
-#
-UCLIBC_HAS_STRING_GENERIC_OPT=y
-UCLIBC_HAS_STRING_ARCH_OPT=y
-UCLIBC_HAS_CTYPE_TABLES=y
-UCLIBC_HAS_CTYPE_SIGNED=y
-# UCLIBC_HAS_CTYPE_UNSAFE is not set
-# UCLIBC_HAS_CTYPE_CHECKED is not set
-UCLIBC_HAS_CTYPE_ENFORCED=y
-# UCLIBC_HAS_WCHAR is not set
-# UCLIBC_HAS_LOCALE is not set
-# UCLIBC_HAS_HEXADECIMAL_FLOATS is not set
-UCLIBC_HAS_GLIBC_CUSTOM_PRINTF=y
-# USE_OLD_VFPRINTF is not set
-UCLIBC_PRINTF_SCANF_POSITIONAL_ARGS=9
-# UCLIBC_HAS_SCANF_GLIBC_A_FLAG is not set
-# UCLIBC_HAS_STDIO_BUFSIZ_NONE is not set
-# UCLIBC_HAS_STDIO_BUFSIZ_256 is not set
-# UCLIBC_HAS_STDIO_BUFSIZ_512 is not set
-# UCLIBC_HAS_STDIO_BUFSIZ_1024 is not set
-# UCLIBC_HAS_STDIO_BUFSIZ_2048 is not set
-UCLIBC_HAS_STDIO_BUFSIZ_4096=y
-# UCLIBC_HAS_STDIO_BUFSIZ_8192 is not set
-UCLIBC_HAS_STDIO_BUILTIN_BUFFER_NONE=y
-# UCLIBC_HAS_STDIO_BUILTIN_BUFFER_4 is not set
-# UCLIBC_HAS_STDIO_BUILTIN_BUFFER_8 is not set
-# UCLIBC_HAS_STDIO_SHUTDOWN_ON_ABORT is not set
-UCLIBC_HAS_STDIO_GETC_MACRO=y
-UCLIBC_HAS_STDIO_PUTC_MACRO=y
-UCLIBC_HAS_STDIO_AUTO_RW_TRANSITION=y
-# UCLIBC_HAS_FOPEN_LARGEFILE_MODE is not set
-# UCLIBC_HAS_FOPEN_EXCLUSIVE_MODE is not set
-# UCLIBC_HAS_GLIBC_CUSTOM_STREAMS is not set
-UCLIBC_HAS_PRINTF_M_SPEC=y
-UCLIBC_HAS_ERRNO_MESSAGES=y
-# UCLIBC_HAS_SYS_ERRLIST is not set
-UCLIBC_HAS_SIGNUM_MESSAGES=y
-# UCLIBC_HAS_SYS_SIGLIST is not set
-UCLIBC_HAS_GNU_GETOPT=y
-UCLIBC_HAS_GNU_GETSUBOPT=y
-
-#
-# Big and Tall
-#
-UCLIBC_HAS_REGEX=y
-UCLIBC_HAS_REGEX_OLD=y
-UCLIBC_HAS_FNMATCH=y
-UCLIBC_HAS_FNMATCH_OLD=y
-# UCLIBC_HAS_WORDEXP is not set
-# UCLIBC_HAS_FTW is not set
-UCLIBC_HAS_GLOB=y
-UCLIBC_HAS_GNU_GLOB=y
-
-#
-# Library Installation Options
-#
-SHARED_LIB_LOADER_PREFIX="$(RUNTIME_PREFIX)lib"
-RUNTIME_PREFIX="/usr/$(TARGET_ARCH)-linux-uclibc/"
-DEVEL_PREFIX="/usr/$(TARGET_ARCH)-linux-uclibc/usr/"
-
-#
-# Security options
-#
-# UCLIBC_HAS_ARC4RANDOM is not set
-# HAVE_NO_SSP is not set
-# UCLIBC_HAS_SSP is not set
-UCLIBC_BUILD_RELRO=y
-# UCLIBC_BUILD_NOW is not set
-UCLIBC_BUILD_NOEXECSTACK=y
-
-#
-# uClibc development/debugging options
-#
-CROSS_COMPILER_PREFIX=""
-UCLIBC_EXTRA_CFLAGS=""
-# DODEBUG is not set
-# DODEBUG_PT is not set
-# DOSTRIP is not set
-# DOASSERTS is not set
-# SUPPORT_LD_DEBUG is not set
-# SUPPORT_LD_DEBUG_EARLY is not set
-# UCLIBC_MALLOC_DEBUGGING is not set
-WARNINGS="-Wall"
-# EXTRA_WARNINGS is not set
-# DOMULTI is not set
-# UCLIBC_MJN3_ONLY is not set
-- 
1.7.2.5

[Buildroot] [PATCH 2/4] Supply better default uClibc config file when using ct-ng

[Yann E. MORIN]

Will, Gustavo, All,

On Monday 05 December 2011 19:08:16 Will Wagner wrote:
> Signed-off-by: Will Wagner <will_wagner@carallon.com>
> ---
>  toolchain/toolchain-crosstool-ng/Config.in       |    4 +
>  toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    2 +-
>  toolchain/toolchain-crosstool-ng/uClibc.config   |  246 ----------------------
>  3 files changed, 5 insertions(+), 247 deletions(-)
>  delete mode 100644 toolchain/toolchain-crosstool-ng/uClibc.config
> 
> diff --git a/toolchain/toolchain-crosstool-ng/Config.in b/toolchain/toolchain-crosstool-ng/Config.in
> index e774caf..bc14d75 100644
> --- a/toolchain/toolchain-crosstool-ng/Config.in
> +++ b/toolchain/toolchain-crosstool-ng/Config.in
> @@ -64,6 +64,10 @@ choice
>  
>  endchoice
>  
> +config BR2_TOOLCHAIN_CTNG_uClibc_CONFIG
> +	default "toolchain/uClibc/uClibc-0.9.30.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30

Will and Gustavo, please coordinate with each other:

 - Will wants to reference that file to commonalise the uClibc configuration
   files between the internal backend and the crosstool-NG backend, see:
      http://lists.busybox.net/pipermail/buildroot/2011-December/048123.html

 - Gustavo wants to remove the file because the internal toolchain backend
   is dropping support for uClibc-0.9.30; see:
      http://lists.busybox.net/pipermail/buildroot/2011-December/048099.html

I am not sure what the proper resolution could be. Surely enough, I think
what Will wants to do is the correct way: use a single (set of) files for
both backends. Also, the internal backend should not be impacted by some
requirements of the ct-ng backend.

Anyway, in the meantime, because Gustavo's patch is not yet applied...
Will, you can add my:
    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/4] Supply better default uClibc config file when using ct-ng

[Gustavo Zacarias]

On 05.12.2011 18:33, Yann E. MORIN wrote:

> Will and Gustavo, please coordinate with each other:
>
>  - Will wants to reference that file to commonalise the uClibc 
> configuration
>    files between the internal backend and the crosstool-NG backend, 
> see:
>       
> http://lists.busybox.net/pipermail/buildroot/2011-December/048123.html
>
>  - Gustavo wants to remove the file because the internal toolchain 
> backend
>    is dropping support for uClibc-0.9.30; see:
>       
> http://lists.busybox.net/pipermail/buildroot/2011-December/048099.html
>
> I am not sure what the proper resolution could be. Surely enough, I 
> think
> what Will wants to do is the correct way: use a single (set of) files 
> for
> both backends. Also, the internal backend should not be impacted by 
> some
> requirements of the ct-ng backend.
>
> Anyway, in the meantime, because Gustavo's patch is not yet 
> applied...
> Will, you can add my:
>     Reviewed-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
>
> Regards,
> Yann E. MORIN.

It's quite simple actually, if we support any form of uClibc 0.9.30.x 
there are packages which won't build unless functionality backporting is 
done.
For example udev needs needs 99c1547124d7f410a3e3db66aa5816e53a96c156 
for 0.9.31 (and would so for 0.9.30.x)
Any takers for undeprecating and testing a ton of packages against 
0.9.30.x?
Maybe the backporting is there for ct-ng toolchains?
Regards.

[Buildroot] [PATCH 2/4] Supply better default uClibc config file when using ct-ng

[Will Wagner]

On 06/12/2011 00:44, Gustavo Zacarias wrote:
> On 05.12.2011 18:33, Yann E. MORIN wrote:
>
>> Will and Gustavo, please coordinate with each other:
>>
>> - Will wants to reference that file to commonalise the uClibc
>> configuration
>> files between the internal backend and the crosstool-NG backend, see:
>> http://lists.busybox.net/pipermail/buildroot/2011-December/048123.html
>>
>> - Gustavo wants to remove the file because the internal toolchain backend
>> is dropping support for uClibc-0.9.30; see:
>> http://lists.busybox.net/pipermail/buildroot/2011-December/048099.html
>>
>> I am not sure what the proper resolution could be. Surely enough, I think
>> what Will wants to do is the correct way: use a single (set of) files for
>> both backends. Also, the internal backend should not be impacted by some
>> requirements of the ct-ng backend.
>>
>> Anyway, in the meantime, because Gustavo's patch is not yet applied...
>> Will, you can add my:
>> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
>>
>> Regards,
>> Yann E. MORIN.
>
> It's quite simple actually, if we support any form of uClibc 0.9.30.x
> there are packages which won't build unless functionality backporting is
> done.
> For example udev needs needs 99c1547124d7f410a3e3db66aa5816e53a96c156
> for 0.9.31 (and would so for 0.9.30.x)
> Any takers for undeprecating and testing a ton of packages against
> 0.9.30.x?
> Maybe the backporting is there for ct-ng toolchains?
> Regards.
>

I had not noticed that 0.9.30 was marked as deprecated, added that to ct-ng.

Not sure we need to rush to remove 0.9.30 as it is already marked 
deprecated, but when we do remove it I guess we should remove from ct-ng 
toolchains as well.

Will


-- 
------------------------------------------------------------------------
Will Wagner                                     will_wagner at carallon.com
Development Manager                      Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------

[Buildroot] [PATCH 2/4] Supply better default uClibc config file when using ct-ng

[Gustavo Zacarias]

On 06.12.2011 09:19, Will Wagner wrote:

>> It's quite simple actually, if we support any form of uClibc 
>> 0.9.30.x
>> there are packages which won't build unless functionality 
>> backporting is
>> done.
>> For example udev needs needs 
>> 99c1547124d7f410a3e3db66aa5816e53a96c156
>> for 0.9.31 (and would so for 0.9.30.x)
>> Any takers for undeprecating and testing a ton of packages against
>> 0.9.30.x?
>> Maybe the backporting is there for ct-ng toolchains?
>> Regards.
>>
>
> I had not noticed that 0.9.30 was marked as deprecated, added that to 
> ct-ng.
>
> Not sure we need to rush to remove 0.9.30 as it is already marked
> deprecated, but when we do remove it I guess we should remove from
> ct-ng toolchains as well.
>
> Will

And digging a little further it seems the udev bump broke it with 
uClibc 0.9.31.x too.
I guess it's time to do some more backporting for that.
Any particular need to keep 0.9.30.x around if it's already deprecated?
I see a point in people wanting 0.9.31.x because of the threading 
differences.
But i think 0.9.30.x is just going to add troubles than solving 
anything.
Regards.

[Buildroot] [PATCH 3/4] Allow user to specify a custom uClibc config file when using ct-ng

[Will Wagner]

Signed-off-by: Will Wagner <will_wagner@carallon.com>
---
 toolchain/toolchain-crosstool-ng/Config.in |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/toolchain/toolchain-crosstool-ng/Config.in b/toolchain/toolchain-crosstool-ng/Config.in
index bc14d75..1669b12 100644
--- a/toolchain/toolchain-crosstool-ng/Config.in
+++ b/toolchain/toolchain-crosstool-ng/Config.in
@@ -65,8 +65,14 @@ choice
 endchoice
 
 config BR2_TOOLCHAIN_CTNG_uClibc_CONFIG
+	string "uClibc configuration file to use?"
 	default "toolchain/uClibc/uClibc-0.9.30.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
 	default "toolchain/uClibc/uClibc-0.9.32.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_32
+	help
+	  Some people may wish to use their own modified uClibc configuration
+	  file and will specify their config file location with this option.
+	  See also docs/README in this package.
+	  If unsure, use the default.
 
 config BR2_TOOLCHAIN_CTNG_uClibc_LARGEFILE
 	bool "Enable large file (files > 2 GB) support"
-- 
1.7.2.5

[Buildroot] [PATCH 3/4] Allow user to specify a custom uClibc config file when using ct-ng

[Yann E. MORIN]

Will, All,

On Monday 05 December 2011 19:08:17 Will Wagner wrote:
> Signed-off-by: Will Wagner <will_wagner@carallon.com>
> ---
>  toolchain/toolchain-crosstool-ng/Config.in |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/toolchain/toolchain-crosstool-ng/Config.in b/toolchain/toolchain-crosstool-ng/Config.in
> index bc14d75..1669b12 100644
> --- a/toolchain/toolchain-crosstool-ng/Config.in
> +++ b/toolchain/toolchain-crosstool-ng/Config.in
> @@ -65,8 +65,14 @@ choice
>  endchoice
>  
>  config BR2_TOOLCHAIN_CTNG_uClibc_CONFIG
> +	string "uClibc configuration file to use?"
>  	default "toolchain/uClibc/uClibc-0.9.30.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
>  	default "toolchain/uClibc/uClibc-0.9.32.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_32
> +	help
> +	  Some people may wish to use their own modified uClibc configuration
> +	  file and will specify their config file location with this option.
> +	  See also docs/README in this package.

That last sentence should not be there. It is misleading in this context.

> +	  If unsure, use the default.
>  
>  config BR2_TOOLCHAIN_CTNG_uClibc_LARGEFILE
>  	bool "Enable large file (files > 2 GB) support"

After removing the incriminated line above, you can add my:
    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 4/4] Allow user to select nptl when using 0.9.32 with ct-ng

[Will Wagner]

Signed-off-by: Will Wagner <will_wagner@carallon.com>
---
 toolchain/toolchain-crosstool-ng/Config.in |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/toolchain/toolchain-crosstool-ng/Config.in b/toolchain/toolchain-crosstool-ng/Config.in
index 1669b12..5988952 100644
--- a/toolchain/toolchain-crosstool-ng/Config.in
+++ b/toolchain/toolchain-crosstool-ng/Config.in
@@ -58,12 +58,17 @@ choice
 
 	config BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
 		bool "uClibc 0.9.30.x"
+		select BR2_TOOLCHAIN_CTNG_uClibc_NO_NPTL
 
 	config BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_32
 		bool "uClibc 0.9.32.x"
 
 endchoice
 
+# hidden option to disable nptl with uClibc
+config BR2_TOOLCHAIN_CTNG_uClibc_NO_NPTL
+	bool
+
 config BR2_TOOLCHAIN_CTNG_uClibc_CONFIG
 	string "uClibc configuration file to use?"
 	default "toolchain/uClibc/uClibc-0.9.30.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
@@ -154,7 +159,8 @@ choice
 		bool "Native POSIX Threading (NPTL)"
 		select BR2_TOOLCHAIN_HAS_THREADS
 		depends on BR2_TOOLCHAIN_CTNG_eglibc || \
-			   BR2_TOOLCHAIN_CTNG_glibc
+		           BR2_TOOLCHAIN_CTNG_glibc || \
+		           !BR2_TOOLCHAIN_CTNG_uClibc_NO_NPTL
 endchoice
 
 endif # BR2_TOOLCHAIN_CTNG
-- 
1.7.2.5

[Buildroot] [PATCH 4/4] Allow user to select nptl when using 0.9.32 with ct-ng

[Yann E. MORIN]

Will, All,

On Monday 05 December 2011 19:08:18 Will Wagner wrote:
> Signed-off-by: Will Wagner <will_wagner@carallon.com>
> ---
>  toolchain/toolchain-crosstool-ng/Config.in |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/toolchain/toolchain-crosstool-ng/Config.in b/toolchain/toolchain-crosstool-ng/Config.in
> index 1669b12..5988952 100644
> --- a/toolchain/toolchain-crosstool-ng/Config.in
> +++ b/toolchain/toolchain-crosstool-ng/Config.in
> @@ -58,12 +58,17 @@ choice
>  
>  	config BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
>  		bool "uClibc 0.9.30.x"
> +		select BR2_TOOLCHAIN_CTNG_uClibc_NO_NPTL
> 
>  	config BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_32
>  		bool "uClibc 0.9.32.x"
>  
>  endchoice
>  
> +# hidden option to disable nptl with uClibc
> +config BR2_TOOLCHAIN_CTNG_uClibc_NO_NPTL
> +	bool

Aha! Clever! Well done! :-)

> +
>  config BR2_TOOLCHAIN_CTNG_uClibc_CONFIG
>  	string "uClibc configuration file to use?"
>  	default "toolchain/uClibc/uClibc-0.9.30.config" if BR2_TOOLCHAIN_CTNG_uClibc_VERSION_0_9_30
> @@ -154,7 +159,8 @@ choice
>  		bool "Native POSIX Threading (NPTL)"
>  		select BR2_TOOLCHAIN_HAS_THREADS
>  		depends on BR2_TOOLCHAIN_CTNG_eglibc || \
> -			   BR2_TOOLCHAIN_CTNG_glibc
> +		           BR2_TOOLCHAIN_CTNG_glibc || \
> +		           !BR2_TOOLCHAIN_CTNG_uClibc_NO_NPTL
>  endchoice
>  
>  endif # BR2_TOOLCHAIN_CTNG

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>

Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'