Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libatomic_ops: Remove duplicate targets
@ 2012-02-13  9:43 Markos Chandras
  2012-02-14 22:22 ` Arnout Vandecappelle
  0 siblings, 1 reply; 3+ messages in thread
From: Markos Chandras @ 2012-02-13  9:43 UTC (permalink / raw)
  To: buildroot

Hi,

Please review the attached patch. libatomic_ops refuses to install
because the build system overwrites newly installed targets. The patch
removes these targets from the Makefiles and runs autoreconf to
regenerate the build system. If you need me to send the patch as a
separate file please let me know. I haven't send this to upstream yet
but I plan to do so.

-- 
markos
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-libatomic_ops-Remove-duplicate-targets.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120213/7c2662cc/attachment.ksh>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] libatomic_ops: Remove duplicate targets
  2012-02-13  9:43 [Buildroot] [PATCH] libatomic_ops: Remove duplicate targets Markos Chandras
@ 2012-02-14 22:22 ` Arnout Vandecappelle
  2012-02-15 11:09   ` Markos Chandras
  0 siblings, 1 reply; 3+ messages in thread
From: Arnout Vandecappelle @ 2012-02-14 22:22 UTC (permalink / raw)
  To: buildroot

On Monday 13 February 2012 10:43:03 Markos Chandras wrote:
> Hi,
> 
> Please review the attached patch. libatomic_ops refuses to install
> because the build system overwrites newly installed targets.

 I don't see how the duplicates could be a problem...  install (or 
install-sh) will just overwrite it the second time.  It has to,
otherwise running 'make install' a second time would fail.  Basically,
it works for me.

> The patch
> removes these targets from the Makefiles and runs autoreconf to
> regenerate the build system. If you need me to send the patch as a
> separate file please let me know. I haven't send this to upstream yet
> but I plan to do so.

 Of course, this is still relevant to send upstream.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120214/82bfc27e/attachment.html>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] libatomic_ops: Remove duplicate targets
  2012-02-14 22:22 ` Arnout Vandecappelle
@ 2012-02-15 11:09   ` Markos Chandras
  0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2012-02-15 11:09 UTC (permalink / raw)
  To: buildroot

On 02/14/2012 10:22 PM, Arnout Vandecappelle wrote:

> I don't see how the duplicates could be a problem... install (or
> 
> install-sh) will just overwrite it the second time. It has to,
> 
> otherwise running 'make install' a second time would fail. Basically,
> 
> it works for me.
> 

Hi Arnout,

Well it does not work for me because 'install' refuses to overwrite
newly created files

/usr/bin/install: will not overwrite just-created
`.../sysroot/usr/include/atomic_ops/sysdeps/gcc/hppa.h' with `gcc/hppa.h'
/usr/bin/install: will not overwrite just-created
`.../sysroot/usr/include/atomic_ops/sysdeps/gcc/ia64.h' with `gcc/ia64.h'
etc etc

and it then exists with Error 2

> 
> 
> 
> Of course, this is still relevant to send upstream.
> 


Yeah I will do it but given the author's comment "The prior, ostensibly
more stable, but seriously aging version is libatomic_ops-1.2." I am not
sure whether he stills maintain this version or not.

-- 
markos

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-15 11:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-13  9:43 [Buildroot] [PATCH] libatomic_ops: Remove duplicate targets Markos Chandras
2012-02-14 22:22 ` Arnout Vandecappelle
2012-02-15 11:09   ` Markos Chandras

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox