Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] adding a new machine configuration
@ 2012-03-01 13:07 Roland
  2012-03-01 13:39 ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Roland @ 2012-03-01 13:07 UTC (permalink / raw)
  To: buildroot

Hi.

I have created a new machine configuration file.

Target is Voipac iMX25 module ( http://voipac.com/#X25-DMM-254 ).

I'm gonna also create one for iMX51.

The problem is, the generated filesystem image won't work if don't 
change the fs/ubinize.cfg file (problem with alignment). And currently 
it's not possible to edit ubinize.cfg file in the buildroot 
configuration file.

I'm interested in sharing the config and other files so, it can be 
merged to buildroot's git.
But it's probably not possible until ubinize.cfg is configurable.

Any comments by the people, who have commit access?

Thanks,
Roland

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] adding a new machine configuration
  2012-03-01 13:07 [Buildroot] adding a new machine configuration Roland
@ 2012-03-01 13:39 ` Thomas Petazzoni
  2012-03-02 16:46   ` Roland
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2012-03-01 13:39 UTC (permalink / raw)
  To: buildroot

Le Thu, 01 Mar 2012 15:07:48 +0200,
Roland <rolandu@gmail.com> a ?crit :

> I have created a new machine configuration file.
> 
> Target is Voipac iMX25 module ( http://voipac.com/#X25-DMM-254 ).
> 
> I'm gonna also create one for iMX51.
> 
> The problem is, the generated filesystem image won't work if don't 
> change the fs/ubinize.cfg file (problem with alignment). And
> currently it's not possible to edit ubinize.cfg file in the buildroot 
> configuration file.

I guess you're talking about the vol_alignment parameter, is this
correct?

> I'm interested in sharing the config and other files so, it can be 
> merged to buildroot's git.
> But it's probably not possible until ubinize.cfg is configurable.
> 
> Any comments by the people, who have commit access?

You can simply add a new configuration option in the menuconfig to
specify the alignment, with a default value equal to the one used in
the current ubinize.cfg. Then, you change the ubinize.cfg to something
like:

vol_alignment=__BR_VOL_ALIGNMENT__

And then when the filesystem image is built, you copy this ubinize.cfg
somewhere, making the replacement of __BR_VOL_ALIGNMENT__ with the
value from the configuration, and you run ubinize with it.

Is this what you're looking for?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] adding a new machine configuration
  2012-03-01 13:39 ` Thomas Petazzoni
@ 2012-03-02 16:46   ` Roland
  2012-03-02 22:41     ` Arnout Vandecappelle
  0 siblings, 1 reply; 4+ messages in thread
From: Roland @ 2012-03-02 16:46 UTC (permalink / raw)
  To: buildroot

On 03/01/2012 03:39 PM, Thomas Petazzoni wrote:
> Le Thu, 01 Mar 2012 15:07:48 +0200,
> Roland<rolandu@gmail.com>  a ?crit :
>
>> I have created a new machine configuration file.
>>
>> Target is Voipac iMX25 module ( http://voipac.com/#X25-DMM-254 ).
>>
>> I'm gonna also create one for iMX51.
>>
>> The problem is, the generated filesystem image won't work if don't
>> change the fs/ubinize.cfg file (problem with alignment). And
>> currently it's not possible to edit ubinize.cfg file in the buildroot
>> configuration file.
> I guess you're talking about the vol_alignment parameter, is this
> correct?
>
>> I'm interested in sharing the config and other files so, it can be
>> merged to buildroot's git.
>> But it's probably not possible until ubinize.cfg is configurable.
>>
>> Any comments by the people, who have commit access?
> You can simply add a new configuration option in the menuconfig to
> specify the alignment, with a default value equal to the one used in
> the current ubinize.cfg. Then, you change the ubinize.cfg to something
> like:
>
> vol_alignment=__BR_VOL_ALIGNMENT__
>
> And then when the filesystem image is built, you copy this ubinize.cfg
> somewhere, making the replacement of __BR_VOL_ALIGNMENT__ with the
> value from the configuration, and you run ubinize with it.
>
> Is this what you're looking for?
>
> Thomas

Thanks,
This was helpful

Managed to change the Config.in file, but I'm having some trouble with 
ubi.mk

Which is better version...   I'm specifically interested in the IF 
section where BR2_TARGET_ROOTFS_UBI_ALIGNMENT_DEFINED is used.

Or suggest the correct buildroot way of doing this.

Thanks.


Version 1

#############################################################
#
# Embed the ubifs image into an ubi one
#
#############################################################

UBI_UBINIZE_OPTS := -m $(BR2_TARGET_ROOTFS_UBIFS_MINIOSIZE)
UBI_UBINIZE_OPTS += -p $(BR2_TARGET_ROOTFS_UBI_PEBSIZE)
ifneq ($(BR2_TARGET_ROOTFS_UBI_SUBSIZE),0)
UBI_UBINIZE_OPTS += -s $(BR2_TARGET_ROOTFS_UBI_SUBSIZE)
endif

UBI_UBINIZE_ECHO_ALIGNMENT :=
ifeq ($(BR2_TARGET_ROOTFS_UBI_ALIGNMENT_DEFINED),y)
         UBI_UBINIZE_ECHO_ALIGNMENT := echo 
"vol_alignment=$(BR2_TARGET_ROOTFS_UBI_VOL_ALIGNMENT)" \
 >> $(BUILD_DIR)/_ubinize.cfg ;
endif

ROOTFS_UBI_DEPENDENCIES = rootfs-ubifs

define ROOTFS_UBI_CMD
     cp fs/ubifs/ubinize.cfg $(BUILD_DIR)/_ubinize.cfg ;\
         echo "vol_name=$(BR2_TARGET_ROOTFS_UBI_VOL_NAME)" \
 >> $(BUILD_DIR)/_ubinize.cfg ;\
         $(UBI_UBINIZE_ECHO_ALIGNMENT) \
     echo "image=$$@fs" \
 >> $(BUILD_DIR)/_ubinize.cfg ;\
     $(HOST_DIR)/usr/sbin/ubinize -o $$@ $(UBI_UBINIZE_OPTS) 
$(BUILD_DIR)/_ubinize.cfg ;\
         rm $(BUILD_DIR)/_ubinize.cfg
endef

$(eval $(call ROOTFS_TARGET,ubi))


#############################################################





Version 2


#############################################################
#
# Embed the ubifs image into an ubi one
#
#############################################################

UBI_UBINIZE_OPTS := -m $(BR2_TARGET_ROOTFS_UBIFS_MINIOSIZE)
UBI_UBINIZE_OPTS += -p $(BR2_TARGET_ROOTFS_UBI_PEBSIZE)
ifneq ($(BR2_TARGET_ROOTFS_UBI_SUBSIZE),0)
UBI_UBINIZE_OPTS += -s $(BR2_TARGET_ROOTFS_UBI_SUBSIZE)
endif

ROOTFS_UBI_DEPENDENCIES = rootfs-ubifs

define ROOTFS_UBI_CMD
     cp fs/ubifs/ubinize.cfg $(BUILD_DIR)/_ubinize.cfg ;\
         echo "vol_name=$(BR2_TARGET_ROOTFS_UBI_VOL_NAME)" \
 >> $(BUILD_DIR)/_ubinize.cfg ;\
         [ "_y" = "_$(BR2_TARGET_ROOTFS_UBI_ALIGNMENT_DEFINED)" ] && \
                 echo 
"vol_alignment=$(BR2_TARGET_ROOTFS_UBI_VOL_ALIGNMENT)" \
 >> $(BUILD_DIR)/_ubinize.cfg ;\
     echo "image=$$@fs" \
 >> $(BUILD_DIR)/_ubinize.cfg ;\
     $(HOST_DIR)/usr/sbin/ubinize -o $$@ $(UBI_UBINIZE_OPTS) 
$(BUILD_DIR)/_ubinize.cfg ;\
         rm $(BUILD_DIR)/_ubinize.cfg
endef

$(eval $(call ROOTFS_TARGET,ubi))

#############################################################

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] adding a new machine configuration
  2012-03-02 16:46   ` Roland
@ 2012-03-02 22:41     ` Arnout Vandecappelle
  0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2012-03-02 22:41 UTC (permalink / raw)
  To: buildroot

On Friday 02 March 2012 16:46:54 Roland wrote:
> Which is better version...   I'm specifically interested in the IF 
> section where BR2_TARGET_ROOTFS_UBI_ALIGNMENT_DEFINED is used.

 Option 3 :-)

 Remove the vol_alignment=1 from ubinize.cfg, and do the 
'echo vol_alignment=...' unconditionally.  Make sure that in Config.in,
the BR2_TARGET_ROOTFS_UBI_ALIGNMENT defaults to 1 and you get exactly
the same behaviour by default.

 By the way, when you send your patches, please use git send-email
(see the man page for how to set it up with GMail).  GMail destroys
the formatting of the patch, so it won't apply.  And we prefer not
to get them as attachments because that makes them difficult to review.


 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-03-02 22:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-01 13:07 [Buildroot] adding a new machine configuration Roland
2012-03-01 13:39 ` Thomas Petazzoni
2012-03-02 16:46   ` Roland
2012-03-02 22:41     ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox