* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
@ 2012-03-14 10:02 Markos Chandras
2012-03-14 10:37 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Markos Chandras @ 2012-03-14 10:02 UTC (permalink / raw)
To: buildroot
fbdump uses the ioperm() syscall which is only implemented in
x86/x86_64. The rest of the architectures map ioperm() to
sys_ni_syscall which is the default function for the unimplemented
syscalls. Moreover, ARM has its own ioperm() implementation
in uClibc.
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
package/fbdump/Config.in | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/package/fbdump/Config.in b/package/fbdump/Config.in
index fb4aee6..2f8040f 100644
--- a/package/fbdump/Config.in
+++ b/package/fbdump/Config.in
@@ -1,3 +1,4 @@
+if BR2_i386 || BR2_x86_64 || BR2_arm
config BR2_PACKAGE_FBDUMP
bool "fbdump (Framebuffer Capture Tool)"
help
@@ -5,4 +6,4 @@ config BR2_PACKAGE_FBDUMP
framebuffer device and write them out as a PPM file. Currently,
most packed-pixel framebuffer formats and the vga16 framebuffer
are supported.
-
+endif
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
2012-03-14 10:02 [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures Markos Chandras
@ 2012-03-14 10:37 ` Thomas Petazzoni
2012-03-14 10:43 ` Markos Chandras
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2012-03-14 10:37 UTC (permalink / raw)
To: buildroot
Hello,
Le Wed, 14 Mar 2012 10:02:14 +0000,
Markos Chandras <markos.chandras@imgtec.com> a ?crit :
> fbdump uses the ioperm() syscall which is only implemented in
> x86/x86_64. The rest of the architectures map ioperm() to
> sys_ni_syscall which is the default function for the unimplemented
> syscalls. Moreover, ARM has its own ioperm() implementation
> in uClibc.
Is ioperm() on ARM only available if uClibc is used, and not when glibc
is used?
> diff --git a/package/fbdump/Config.in b/package/fbdump/Config.in
> index fb4aee6..2f8040f 100644
> --- a/package/fbdump/Config.in
> +++ b/package/fbdump/Config.in
> @@ -1,3 +1,4 @@
> +if BR2_i386 || BR2_x86_64 || BR2_arm
> config BR2_PACKAGE_FBDUMP
> bool "fbdump (Framebuffer Capture Tool)"
> help
> @@ -5,4 +6,4 @@ config BR2_PACKAGE_FBDUMP
> framebuffer device and write them out as a PPM file. Currently,
> most packed-pixel framebuffer formats and the vga16 framebuffer
> are supported.
> -
> +endif
I would prefer:
config BR2_PACKAGE_FBDUMP
bool "fbdump (Framebuffer Capture Tool)"
depends on BR_i386 || BR2_x86_64 || BR2_arm
because that's what we do for all other packages.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
2012-03-14 10:37 ` Thomas Petazzoni
@ 2012-03-14 10:43 ` Markos Chandras
2012-03-14 11:02 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Markos Chandras @ 2012-03-14 10:43 UTC (permalink / raw)
To: buildroot
On 03/14/2012 10:37 AM, Thomas Petazzoni wrote:
> Hello,
>
> Le Wed, 14 Mar 2012 10:02:14 +0000,
> Markos Chandras <markos.chandras@imgtec.com> a ?crit :
>
>> fbdump uses the ioperm() syscall which is only implemented in
>> x86/x86_64. The rest of the architectures map ioperm() to
>> sys_ni_syscall which is the default function for the unimplemented
>> syscalls. Moreover, ARM has its own ioperm() implementation
>> in uClibc.
>
> Is ioperm() on ARM only available if uClibc is used, and not when glibc
> is used?
>
>> diff --git a/package/fbdump/Config.in b/package/fbdump/Config.in
>> index fb4aee6..2f8040f 100644
>> --- a/package/fbdump/Config.in
>> +++ b/package/fbdump/Config.in
>> @@ -1,3 +1,4 @@
>> +if BR2_i386 || BR2_x86_64 || BR2_arm
>> config BR2_PACKAGE_FBDUMP
>> bool "fbdump (Framebuffer Capture Tool)"
>> help
>> @@ -5,4 +6,4 @@ config BR2_PACKAGE_FBDUMP
>> framebuffer device and write them out as a PPM file. Currently,
>> most packed-pixel framebuffer formats and the vga16 framebuffer
>> are supported.
>> -
>> +endif
>
> I would prefer:
>
> config BR2_PACKAGE_FBDUMP
> bool "fbdump (Framebuffer Capture Tool)"
> depends on BR_i386 || BR2_x86_64 || BR2_arm
>
> because that's what we do for all other packages.
>
> Thomas
Hi Thomas,
Thanks for your suggestion. I fixed and resent my patch.
--
markos
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
2012-03-14 10:43 ` Markos Chandras
@ 2012-03-14 11:02 ` Thomas Petazzoni
2012-03-14 11:33 ` Markos Chandras
2012-03-14 11:48 ` Markos Chandras
0 siblings, 2 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2012-03-14 11:02 UTC (permalink / raw)
To: buildroot
Le Wed, 14 Mar 2012 10:43:17 +0000,
Markos Chandras <Markos.Chandras@imgtec.com> a ?crit :
> Thanks for your suggestion. I fixed and resent my patch.
And what about my question about ioperm() on ARM?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
2012-03-14 11:02 ` Thomas Petazzoni
@ 2012-03-14 11:33 ` Markos Chandras
2012-03-14 11:48 ` Markos Chandras
1 sibling, 0 replies; 9+ messages in thread
From: Markos Chandras @ 2012-03-14 11:33 UTC (permalink / raw)
To: buildroot
On 03/14/2012 11:02 AM, Thomas Petazzoni wrote:
> Le Wed, 14 Mar 2012 10:43:17 +0000,
> Markos Chandras <Markos.Chandras@imgtec.com> a ?crit :
>
>> Thanks for your suggestion. I fixed and resent my patch.
>
> And what about my question about ioperm() on ARM?
>
> Thomas
Sorry I overlooked your question. Yes it seems this is the case. I
didn't actually test that but I grep'd the glibc git tree and I see that
it is not defined for ARM.
--
markos
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
2012-03-14 11:02 ` Thomas Petazzoni
2012-03-14 11:33 ` Markos Chandras
@ 2012-03-14 11:48 ` Markos Chandras
2012-03-14 11:55 ` Thomas Petazzoni
1 sibling, 1 reply; 9+ messages in thread
From: Markos Chandras @ 2012-03-14 11:48 UTC (permalink / raw)
To: buildroot
On 03/14/2012 11:02 AM, Thomas Petazzoni wrote:
> Le Wed, 14 Mar 2012 10:43:17 +0000,
> Markos Chandras <Markos.Chandras@imgtec.com> a ?crit :
>
>> Thanks for your suggestion. I fixed and resent my patch.
>
> And what about my question about ioperm() on ARM?
>
> Thomas
Actually I don't think glibc supports ARM at all. From glibc's README file
"The GNU C Library supports these configurations for using Linux kernels:
i[34567]86-*-linux-gnu
x86_64-*-linux-gnu
powerpc-*-linux-gnu
powerpc64-*-linux-gnu
s390-*-linux-gnu
s390x-*-linux-gnu
ia64-*-linux-gnu
sparc*-*-linux-gnu
sparc64*-*-linux-gnu"
--
markos
^ permalink raw reply [flat|nested] 9+ messages in thread* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
2012-03-14 11:48 ` Markos Chandras
@ 2012-03-14 11:55 ` Thomas Petazzoni
2012-03-14 13:56 ` Markos Chandras
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2012-03-14 11:55 UTC (permalink / raw)
To: buildroot
Le Wed, 14 Mar 2012 11:48:45 +0000,
Markos Chandras <Markos.Chandras@imgtec.com> a ?crit :
> Actually I don't think glibc supports ARM at all. From glibc's README file
>
> "The GNU C Library supports these configurations for using Linux kernels:
>
> i[34567]86-*-linux-gnu
> x86_64-*-linux-gnu
> powerpc-*-linux-gnu
> powerpc64-*-linux-gnu
> s390-*-linux-gnu
> s390x-*-linux-gnu
> ia64-*-linux-gnu
> sparc*-*-linux-gnu
> sparc64*-*-linux-gnu"
It might be in glibc-ports, so that's why you don't see it in the main
glibc README. But definitely, glibc runs on ARM, PowerPC. Millions of
devices are using it as we are speaking :-)
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
2012-03-14 11:55 ` Thomas Petazzoni
@ 2012-03-14 13:56 ` Markos Chandras
0 siblings, 0 replies; 9+ messages in thread
From: Markos Chandras @ 2012-03-14 13:56 UTC (permalink / raw)
To: buildroot
On 03/14/2012 11:55 AM, Thomas Petazzoni wrote:
> Le Wed, 14 Mar 2012 11:48:45 +0000,
> Markos Chandras <Markos.Chandras@imgtec.com> a ?crit :
>
>> Actually I don't think glibc supports ARM at all. From glibc's README file
>>
>> "The GNU C Library supports these configurations for using Linux kernels:
>>
>> i[34567]86-*-linux-gnu
>> x86_64-*-linux-gnu
>> powerpc-*-linux-gnu
>> powerpc64-*-linux-gnu
>> s390-*-linux-gnu
>> s390x-*-linux-gnu
>> ia64-*-linux-gnu
>> sparc*-*-linux-gnu
>> sparc64*-*-linux-gnu"
>
> It might be in glibc-ports, so that's why you don't see it in the main
> glibc README. But definitely, glibc runs on ARM, PowerPC. Millions of
> devices are using it as we are speaking :-)
>
> Thomas
Yeah I was talking for the official glibc git tree. I have no idea if
this function is supported in glibc-ports or not.
--
markos
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures
@ 2012-03-14 10:40 Markos Chandras
0 siblings, 0 replies; 9+ messages in thread
From: Markos Chandras @ 2012-03-14 10:40 UTC (permalink / raw)
To: buildroot
fbdump uses the ioperm() syscall which is only implemented in
x86/x86_64. The rest of the architectures map ioperm() to
sys_ni_syscall which is the default function for the unimplemented
syscalls. Moreover, ARM has its own ioperm() implementation
in uClibc.
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
package/fbdump/Config.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/package/fbdump/Config.in b/package/fbdump/Config.in
index fb4aee6..1129134 100644
--- a/package/fbdump/Config.in
+++ b/package/fbdump/Config.in
@@ -1,8 +1,8 @@
config BR2_PACKAGE_FBDUMP
bool "fbdump (Framebuffer Capture Tool)"
+ depends on BR_i386 || BR2_x86_64 || BR2_arm
help
fbdump is a simple tool to capture snapshots from the Linux kernel
framebuffer device and write them out as a PPM file. Currently,
most packed-pixel framebuffer formats and the vga16 framebuffer
are supported.
-
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-03-14 13:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 10:02 [Buildroot] [PATCH] fbdump: Make fbdump available only to x86/x86_64/arm architectures Markos Chandras
2012-03-14 10:37 ` Thomas Petazzoni
2012-03-14 10:43 ` Markos Chandras
2012-03-14 11:02 ` Thomas Petazzoni
2012-03-14 11:33 ` Markos Chandras
2012-03-14 11:48 ` Markos Chandras
2012-03-14 11:55 ` Thomas Petazzoni
2012-03-14 13:56 ` Markos Chandras
-- strict thread matches above, loose matches on Subject: below --
2012-03-14 10:40 Markos Chandras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox