Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] Add the package read-edid...
@ 2012-05-06 12:43 Dimitry Golubovsky
  2012-05-06 13:00 ` Arnout Vandecappelle
  2012-05-06 14:36 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Dimitry Golubovsky @ 2012-05-06 12:43 UTC (permalink / raw)
  To: buildroot

Peter,

On Sun, May 6, 2012 at 4:00 AM, Peter Korsgaard <jacmet@uclibc.org> wrote:

> ?Dmitry> ?package/read-edid/read-edid.mk | ? 20 ++++++++++++++++++++
...
>
> I've fixed up these whitespace issues and committed, thanks.

Which whitespace do you mean? Extra whitespaces as I justified the
help text by both edges? Or was this some extra whitespace in header?

I have few more packages for submission, just want to make sure I
don't make such omission again.

Thanks.

-- 
Dimitry Golubovsky

Anywhere on the Web

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] Add the package read-edid...
  2012-05-06 12:43 [Buildroot] Add the package read-edid Dimitry Golubovsky
@ 2012-05-06 13:00 ` Arnout Vandecappelle
  2012-05-06 14:36 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2012-05-06 13:00 UTC (permalink / raw)
  To: buildroot

On 05/06/12 14:43, Dimitry Golubovsky wrote:
> Which whitespace do you mean? Extra whitespaces as I justified the
> help text by both edges? Or was this some extra whitespace in header?

  Help text should be wrapped at 75 characters (where the initial tab
counts as 8 characters).

  Regarding justifying the help text: I'm not sure if it looks good in
the gconfig and xconfig interfaces.

  Regards,
  Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] Add the package read-edid...
  2012-05-06 12:43 [Buildroot] Add the package read-edid Dimitry Golubovsky
  2012-05-06 13:00 ` Arnout Vandecappelle
@ 2012-05-06 14:36 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2012-05-06 14:36 UTC (permalink / raw)
  To: buildroot

>>>>> "Dimitry" == Dimitry Golubovsky <golubovsky@gmail.com> writes:

 Dimitry> Peter,
 Dimitry> On Sun, May 6, 2012 at 4:00 AM, Peter Korsgaard <jacmet@uclibc.org> wrote:

 >> ?Dmitry> ?package/read-edid/read-edid.mk | ? 20 ++++++++++++++++++++
 Dimitry> ...
 >> 
 >> I've fixed up these whitespace issues and committed, thanks.

 Dimitry> Which whitespace do you mean? Extra whitespaces as I justified the
 Dimitry> help text by both edges? Or was this some extra whitespace in header?

Yes, in the help text and empty lines at the bottom of Config.in /
read-edid.mk. Please don't justify the help text.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-06 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-06 12:43 [Buildroot] Add the package read-edid Dimitry Golubovsky
2012-05-06 13:00 ` Arnout Vandecappelle
2012-05-06 14:36 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox