Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/libbdplus: Add missing libgpg arch support
@ 2016-07-04 21:42 Maxime Hadjinlian
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Hadjinlian @ 2016-07-04 21:42 UTC (permalink / raw)
  To: buildroot

Thanks to Romain Naour for finding the culprit package.

Fix:
http://autobuild.buildroot.org/results/d06/d06e3eb9ef48540b71fbec267c534523632b224f/

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/libbdplus/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libbdplus/Config.in b/package/libbdplus/Config.in
index df5ea27..7cb5893 100644
--- a/package/libbdplus/Config.in
+++ b/package/libbdplus/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBBDPLUS
 	bool "libbdplus"
+	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_LIBGCRYPT
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libbdplus: Add missing libgpg arch support
@ 2016-07-04 21:57 Maxime Hadjinlian
  2016-07-04 22:00 ` Romain Naour
  2016-07-05  7:23 ` Thomas Petazzoni
  0 siblings, 2 replies; 4+ messages in thread
From: Maxime Hadjinlian @ 2016-07-04 21:57 UTC (permalink / raw)
  To: buildroot

Thanks to Romain Naour for finding the culprit package.

Fix:
http://autobuild.buildroot.org/results/d06/d06e3eb9ef48540b71fbec267c534523632b224f/

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/libbdplus/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/libbdplus/Config.in b/package/libbdplus/Config.in
index df5ea27..afde075 100644
--- a/package/libbdplus/Config.in
+++ b/package/libbdplus/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBBDPLUS
 	bool "libbdplus"
+	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_LIBGCRYPT
@@ -15,4 +16,5 @@ config BR2_PACKAGE_LIBBDPLUS
 	  http://www.videolan.org/developers/libbdplus.html
 
 comment "libbdplus needs a toolchain w/ threads, dynamic library"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
+		!BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libbdplus: Add missing libgpg arch support
  2016-07-04 21:57 [Buildroot] [PATCH] package/libbdplus: Add missing libgpg arch support Maxime Hadjinlian
@ 2016-07-04 22:00 ` Romain Naour
  2016-07-05  7:23 ` Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Romain Naour @ 2016-07-04 22:00 UTC (permalink / raw)
  To: buildroot

Hi Maxime,

Le 04/07/2016 ? 23:57, Maxime Hadjinlian a ?crit :
> Thanks to Romain Naour for finding the culprit package.
> 
> Fix:
> http://autobuild.buildroot.org/results/d06/d06e3eb9ef48540b71fbec267c534523632b224f/
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Acked-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain

> ---
>  package/libbdplus/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libbdplus/Config.in b/package/libbdplus/Config.in
> index df5ea27..afde075 100644
> --- a/package/libbdplus/Config.in
> +++ b/package/libbdplus/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_LIBBDPLUS
>  	bool "libbdplus"
> +	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on !BR2_STATIC_LIBS
>  	select BR2_PACKAGE_LIBGCRYPT
> @@ -15,4 +16,5 @@ config BR2_PACKAGE_LIBBDPLUS
>  	  http://www.videolan.org/developers/libbdplus.html
>  
>  comment "libbdplus needs a toolchain w/ threads, dynamic library"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
> +		!BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libbdplus: Add missing libgpg arch support
  2016-07-04 21:57 [Buildroot] [PATCH] package/libbdplus: Add missing libgpg arch support Maxime Hadjinlian
  2016-07-04 22:00 ` Romain Naour
@ 2016-07-05  7:23 ` Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-07-05  7:23 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  4 Jul 2016 23:57:46 +0200, Maxime Hadjinlian wrote:

>  comment "libbdplus needs a toolchain w/ threads, dynamic library"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
> +		!BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS

That's not the proper way of taking into account architecture
dependencies. What we want is that the comment is only displayed if the
architecture requirements are met, so:

comment "libbdplus needs a toolchain w/ threads, dynamic library"
	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

Applied with this fixed.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-05  7:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-04 21:57 [Buildroot] [PATCH] package/libbdplus: Add missing libgpg arch support Maxime Hadjinlian
2016-07-04 22:00 ` Romain Naour
2016-07-05  7:23 ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2016-07-04 21:42 Maxime Hadjinlian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox