Re: [Buildroot] [PATCH v2] package/icu: fix static linking with icu-uc for musl static toolchains

[Andreas Ziegler <br025@umbiko.net>]

Hi Shubham,

On 2026-03-26 07:01, Shubham Chakraborty wrote:
> Hi Andreas,
> 
> Romain doesn’t seem to be active, so I’d like your guidance on how to
> proceed.
> 
> For v3, would you prefer that I:
> 
>    1. regenerate a single combined patch (replacing 0003 and 0004) 
> using
>    git format-patch, or
>    2. keep 0003 and update it by editing the existing patch to include 
> my
>    changes?
> 
> Also, in this case, should I keep only my Signed-off-by, or retain 
> Romain’s
> attribution in some form?
> 

What I would do is this: Add a comment below the last Signed-off-by, add 
your Signed-off-by, and then modify the patch itself accordingly.

<example>

Add -lstdc++ in Libs.private of icu-uc.pc.

Fixes:
http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef521ca/

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
This patch currently addresses linking against stdc++ for shared-library 
builds. Add -lstdc++ to the static build flags also, to fix 'undefined 
reference' errors when linking programs like xmlcatalog (libxml2)
with musl static toolchains.

Upstream: Inactive-Upstream [Buildroot specific]
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
  source/Makefile.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff -git icu.orig/source/Makefile.in icu/source/Makefile.in

</example>

> Thanks for your guidance.
> 
> Best regards,
> Shubham

<cut>

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot