Re: [Buildroot] [PATCH v2] package/icu: fix static linking with icu-uc for musl static toolchains

[Andreas Ziegler <br025@umbiko.net>]

Hi Shubham,

[add Romain Naour -> author of 0003]

The commit message in patch #3 states it addresses the static linking, 
but changes the shared linking statement instead. Since it obviously 
works, probably the commit message is wrong? Or can this patch simply be 
replaced with yours?

(patch related remarks below)

On 2026-03-03 23:51, Shubham Chakraborty wrote:
> 
> During static linking with a C application and libicuuc.a,
> -lstdc++ is required. The previous patch (0003) only addressed the
> shared library case (Libs.private). This patch adds -lstdc++
> to the main Libs line for the static case to fix undefined
> reference errors when linking programs like xmlcatalog (libxml2)
> with musl static toolchains.
        ^^^^
This probably affects not only musl toolchains.

> 
> Upstream: Inactive-Upstream [Buildroot specific]
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> 
> ---
> Changes v1 -> v2:
>   - Fixed the malformed patch
>   - Removed unnecessary whitespace
> 
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> ---
>  ...atic-linking-with-icu-uc-static-musl.patch | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 
> package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch
> 
> diff --git 
> a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch 
> b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch
> new file mode 100644
> index 0000000000..e17f6ac775
> --- /dev/null
> +++ b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch
> @@ -0,0 +1,26 @@
> +From 2107f9dfb39eeb6559fb4271c7af8b39aef521ca Mon Sep 17 00:00:00 2001
> +From: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> +Date: Tue, 3 Mar 2026 10:00:00 +0000
> +Subject: [PATCH] fix static linking with icu-uc (static case)
> +
> +During static linking with a C application and libicuuc.a,
> +-lstdc++ is required. The previous patch (0003) only addressed the
> +shared library case (Libs.private). This patch adds -lstdc++ to the
> +main Libs line for the static case to fix undefined reference
> +errors when linking programs like xmlcatalog (libxml2) with
> +musl toolchains.

The existing 0003-fix-static-linking-with-icu-uc.patch could be replaced 
with a patch that addresses both issues.

> +
> +Upstream: Inactive-Upstream [Buildroot specific]
> +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> +---
> + source/Makefile.in | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff -git icu.orig/source/Makefile.in icu/source/Makefile.in
> +--- icu.orig/source/Makefile.in
> ++++ icu/source/Makefile.in
> +@@ -281,3 +281,3 @@
> + ifeq ($(ENABLE_SHARED),)
> +-	@echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" 
> '$${baselibs}' >> $@
> ++	@echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" 
> '$${baselibs}' -lstdc++ >> $@
> + else
> --
> 2.53.0

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot