From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qemu: enable usb passthrough on host variant
Date: Fri, 25 Oct 2019 22:40:14 +0200 [thread overview]
Message-ID: <4e00d6ec-752a-e35d-b586-47703369c07e@mind.be> (raw)
In-Reply-To: <87h83x4ys7.fsf@dell.be.48ers.dk>
On 24/10/2019 23:30, Peter Korsgaard wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>
> >> +ifeq ($(BR2_PACKAGE_LIBUSB),y)
>
> > So, if the target libusb package is enabled...
>
> >> +HOST_QEMU_OPTS += --enable-libusb
> >> +HOST_QEMU_DEPENDENCIES += host-libusb
>
> > ... you assume the user wants libusb support in host-qemu.
>
> > Sorry, but this is not good. Add an option in
> > package/qemu/Config.in.host to enable USB passthrough, and use that in
> > qemu.mk.
host-libusb takes 1 second to build (*). Is it really worth to make an option
for it?
Regards,
Arnout
(*) Yes, I'm exaggerating :-)
>
> And pass --disable-libusb (if such option exists) in the else clause.
>
prev parent reply other threads:[~2019-10-25 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 20:28 [Buildroot] [PATCH] package/qemu: enable usb passthrough on host variant Angelo Compagnucci
2019-10-24 20:36 ` Thomas Petazzoni
2019-10-24 21:30 ` Peter Korsgaard
2019-10-25 20:40 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e00d6ec-752a-e35d-b586-47703369c07e@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox