* [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata
@ 2012-08-15 19:00 Stefan Froberg
2012-08-15 19:00 ` Stefan Froberg
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Froberg @ 2012-08-15 19:00 UTC (permalink / raw)
To: buildroot
Hello all
Firefox needs host-python to be built with --enable-unicodedata.
This patch enables/disables that switch depending of your
target python configuration (BR2_PACKAGE_PYTHON_UNICODEDATA).
As far as I can tell, this was the last dependency that needed some handling
before building firefox.
If this and those two previously sended patches
http://lists.busybox.net/pipermail/buildroot/2012-August/057378.html
and
http://lists.busybox.net/pipermail/buildroot/2012-August/057380.html
are okay with you Thomas, then Im ready to send firefox patch next.
Best regards
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata
2012-08-15 19:00 [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata Stefan Froberg
@ 2012-08-15 19:00 ` Stefan Froberg
2012-08-21 11:23 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Froberg @ 2012-08-15 19:00 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan Froberg <stefan.froberg@petroprogram.com>
---
package/python/python.mk | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/package/python/python.mk b/package/python/python.mk
index fae4e5c..805e40c 100644
--- a/package/python/python.mk
+++ b/package/python/python.mk
@@ -22,7 +22,6 @@ HOST_PYTHON_CONF_OPT += \
--disable-curses \
--disable-codecs-cjk \
--disable-nis \
- --disable-unicodedata \
--disable-dbm \
--disable-gdbm \
--disable-bsddb \
@@ -30,6 +29,13 @@ HOST_PYTHON_CONF_OPT += \
--disable-bz2 \
--disable-ssl
+ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y)
+ HOST_PYTHON_CONF_OPT += --disable-unicodedata
+else
+ HOST_PYTHON_CONF_OPT += --enable-unicodedata
+endif
+
+
HOST_PYTHON_MAKE_ENV = \
PYTHON_MODULES_INCLUDE=$(HOST_DIR)/usr/include \
PYTHON_MODULES_LIB="$(HOST_DIR)/lib $(HOST_DIR)/usr/lib"
--
1.7.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata
2012-08-15 19:00 ` Stefan Froberg
@ 2012-08-21 11:23 ` Thomas Petazzoni
2012-08-21 13:37 ` Stefan Fröberg
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2012-08-21 11:23 UTC (permalink / raw)
To: buildroot
Le Wed, 15 Aug 2012 22:00:26 +0300,
Stefan Froberg <stefan.froberg@petroprogram.com> a ?crit :
> +ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y)
> + HOST_PYTHON_CONF_OPT += --disable-unicodedata
> +else
> + HOST_PYTHON_CONF_OPT += --enable-unicodedata
> +endif
No, this is not correct. The BR2_PACKAGE_* options are here to
configure the *target* packages. Host packages that are only
dependencies to build target packages do not have kconfig options. So
in this case, the only solution is to simply use --enable-unicodedata
unconditionally to the host-python build.
Can you post an updated patch with this change?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata
2012-08-21 11:23 ` Thomas Petazzoni
@ 2012-08-21 13:37 ` Stefan Fröberg
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Fröberg @ 2012-08-21 13:37 UTC (permalink / raw)
To: buildroot
Hello Thomas
21.8.2012 14:23, Thomas Petazzoni kirjoitti:
> Le Wed, 15 Aug 2012 22:00:26 +0300,
> Stefan Froberg <stefan.froberg@petroprogram.com> a ?crit :
>
>> +ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y)
>> + HOST_PYTHON_CONF_OPT += --disable-unicodedata
>> +else
>> + HOST_PYTHON_CONF_OPT += --enable-unicodedata
>> +endif
> No, this is not correct. The BR2_PACKAGE_* options are here to
> configure the *target* packages. Host packages that are only
> dependencies to build target packages do not have kconfig options. So
> in this case, the only solution is to simply use --enable-unicodedata
> unconditionally to the host-python build.
Oh, sorry.
I was just trying to be carefull and not to mess with host-python too much.
>
> Can you post an updated patch with this change?
No problem. I will cook a new lil patch and resend.
By the way Thomas, what do you think about these two little changes to
SQLite and Valgrind ?
http://lists.busybox.net/pipermail/buildroot/2012-August/057377.html
http://lists.busybox.net/pipermail/buildroot/2012-August/057379.html
I also noticed that you accepted yasm and that little cairo patch for
next version.
Thank you!
Stefan
> Thanks,
>
> Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata
@ 2012-08-21 13:48 Stefan Froberg
2012-08-24 21:41 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Froberg @ 2012-08-21 13:48 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan Froberg <stefan.froberg@petroprogram.com>
---
package/python/python.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/package/python/python.mk b/package/python/python.mk
index fae4e5c..6a79584 100644
--- a/package/python/python.mk
+++ b/package/python/python.mk
@@ -22,7 +22,7 @@ HOST_PYTHON_CONF_OPT += \
--disable-curses \
--disable-codecs-cjk \
--disable-nis \
- --disable-unicodedata \
+ --enable-unicodedata \
--disable-dbm \
--disable-gdbm \
--disable-bsddb \
--
1.7.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata
2012-08-21 13:48 Stefan Froberg
@ 2012-08-24 21:41 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2012-08-24 21:41 UTC (permalink / raw)
To: buildroot
Le Tue, 21 Aug 2012 16:48:28 +0300,
Stefan Froberg <stefan.froberg@petroprogram.com> a ?crit :
> Signed-off-by: Stefan Froberg <stefan.froberg@petroprogram.com>
Could you send a complete set of patches with all the necessary
changes to add the firefox package, including the firefox package
itself?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-24 21:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-15 19:00 [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata Stefan Froberg
2012-08-15 19:00 ` Stefan Froberg
2012-08-21 11:23 ` Thomas Petazzoni
2012-08-21 13:37 ` Stefan Fröberg
-- strict thread matches above, loose matches on Subject: below --
2012-08-21 13:48 Stefan Froberg
2012-08-24 21:41 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox