[Buildroot] [PATCH] valgrind: valgrind/valgrind.h missing if --disable-tls enabled

[Buildroot] [PATCH] valgrind: valgrind/valgrind.h missing if --disable-tls enabled

[Stefan Froberg]

Enabling valgrind support and then doing debug build of Firefox
started configure script nagging about missing valgrind/valgrind.h file.

Found out that if --disable-tls is in VALGRIND_CONF_OPT then
the valgrind installation process will not include the previously mentioned file.

So this patch will enable/disable TLS for valgrind depending of
what you have in your compiler BR2_GCC_ENABLE_TLS setting.

[Buildroot] [PATCH] valgrind: valgrind/valgrind.h missing if --disable-tls enabled

[Stefan Froberg]

Signed-off-by: Stefan Froberg <stefan.froberg@petroprogram.com>
---
 package/valgrind/valgrind.mk |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/package/valgrind/valgrind.mk b/package/valgrind/valgrind.mk
index 05f402f..c39da4f 100644
--- a/package/valgrind/valgrind.mk
+++ b/package/valgrind/valgrind.mk
@@ -7,7 +7,12 @@
 VALGRIND_VERSION = 3.7.0
 VALGRIND_SITE    = http://valgrind.org/downloads/
 VALGRIND_SOURCE  = valgrind-$(VALGRIND_VERSION).tar.bz2
-VALGRIND_CONF_OPT = --disable-tls
+
+ifeq ($(BR2_GCC_ENABLE_TLS),y)
+	VALGRIND_CONF_OPT = --enable-tls
+else
+	VALGRIND_CONF_OPT = --disable-tls
+endif
 
 # On ARM, Valgrind only supports ARMv7, and uses the arch part of the
 # host tuple to determine whether it's being built for ARMv7 or
-- 
1.7.7.6

[Buildroot] [PATCH] valgrind: valgrind/valgrind.h missing if --disable-tls enabled

[Arnout Vandecappelle]

On 08/12/12 21:56, Stefan Froberg wrote:
> +ifeq ($(BR2_GCC_ENABLE_TLS),y)
> +	VALGRIND_CONF_OPT = --enable-tls
> +else
> +	VALGRIND_CONF_OPT = --disable-tls
> +endif

  This will only work for buildroot toolchains, not for crosstool-NG or external
toolchains...



  Regards,
  Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] valgrind: valgrind/valgrind.h missing if --disable-tls enabled

[Stefan Fröberg]

Good morning Arnout

22.8.2012 1:25, Arnout Vandecappelle kirjoitti:
> On 08/12/12 21:56, Stefan Froberg wrote:
>> +ifeq ($(BR2_GCC_ENABLE_TLS),y)
>> +    VALGRIND_CONF_OPT = --enable-tls
>> +else
>> +    VALGRIND_CONF_OPT = --disable-tls
>> +endif
>
>  This will only work for buildroot toolchains, not for crosstool-NG or
> external
> toolchains...
>
>

Hmmm...
How about this then?

ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y) && ($(BR2_GCC_ENABLE_TLS),y)
        VALGRIND_CONF_OPT = --enable-tls
else
        VALGRIND_CONF_OPT = --disable-tls
endif

Enabling only tls if using buildroot toolchain and tls selected in gcc
and otherwise disabled.

Stefan

>
>  Regards,
>  Arnout
>