* [Buildroot] [PATCH] use portable printf instead of echo -e, needed for MacOS X buildhost
@ 2012-09-20 8:01 Waldemar Brodkorb
2012-09-30 16:29 ` Arnout Vandecappelle
2012-10-06 11:05 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Waldemar Brodkorb @ 2012-09-20 8:01 UTC (permalink / raw)
To: buildroot
Hi,
echo -e is not a portable way to do this, better use printf.
Works with MacOS X.
Signed-off-by: Waldemar Brodkorb <mail@waldemar-brodkorb.de>
---
fs/common.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/common.mk b/fs/common.mk
index debf7db..0f0eae9 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -49,9 +49,9 @@ $(BINARIES_DIR)/rootfs.$(1): $(ROOTFS_$(2)_DEPENDENCIES)
ifneq ($(ROOTFS_DEVICE_TABLES),)
cat $(ROOTFS_DEVICE_TABLES) > $(FULL_DEVICE_TABLE)
ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
- echo -e '$(subst $(sep),\n,$(PACKAGES_DEVICES_TABLE))' >> $(FULL_DEVICE_TABLE)
+ printf '$(subst $(sep),\n,$(PACKAGES_DEVICES_TABLE))' >> $(FULL_DEVICE_TABLE)
endif
- echo -e '$(subst $(sep),\n,$(PACKAGES_PERMISSIONS_TABLE))' >> $(FULL_DEVICE_TABLE)
+ printf '$(subst $(sep),\n,$(PACKAGES_PERMISSIONS_TABLE))' >> $(FULL_DEVICE_TABLE)
echo "$(HOST_DIR)/usr/bin/makedevs -d $(FULL_DEVICE_TABLE) $(TARGET_DIR)" >> $(FAKEROOT_SCRIPT)
endif
echo "$(ROOTFS_$(2)_CMD)" >> $(FAKEROOT_SCRIPT)
--
1.7.11.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] use portable printf instead of echo -e, needed for MacOS X buildhost
2012-09-20 8:01 [Buildroot] [PATCH] use portable printf instead of echo -e, needed for MacOS X buildhost Waldemar Brodkorb
@ 2012-09-30 16:29 ` Arnout Vandecappelle
2012-10-06 11:05 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2012-09-30 16:29 UTC (permalink / raw)
To: buildroot
On 20/09/12 10:01, Waldemar Brodkorb wrote:
> Hi,
>
> echo -e is not a portable way to do this, better use printf.
> Works with MacOS X.
>
> Signed-off-by: Waldemar Brodkorb<mail@waldemar-brodkorb.de>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] use portable printf instead of echo -e, needed for MacOS X buildhost
2012-09-20 8:01 [Buildroot] [PATCH] use portable printf instead of echo -e, needed for MacOS X buildhost Waldemar Brodkorb
2012-09-30 16:29 ` Arnout Vandecappelle
@ 2012-10-06 11:05 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2012-10-06 11:05 UTC (permalink / raw)
To: buildroot
>>>>> "Waldemar" == Waldemar Brodkorb <mail@waldemar-brodkorb.de> writes:
Waldemar> Hi,
Waldemar> echo -e is not a portable way to do this, better use printf.
Waldemar> Works with MacOS X.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-06 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-20 8:01 [Buildroot] [PATCH] use portable printf instead of echo -e, needed for MacOS X buildhost Waldemar Brodkorb
2012-09-30 16:29 ` Arnout Vandecappelle
2012-10-06 11:05 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox