Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'
@ 2012-10-17 21:46 Thomas Petazzoni
  2012-10-17 21:49 ` Yann E. MORIN
  2012-10-18  7:10 ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2012-10-17 21:46 UTC (permalink / raw)
  To: buildroot

Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng
backend generates toolchains that have a prefix inconsistent with what
Buildroot expects. Buildroot expects a "buildroot" vendor name, while
Crosstool-NG builds toolchain with the "unknown" vendor name.

This is causing build failure such as:

  http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log

Fix this by changing the vendor part of the tuple used by Crosstool-NG
to "buildroot".

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
index d18f5d5..e46bb20 100644
--- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
+++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
@@ -201,7 +201,7 @@ CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_[BL]E).*:\# \2 is not set:;
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_ENDIAN)) is not set:\1=y:;
 CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_(32|64)).*:\# \2 is not set:;
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_BIT)) is not set:\1=y:;
-CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="unknown":;
+CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="buildroot":;
 CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_ALIAS)=.*:\1="$(ARCH)-linux":;
 CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TOOLCHAIN_PKGVERSION)="(.*)":\1="buildroot $(BR2_VERSION_FULL)":;
 ifneq ($(call qstrip,$(BR2_USE_MMU)),)
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'
  2012-10-17 21:46 [Buildroot] [PATCH] toolchain/crosstool-ng: vendor part of tuple should be 'buildroot' Thomas Petazzoni
@ 2012-10-17 21:49 ` Yann E. MORIN
  2012-10-17 22:19   ` Arnout Vandecappelle
  2012-10-18  7:10 ` Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2012-10-17 21:49 UTC (permalink / raw)
  To: buildroot

Thomas, All,

On Wednesday 17 October 2012 Thomas Petazzoni wrote:
> Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng
> backend generates toolchains that have a prefix inconsistent with what
> Buildroot expects. Buildroot expects a "buildroot" vendor name, while
> Crosstool-NG builds toolchain with the "unknown" vendor name.
> 
> This is causing build failure such as:
> 
>   http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log
> 
> Fix this by changing the vendor part of the tuple used by Crosstool-NG
> to "buildroot".
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> index d18f5d5..e46bb20 100644
> --- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> +++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> @@ -201,7 +201,7 @@ CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_[BL]E).*:\# \2 is not set:;
>  CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_ENDIAN)) is not set:\1=y:;
>  CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_(32|64)).*:\# \2 is not set:;
>  CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_BIT)) is not set:\1=y:;
> -CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="unknown":;
> +CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="buildroot":;
>  CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_ALIAS)=.*:\1="$(ARCH)-linux":;
>  CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TOOLCHAIN_PKGVERSION)="(.*)":\1="buildroot $(BR2_VERSION_FULL)":;
>  ifneq ($(call qstrip,$(BR2_USE_MMU)),)
> -- 
> 1.7.9.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'
  2012-10-17 21:49 ` Yann E. MORIN
@ 2012-10-17 22:19   ` Arnout Vandecappelle
  0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2012-10-17 22:19 UTC (permalink / raw)
  To: buildroot

On 17/10/12 23:49, Yann E. MORIN wrote:
> On Wednesday 17 October 2012 Thomas Petazzoni wrote:
>> >  Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng
>> >  backend generates toolchains that have a prefix inconsistent with what
>> >  Buildroot expects. Buildroot expects a "buildroot" vendor name, while
>> >  Crosstool-NG builds toolchain with the "unknown" vendor name.
>> >
>> >  This is causing build failure such as:
>> >
>> >     http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log
>> >
>> >  Fix this by changing the vendor part of the tuple used by Crosstool-NG
>> >  to "buildroot".
>> >
>> >  Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>
> Acked-by: "Yann E. MORIN"<yann.morin.1998@free.fr>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  I had the very same patch lined up but forgot to commit and mail it...

  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'
  2012-10-17 21:46 [Buildroot] [PATCH] toolchain/crosstool-ng: vendor part of tuple should be 'buildroot' Thomas Petazzoni
  2012-10-17 21:49 ` Yann E. MORIN
@ 2012-10-18  7:10 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2012-10-18  7:10 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng
 Thomas> backend generates toolchains that have a prefix inconsistent with what
 Thomas> Buildroot expects. Buildroot expects a "buildroot" vendor name, while
 Thomas> Crosstool-NG builds toolchain with the "unknown" vendor name.

 Thomas> This is causing build failure such as:

 Thomas>   http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log

 Thomas> Fix this by changing the vendor part of the tuple used by Crosstool-NG
 Thomas> to "buildroot".

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-10-18  7:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-17 21:46 [Buildroot] [PATCH] toolchain/crosstool-ng: vendor part of tuple should be 'buildroot' Thomas Petazzoni
2012-10-17 21:49 ` Yann E. MORIN
2012-10-17 22:19   ` Arnout Vandecappelle
2012-10-18  7:10 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox