From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff
Date: Sat, 10 Nov 2012 01:59:59 +0100 [thread overview]
Message-ID: <509DA70F.7070102@mind.be> (raw)
In-Reply-To: <509DA5F3.2000108@mind.be>
On 11/10/12 01:55, Arnout Vandecappelle wrote:
> On 11/09/12 17:54, Samuel Martin wrote:
>> Hi Alexander,
>>
>> 2012/11/9 Alexander Khryukin<alexander@mezon.ru>:
>>> >
>>> > Signed-off-by: Alexander Khryukin<alexander@mezon.ru>
>>> > ---
>>> > package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++
>>> > 1 file changed, 26 insertions(+)
>>> > create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
>>> >
>>> > diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
>>> > new file mode 100644
>>> > index 0000000..6b7f545
>>> > --- /dev/null
>>> > +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
>>> > @@ -0,0 +1,26 @@
>>> > +--- gnutls-2.12.20/gl/stdio.in.h
>>> > ++++ gnutls-2.12.20/gl/stdio.in.h
>> When adding a patch to a package, we usually add a header to the patch
>> containing a description and the SoB line.
>
> And the commit message itself should also be something more explanatory, e.g.:
>
> gnutls: fix build with glibc2.16, which doesn't declare gets()
BTW, I verified that this indeed fixes the build for glibc2.16, so with a
corrected commit message and a SoB in the patch, this gets my
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2012-11-10 0:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 12:31 [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff Alexander Khryukin
2012-11-09 16:54 ` Samuel Martin
2012-11-09 17:19 ` Alexander Khryukin
2012-11-10 0:55 ` Arnout Vandecappelle
2012-11-10 0:59 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509DA70F.7070102@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox