* [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff
@ 2012-11-09 12:31 Alexander Khryukin
2012-11-09 16:54 ` Samuel Martin
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Khryukin @ 2012-11-09 12:31 UTC (permalink / raw)
To: buildroot
Signed-off-by: Alexander Khryukin <alexander@mezon.ru>
---
package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
new file mode 100644
index 0000000..6b7f545
--- /dev/null
+++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
@@ -0,0 +1,26 @@
+--- gnutls-2.12.20/gl/stdio.in.h
++++ gnutls-2.12.20/gl/stdio.in.h
+@@ -714,8 +714,10 @@
+ /* It is very rare that the developer ever has full control of stdin,
+ so any use of gets warrants an unconditional warning. Assume it is
+ always declared, since it is required by C89. */
++#ifdef HAVE_RAW_DECL_GETS
+ _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
+ #endif
++#endif
+
+
+ #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@
+--- gnutls-2.12.20/lib/gl/stdio.in.h
++++ gnutls-2.12.20/lib/gl/stdio.in.h
+@@ -714,8 +714,10 @@
+ /* It is very rare that the developer ever has full control of stdin,
+ so any use of gets warrants an unconditional warning. Assume it is
+ always declared, since it is required by C89. */
++#ifdef HAVE_RAW_DECL_GETS
+ _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
+ #endif
++#endif
+
+
+ #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@
--
1.7.11.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff
2012-11-09 12:31 [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff Alexander Khryukin
@ 2012-11-09 16:54 ` Samuel Martin
2012-11-09 17:19 ` Alexander Khryukin
2012-11-10 0:55 ` Arnout Vandecappelle
0 siblings, 2 replies; 5+ messages in thread
From: Samuel Martin @ 2012-11-09 16:54 UTC (permalink / raw)
To: buildroot
Hi Alexander,
2012/11/9 Alexander Khryukin <alexander@mezon.ru>:
>
> Signed-off-by: Alexander Khryukin <alexander@mezon.ru>
> ---
> package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
>
> diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
> new file mode 100644
> index 0000000..6b7f545
> --- /dev/null
> +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
> @@ -0,0 +1,26 @@
> +--- gnutls-2.12.20/gl/stdio.in.h
> ++++ gnutls-2.12.20/gl/stdio.in.h
When adding a patch to a package, we usually add a header to the patch
containing a description and the SoB line.
Regards,
--
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff
2012-11-09 16:54 ` Samuel Martin
@ 2012-11-09 17:19 ` Alexander Khryukin
2012-11-10 0:55 ` Arnout Vandecappelle
1 sibling, 0 replies; 5+ messages in thread
From: Alexander Khryukin @ 2012-11-09 17:19 UTC (permalink / raw)
To: buildroot
2012/11/9 Samuel Martin <s.martin49@gmail.com>
> Hi Alexander,
>
> 2012/11/9 Alexander Khryukin <alexander@mezon.ru>:
> >
> > Signed-off-by: Alexander Khryukin <alexander@mezon.ru>
> > ---
> > package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26
> ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> > create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
> >
> > diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch
> b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
> > new file mode 100644
> > index 0000000..6b7f545
> > --- /dev/null
> > +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
> > @@ -0,0 +1,26 @@
> > +--- gnutls-2.12.20/gl/stdio.in.h
> > ++++ gnutls-2.12.20/gl/stdio.in.h
> When adding a patch to a package, we usually add a header to the patch
> containing a description and the SoB line.
>
> Regards,
>
> --
> Sam
>
Looks as my mistake.
In a short time i'll send good patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20121109/9678e105/attachment-0001.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff
2012-11-09 16:54 ` Samuel Martin
2012-11-09 17:19 ` Alexander Khryukin
@ 2012-11-10 0:55 ` Arnout Vandecappelle
2012-11-10 0:59 ` Arnout Vandecappelle
1 sibling, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2012-11-10 0:55 UTC (permalink / raw)
To: buildroot
On 11/09/12 17:54, Samuel Martin wrote:
> Hi Alexander,
>
> 2012/11/9 Alexander Khryukin<alexander@mezon.ru>:
>> >
>> > Signed-off-by: Alexander Khryukin<alexander@mezon.ru>
>> > ---
>> > package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++
>> > 1 file changed, 26 insertions(+)
>> > create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
>> >
>> > diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
>> > new file mode 100644
>> > index 0000000..6b7f545
>> > --- /dev/null
>> > +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
>> > @@ -0,0 +1,26 @@
>> > +--- gnutls-2.12.20/gl/stdio.in.h
>> > ++++ gnutls-2.12.20/gl/stdio.in.h
> When adding a patch to a package, we usually add a header to the patch
> containing a description and the SoB line.
And the commit message itself should also be something more explanatory, e.g.:
gnutls: fix build with glibc2.16, which doesn't declare gets()
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff
2012-11-10 0:55 ` Arnout Vandecappelle
@ 2012-11-10 0:59 ` Arnout Vandecappelle
0 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2012-11-10 0:59 UTC (permalink / raw)
To: buildroot
On 11/10/12 01:55, Arnout Vandecappelle wrote:
> On 11/09/12 17:54, Samuel Martin wrote:
>> Hi Alexander,
>>
>> 2012/11/9 Alexander Khryukin<alexander@mezon.ru>:
>>> >
>>> > Signed-off-by: Alexander Khryukin<alexander@mezon.ru>
>>> > ---
>>> > package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++
>>> > 1 file changed, 26 insertions(+)
>>> > create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
>>> >
>>> > diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
>>> > new file mode 100644
>>> > index 0000000..6b7f545
>>> > --- /dev/null
>>> > +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
>>> > @@ -0,0 +1,26 @@
>>> > +--- gnutls-2.12.20/gl/stdio.in.h
>>> > ++++ gnutls-2.12.20/gl/stdio.in.h
>> When adding a patch to a package, we usually add a header to the patch
>> containing a description and the SoB line.
>
> And the commit message itself should also be something more explanatory, e.g.:
>
> gnutls: fix build with glibc2.16, which doesn't declare gets()
BTW, I verified that this indeed fixes the build for glibc2.16, so with a
corrected commit message and a SoB in the patch, this gets my
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-11-10 0:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-09 12:31 [Buildroot] [PATCH] gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff Alexander Khryukin
2012-11-09 16:54 ` Samuel Martin
2012-11-09 17:19 ` Alexander Khryukin
2012-11-10 0:55 ` Arnout Vandecappelle
2012-11-10 0:59 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox