From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR
Date: Tue, 04 Dec 2012 23:21:24 +0100 [thread overview]
Message-ID: <50BE7764.4020204@mind.be> (raw)
In-Reply-To: <1354529151-17426-1-git-send-email-sho@relinux.de>
On 03/12/12 11:05, Stephan Hoffmann wrote:
> There is a check for OVERRIDE_SRCDIR in pkg-generic.mk that is
> supposed to produce a warning when OVERRIDE_SRCDIR is active.
> This does not work and instead the whole make terminates with
> an error message.
>
> This patch changes the check for active OVERRIDE_SRCDIR so that
> it works as expected.
>
> Signed-off-by: Stephan Hoffmann<sho@relinux.de>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(visual inspection only)
Regards,
Arnout
> ---
> package/pkg-generic.mk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 9c4fffa..d6bcb67 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -479,7 +479,7 @@ ifneq ($(call qstrip,$$($(2)_SOURCE)),)
> ifeq ($$($(2)_SITE_METHOD),local)
> # Packages without a tarball: don't save and warn
> @$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),local)
> -else ifeq ($$($(2)_SITE_METHOD),override)
> +else ifneq ($$($(2)_OVERRIDE_SRCDIR),)
> @$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),override)
> else
> # Other packages
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-12-04 22:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 10:05 [Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR Stephan Hoffmann
2012-12-04 22:21 ` Arnout Vandecappelle [this message]
2012-12-05 19:30 ` Peter Korsgaard
2012-12-06 10:26 ` Stephan Hoffmann
2012-12-06 17:07 ` Peter Korsgaard
2012-12-06 23:15 ` Arnout Vandecappelle
2012-12-07 1:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BE7764.4020204@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox