[Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR

[Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR

[Stephan Hoffmann]

There is a check for OVERRIDE_SRCDIR in pkg-generic.mk that is
supposed to produce a warning when OVERRIDE_SRCDIR is active.
This does not work and instead the whole make terminates with
an error message.

This patch changes the check for active OVERRIDE_SRCDIR so that
it works as expected.

Signed-off-by: Stephan Hoffmann <sho@relinux.de>
---
 package/pkg-generic.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 9c4fffa..d6bcb67 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -479,7 +479,7 @@ ifneq ($(call qstrip,$$($(2)_SOURCE)),)
 ifeq ($$($(2)_SITE_METHOD),local)
 # Packages without a tarball: don't save and warn
 	@$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),local)
-else ifeq ($$($(2)_SITE_METHOD),override)
+else ifneq ($$($(2)_OVERRIDE_SRCDIR),)
 	@$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),override)
 else
 # Other packages
-- 
1.7.0.4

[Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR

[Arnout Vandecappelle]

On 03/12/12 11:05, Stephan Hoffmann wrote:
> There is a check for OVERRIDE_SRCDIR in pkg-generic.mk that is
> supposed to produce a warning when OVERRIDE_SRCDIR is active.
> This does not work and instead the whole make terminates with
> an error message.
>
> This patch changes the check for active OVERRIDE_SRCDIR so that
> it works as expected.
>
> Signed-off-by: Stephan Hoffmann<sho@relinux.de>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (visual inspection only)


  Regards,
  Arnout

> ---
>   package/pkg-generic.mk |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 9c4fffa..d6bcb67 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -479,7 +479,7 @@ ifneq ($(call qstrip,$$($(2)_SOURCE)),)
>   ifeq ($$($(2)_SITE_METHOD),local)
>   # Packages without a tarball: don't save and warn
>   	@$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),local)
> -else ifeq ($$($(2)_SITE_METHOD),override)
> +else ifneq ($$($(2)_OVERRIDE_SRCDIR),)
>   	@$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),override)
>   else
>   # Other packages

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR

[Peter Korsgaard]

>>>>> "Stephan" == Stephan Hoffmann <sho@relinux.de> writes:

 Stephan> There is a check for OVERRIDE_SRCDIR in pkg-generic.mk that is
 Stephan> supposed to produce a warning when OVERRIDE_SRCDIR is active.
 Stephan> This does not work and instead the whole make terminates with
 Stephan> an error message.

 Stephan> This patch changes the check for active OVERRIDE_SRCDIR so that
 Stephan> it works as expected.

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR

[Stephan Hoffmann]

Am 05.12.2012 20:30, schrieb Peter Korsgaard:
>>>>>> "Stephan" == Stephan Hoffmann <sho@relinux.de> writes:
>  Stephan> There is a check for OVERRIDE_SRCDIR in pkg-generic.mk that is
>  Stephan> supposed to produce a warning when OVERRIDE_SRCDIR is active.
>  Stephan> This does not work and instead the whole make terminates with
>  Stephan> an error message.
>
>  Stephan> This patch changes the check for active OVERRIDE_SRCDIR so that
>  Stephan> it works as expected.
>
> Committed, thanks.
>
Hi,

sorry, but I forgot that Arnout's patch
http://lists.busybox.net/pipermail/buildroot/2012-October/059910.html is
not yet applied. My patch does not work without this.

Kind regards

Stephan

-- 
reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20121206/040baca5/attachment.html>

[Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR

[Peter Korsgaard]

>>>>> "Stephan" == Stephan Hoffmann <sho@relinux.de> writes:

Hi,

 Stephan>     Committed, thanks.

 Stephan> Hi,

 Stephan> sorry, but I forgot that Arnout's patch
 Stephan> http://lists.busybox.net/pipermail/
 Stephan> buildroot/2012-October/059910.html is not yet applied. My
 Stephan> patch does not work without this.

Ahh, ok. Arnout, you mentioned you would rework and resend the patch:

http://lists.busybox.net/pipermail/buildroot/2012-October/059941.html

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR

[Arnout Vandecappelle]

On 06/12/12 18:07, Peter Korsgaard wrote:
>>>>>> "Stephan" == Stephan Hoffmann<sho@relinux.de>  writes:
>
> Hi,
>
>   Stephan>      Committed, thanks.
>
>   Stephan>  Hi,
>
>   Stephan>  sorry, but I forgot that Arnout's patch
>   Stephan>  http://lists.busybox.net/pipermail/
>   Stephan>  buildroot/2012-October/059910.html is not yet applied. My
>   Stephan>  patch does not work without this.
>
> Ahh, ok. Arnout, you mentioned you would rework and resend the patch:
>
> http://lists.busybox.net/pipermail/buildroot/2012-October/059941.html

  Which I did:
http://lists.busybox.net/pipermail/buildroot/2012-October/059954.html

  I'll resend with the ACKs.

  Regards,
  Arnout


-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 Stephan> sorry, but I forgot that Arnout's patch
 Stephan> http://lists.busybox.net/pipermail/
 Stephan> buildroot/2012-October/059910.html is not yet applied. My
 Stephan> patch does not work without this.
 >> 
 >> Ahh, ok. Arnout, you mentioned you would rework and resend the patch:
 >> 
 >> http://lists.busybox.net/pipermail/buildroot/2012-October/059941.html

 Arnout>  Which I did:
 Arnout> http://lists.busybox.net/pipermail/buildroot/2012-October/059954.html

Ahh, sorry - And thanks.

-- 
Bye, Peter Korsgaard