* [Buildroot] [PATCH] pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support
@ 2012-12-06 23:16 Arnout Vandecappelle
2012-12-07 1:14 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Arnout Vandecappelle @ 2012-12-06 23:16 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
The legal-info target (and possibly others as well) depends on
<pkg>-extract to make sure the license file is available. However,
when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target
doesn't exist.
To solve this, we add <pkg>-extract which depends on <pkg>-rsync.
While we're at it, we do the same for <pkg>-patch. That avoids the
same problem in the future if something starts depending on
<pkg>-patch.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
---
v2: As ThomasP suggested, don't remove <pkg>-rsync.
---
package/pkg-generic.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 6fcd359..13c1d83 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -390,6 +390,9 @@ $(1)-configure: $(1)-depends \
$(1)-depends: $(1)-rsync $$($(2)_DEPENDENCIES)
+$(1)-patch: $(1)-rsync
+$(1)-extract: $(1)-rsync
+
$(1)-rsync: $$($(2)_TARGET_RSYNC)
$(1)-source: $$($(2)_TARGET_RSYNC_SOURCE)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support
2012-12-06 23:16 [Buildroot] [PATCH] pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support Arnout Vandecappelle
@ 2012-12-07 1:14 ` Peter Korsgaard
2012-12-07 10:32 ` Stephan Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2012-12-07 1:14 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Hi,
Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Arnout> The legal-info target (and possibly others as well) depends on
Arnout> <pkg>-extract to make sure the license file is available. However,
Arnout> when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target
Arnout> doesn't exist.
Arnout> To solve this, we add <pkg>-extract which depends on <pkg>-rsync.
Arnout> While we're at it, we do the same for <pkg>-patch. That avoids the
Arnout> same problem in the future if something starts depending on
Arnout> <pkg>-patch.
Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Arnout> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Arnout> Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support
2012-12-07 1:14 ` Peter Korsgaard
@ 2012-12-07 10:32 ` Stephan Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Stephan Hoffmann @ 2012-12-07 10:32 UTC (permalink / raw)
To: buildroot
Am 07.12.2012 02:14, schrieb Peter Korsgaard:
>>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> Hi,
>
> Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
> Arnout> The legal-info target (and possibly others as well) depends on
> Arnout> <pkg>-extract to make sure the license file is available. However,
> Arnout> when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target
> Arnout> doesn't exist.
>
> Arnout> To solve this, we add <pkg>-extract which depends on <pkg>-rsync.
> Arnout> While we're at it, we do the same for <pkg>-patch. That avoids the
> Arnout> same problem in the future if something starts depending on
> Arnout> <pkg>-patch.
>
> Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Arnout> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Arnout> Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
>
> Committed, thanks.
>
Thanks, now legal info works together with OVERRIDE.
Stephan
--
reLinux - Stephan Hoffmann
Am Schmidtgrund 124 50765 K?ln
Tel. +49.221.95595-19 Fax: -64
www.reLinux.de sho at reLinux.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-07 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-06 23:16 [Buildroot] [PATCH] pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support Arnout Vandecappelle
2012-12-07 1:14 ` Peter Korsgaard
2012-12-07 10:32 ` Stephan Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox