From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: Support multiple device tree build
Date: Mon, 17 Dec 2012 23:13:13 +0100 [thread overview]
Message-ID: <50CF98F9.8030602@mind.be> (raw)
In-Reply-To: <1355742312-25258-1-git-send-email-maxime.ripard@free-electrons.com>
On 17/12/12 12:05, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard<maxime.ripard@free-electrons.com>
> ---
> linux/linux.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index c4bdf90..c7d0099 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -187,10 +187,12 @@ endef
> ifeq ($(BR2_LINUX_KERNEL_DTS_SUPPORT),y)
> ifeq ($(BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT),)
> define LINUX_BUILD_DTB
> - $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(KERNEL_DTS_NAME).dtb
> + $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) \
> + $(foreach dtbfile, $(call qstrip, $(KERNEL_DTS_NAME)), $(dtbfile).dtb)
I would personally prefer
$(addsuffix .dtb,$(call qstrip,$(KERNEL_DTS_NAME)))
> endef
> define LINUX_INSTALL_DTB
> - cp $(KERNEL_ARCH_PATH)/boot/$(KERNEL_DTS_NAME).dtb $(BINARIES_DIR)/
> + $(foreach dtbfile, $(call qstrip, $(KERNEL_DTS_NAME)),
> + cp $(KERNEL_ARCH_PATH)/boot/$(dtbfile).dtb $(BINARIES_DIR)/)
Does this work? I would expect you need a $(sep) or ; between the cp
statements...
But since it's a cp (not an install), you can put the foreach inside
the cp.
Regards,
Arnout
> endef
> endif
> endif
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2012-12-17 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 11:05 [Buildroot] [PATCH] linux: Support multiple device tree build Maxime Ripard
2012-12-17 11:12 ` Baruch Siach
2012-12-17 22:13 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CF98F9.8030602@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox