* [Buildroot] [PATCH] linux: Support multiple device tree build
@ 2012-12-17 11:05 Maxime Ripard
2012-12-17 11:12 ` Baruch Siach
2012-12-17 22:13 ` Arnout Vandecappelle
0 siblings, 2 replies; 3+ messages in thread
From: Maxime Ripard @ 2012-12-17 11:05 UTC (permalink / raw)
To: buildroot
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
linux/linux.mk | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/linux/linux.mk b/linux/linux.mk
index c4bdf90..c7d0099 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -187,10 +187,12 @@ endef
ifeq ($(BR2_LINUX_KERNEL_DTS_SUPPORT),y)
ifeq ($(BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT),)
define LINUX_BUILD_DTB
- $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(KERNEL_DTS_NAME).dtb
+ $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) \
+ $(foreach dtbfile, $(call qstrip, $(KERNEL_DTS_NAME)), $(dtbfile).dtb)
endef
define LINUX_INSTALL_DTB
- cp $(KERNEL_ARCH_PATH)/boot/$(KERNEL_DTS_NAME).dtb $(BINARIES_DIR)/
+ $(foreach dtbfile, $(call qstrip, $(KERNEL_DTS_NAME)),
+ cp $(KERNEL_ARCH_PATH)/boot/$(dtbfile).dtb $(BINARIES_DIR)/)
endef
endif
endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] linux: Support multiple device tree build
2012-12-17 11:05 [Buildroot] [PATCH] linux: Support multiple device tree build Maxime Ripard
@ 2012-12-17 11:12 ` Baruch Siach
2012-12-17 22:13 ` Arnout Vandecappelle
1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2012-12-17 11:12 UTC (permalink / raw)
To: buildroot
Hi Maxime,
On Mon, Dec 17, 2012 at 12:05:12PM +0100, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> linux/linux.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index c4bdf90..c7d0099 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -187,10 +187,12 @@ endef
> ifeq ($(BR2_LINUX_KERNEL_DTS_SUPPORT),y)
> ifeq ($(BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT),)
> define LINUX_BUILD_DTB
> - $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(KERNEL_DTS_NAME).dtb
> + $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) \
> + $(foreach dtbfile, $(call qstrip, $(KERNEL_DTS_NAME)), $(dtbfile).dtb)
> endef
> define LINUX_INSTALL_DTB
> - cp $(KERNEL_ARCH_PATH)/boot/$(KERNEL_DTS_NAME).dtb $(BINARIES_DIR)/
> + $(foreach dtbfile, $(call qstrip, $(KERNEL_DTS_NAME)),
> + cp $(KERNEL_ARCH_PATH)/boot/$(dtbfile).dtb $(BINARIES_DIR)/)
> endef
> endif
> endif
Please update the comment and help text in the
BR2_LINUX_KERNEL_INTREE_DTS_NAME config option as well.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] linux: Support multiple device tree build
2012-12-17 11:05 [Buildroot] [PATCH] linux: Support multiple device tree build Maxime Ripard
2012-12-17 11:12 ` Baruch Siach
@ 2012-12-17 22:13 ` Arnout Vandecappelle
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2012-12-17 22:13 UTC (permalink / raw)
To: buildroot
On 17/12/12 12:05, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard<maxime.ripard@free-electrons.com>
> ---
> linux/linux.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index c4bdf90..c7d0099 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -187,10 +187,12 @@ endef
> ifeq ($(BR2_LINUX_KERNEL_DTS_SUPPORT),y)
> ifeq ($(BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT),)
> define LINUX_BUILD_DTB
> - $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(KERNEL_DTS_NAME).dtb
> + $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) \
> + $(foreach dtbfile, $(call qstrip, $(KERNEL_DTS_NAME)), $(dtbfile).dtb)
I would personally prefer
$(addsuffix .dtb,$(call qstrip,$(KERNEL_DTS_NAME)))
> endef
> define LINUX_INSTALL_DTB
> - cp $(KERNEL_ARCH_PATH)/boot/$(KERNEL_DTS_NAME).dtb $(BINARIES_DIR)/
> + $(foreach dtbfile, $(call qstrip, $(KERNEL_DTS_NAME)),
> + cp $(KERNEL_ARCH_PATH)/boot/$(dtbfile).dtb $(BINARIES_DIR)/)
Does this work? I would expect you need a $(sep) or ; between the cp
statements...
But since it's a cp (not an install), you can put the foreach inside
the cp.
Regards,
Arnout
> endef
> endif
> endif
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-17 22:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-17 11:05 [Buildroot] [PATCH] linux: Support multiple device tree build Maxime Ripard
2012-12-17 11:12 ` Baruch Siach
2012-12-17 22:13 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox