Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] allow wpa_supplicant to run on the dbus using the 'new' api
Date: Tue, 18 Dec 2012 07:58:04 +0100	[thread overview]
Message-ID: <50D013FC.7040503@mind.be> (raw)
In-Reply-To: <CAEnpE0yDTQWpUf9ctGnfuSjX8PR0uX6UcxzvdV6D6uoxrAg1zQ@mail.gmail.com>

On 17/12/12 21:54, Gary Coulbourne wrote:
> When wpa_supplicant is built, it compiles to use the old names on the
> dbus, as well as with the wrong executable name in the dbus activation
> service.
>
> This patch builds on a patch submitted in Sept by Sven Neumann.

  Hi Gary,

  Reviewing patches is more convenient for us if you do the following:

* Send the patch in-line, preferably with git send-email, so we can give 
comments in-line.

* Keep the original patch comment if it is still appropriate.

* Make sure the patch is called PATCHv2 or similar by sending with 'git 
send-email --subject-prefix=PATCHv2'.

* Include a changelog in the patch. It should come below the 
Signed-off-by line(s), seperated by
---
and it should explain which changes were made and why.

* Keep the original author information - in this case, preferably by 
keeping the original git authorship.


  I did a quick comparison with Sven's patch and I don't see why you 
removed the BR2_PACKAGE_WPA_SUPPLICANT_DBUS_OLD option.

  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2012-12-18  6:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 20:54 [Buildroot] [PATCH] allow wpa_supplicant to run on the dbus using the 'new' api Gary Coulbourne
2012-12-18  6:58 ` Arnout Vandecappelle [this message]
2012-12-18  7:52   ` [Buildroot] [PATCH RESEND 1/2] wpa-supplicant: add options to enable the new DBus interface Arnout Vandecappelle
2012-12-18  7:52     ` [Buildroot] [PATCH RESEND 2/2] wpa_supplicant: rework .config file editing Arnout Vandecappelle
2013-01-14 19:48     ` [Buildroot] [PATCH RESEND 1/2] wpa-supplicant: add options to enable the new DBus interface Peter Korsgaard
2012-12-18 15:38   ` [Buildroot] [PATCH] allow wpa_supplicant to run on the dbus using the 'new' api Gary Coulbourne
2012-12-18 17:06     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D013FC.7040503@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox