From: Gary Coulbourne <bear@bears.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] allow wpa_supplicant to run on the dbus using the 'new' api
Date: Tue, 18 Dec 2012 10:38:21 -0500 [thread overview]
Message-ID: <50D08DED.6070109@bears.org> (raw)
In-Reply-To: <50D013FC.7040503@mind.be>
Arnout Vandecappelle wrote:
> Reviewing patches is more convenient for us if you do the following:
>
> * Send the patch in-line, preferably with git send-email, so we can
> give comments in-line.
Sorry. I'll keep that in mind next time. I'm a long time hacker, but
not a long-time contributor to open source. :)
Thanks for being gentle with the criticism; I am still feeling my way
around what is proper etiquette.
> * Keep the original author information - in this case, preferably by
> keeping the original git authorship.
I was only able to find a partial copy of it via a google search, so I
didn't have the original. I didn't think about it at the time, but I
should have gone and looked in the mailing list archives.
> I did a quick comparison with Sven's patch and I don't see why you
> removed the BR2_PACKAGE_WPA_SUPPLICANT_DBUS_OLD option.
Purely ignorance on my part -- I didn't realize that it was a both/and
rather than an either/or for that option.
The reason I needed the fix is because connman is expecting the new API,
and so fails to find wireless devices without wpa_supplicant using it.
The dbus fix I sent seperately makes dbus properly handle activation, so
that it can start the wpa_supplicant. The test in the autoconf fails and
says the fixes need to be done manually. (I suspect it is because dbus
is cross compiled, so the tests can't run on the host)
Peace,
Gary
next prev parent reply other threads:[~2012-12-18 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 20:54 [Buildroot] [PATCH] allow wpa_supplicant to run on the dbus using the 'new' api Gary Coulbourne
2012-12-18 6:58 ` Arnout Vandecappelle
2012-12-18 7:52 ` [Buildroot] [PATCH RESEND 1/2] wpa-supplicant: add options to enable the new DBus interface Arnout Vandecappelle
2012-12-18 7:52 ` [Buildroot] [PATCH RESEND 2/2] wpa_supplicant: rework .config file editing Arnout Vandecappelle
2013-01-14 19:48 ` [Buildroot] [PATCH RESEND 1/2] wpa-supplicant: add options to enable the new DBus interface Peter Korsgaard
2012-12-18 15:38 ` Gary Coulbourne [this message]
2012-12-18 17:06 ` [Buildroot] [PATCH] allow wpa_supplicant to run on the dbus using the 'new' api Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D08DED.6070109@bears.org \
--to=bear@bears.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox