* [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target
@ 2012-12-21 10:36 Fabio Porcedda
2012-12-21 10:36 ` [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain Fabio Porcedda
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Fabio Porcedda @ 2012-12-21 10:36 UTC (permalink / raw)
To: buildroot
Hi all,
this patch set is to add a toolchain target to be able
to build only the toolchain right after a defconfig or a clean.
Best regards
Fabio Porcedda (2):
Makefile: rename cross target -> toolchain
Makefile: use toolchain target in the world target
Makefile | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--
1.8.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
2012-12-21 10:36 [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
@ 2012-12-21 10:36 ` Fabio Porcedda
2012-12-21 12:00 ` Markos Chandras
` (2 more replies)
2012-12-21 10:36 ` [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target Fabio Porcedda
2013-01-07 12:29 ` [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
2 siblings, 3 replies; 13+ messages in thread
From: Fabio Porcedda @ 2012-12-21 10:36 UTC (permalink / raw)
To: buildroot
- Use a more descriptive name, the same of the "toolchain" directory.
- Add missing dependencies to be able to successfully use the target
right after the configuration.
- Move to a better position.
- Documentation it in the help target.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
Makefile | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 4b09437..458b8c5 100644
--- a/Makefile
+++ b/Makefile
@@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config
prepare: $(BUILD_DIR)/buildroot-config/auto.conf
+toolchain: prepare dirs dependencies $(BASE_TARGETS)
+
world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
-.PHONY: all world dirs clean distclean source outputmakefile \
+.PHONY: all world toolchain dirs clean distclean source outputmakefile \
legal-info legal-info-prepare legal-info-clean \
$(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \
$(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \
@@ -697,8 +699,6 @@ ifeq ($(O),output)
endif
rm -rf $(CONFIG_DIR)/.config $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/.auto.deps
-cross: $(BASE_TARGETS)
-
help:
@echo 'Cleaning:'
@echo ' clean - delete all files created by build'
@@ -706,6 +706,7 @@ help:
@echo
@echo 'Build:'
@echo ' all - make world'
+ @echo ' toolchain - build toolchain'
@echo ' <package>-rebuild - force recompile <package>'
@echo ' <package>-reconfigure - force reconfigure <package>'
@echo
--
1.8.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
2012-12-21 10:36 ` [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain Fabio Porcedda
@ 2012-12-21 12:00 ` Markos Chandras
2012-12-21 12:42 ` Arnout Vandecappelle
2012-12-22 12:45 ` Samuel Martin
2 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2012-12-21 12:00 UTC (permalink / raw)
To: buildroot
On 21 December 2012 10:36, Fabio Porcedda <fabio.porcedda@gmail.com> wrote:
> - Use a more descriptive name, the same of the "toolchain" directory.
> - Add missing dependencies to be able to successfully use the target
> right after the configuration.
> - Move to a better position.
> - Documentation it in the help target.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
> Makefile | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 4b09437..458b8c5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config
>
> prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>
> +toolchain: prepare dirs dependencies $(BASE_TARGETS)
> +
> world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
>
> -.PHONY: all world dirs clean distclean source outputmakefile \
> +.PHONY: all world toolchain dirs clean distclean source outputmakefile \
> legal-info legal-info-prepare legal-info-clean \
> $(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \
> $(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \
> @@ -697,8 +699,6 @@ ifeq ($(O),output)
> endif
> rm -rf $(CONFIG_DIR)/.config $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/.auto.deps
>
> -cross: $(BASE_TARGETS)
> -
> help:
> @echo 'Cleaning:'
> @echo ' clean - delete all files created by build'
> @@ -706,6 +706,7 @@ help:
> @echo
> @echo 'Build:'
> @echo ' all - make world'
> + @echo ' toolchain - build toolchain'
> @echo ' <package>-rebuild - force recompile <package>'
> @echo ' <package>-reconfigure - force reconfigure <package>'
> @echo
> --
> 1.8.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
This one looks good to me as well
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
Regards,
Markos
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
2012-12-21 10:36 ` [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain Fabio Porcedda
2012-12-21 12:00 ` Markos Chandras
@ 2012-12-21 12:42 ` Arnout Vandecappelle
2012-12-21 14:15 ` Fabio Porcedda
2012-12-22 12:45 ` Samuel Martin
2 siblings, 1 reply; 13+ messages in thread
From: Arnout Vandecappelle @ 2012-12-21 12:42 UTC (permalink / raw)
To: buildroot
On 21/12/12 11:36, Fabio Porcedda wrote:
> - Use a more descriptive name, the same of the "toolchain" directory.
> - Add missing dependencies to be able to successfully use the target
> right after the configuration.
> - Move to a better position.
> - Documentation it in the help target.
>
> Signed-off-by: Fabio Porcedda<fabio.porcedda@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(not tested but it's trivial enough)
Some additional suggestions (for additional patches):
- Document it in the manual.
- Add toolchain as a dependency to $(1)-configure for target-packages;
this makes it possible to remove it from the dependencies of 'world' and
brings us a step closer to top-level parallel build.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
2012-12-21 12:42 ` Arnout Vandecappelle
@ 2012-12-21 14:15 ` Fabio Porcedda
0 siblings, 0 replies; 13+ messages in thread
From: Fabio Porcedda @ 2012-12-21 14:15 UTC (permalink / raw)
To: buildroot
On Fri, Dec 21, 2012 at 1:42 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 21/12/12 11:36, Fabio Porcedda wrote:
>>
>> - Use a more descriptive name, the same of the "toolchain" directory.
>> - Add missing dependencies to be able to successfully use the target
>> right after the configuration.
>> - Move to a better position.
>> - Documentation it in the help target.
>>
>> Signed-off-by: Fabio Porcedda<fabio.porcedda@gmail.com>
>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> (not tested but it's trivial enough)
>
> Some additional suggestions (for additional patches):
>
> - Document it in the manual.
>
> - Add toolchain as a dependency to $(1)-configure for target-packages;
> this makes it possible to remove it from the dependencies of 'world' and
> brings us a step closer to top-level parallel build.
Thank for the review.
I like your suggestions.
I will work on that for additional patches.
Best regards
--
Fabio Porcedda
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
2012-12-21 10:36 ` [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain Fabio Porcedda
2012-12-21 12:00 ` Markos Chandras
2012-12-21 12:42 ` Arnout Vandecappelle
@ 2012-12-22 12:45 ` Samuel Martin
2012-12-22 13:45 ` Fabio Porcedda
2 siblings, 1 reply; 13+ messages in thread
From: Samuel Martin @ 2012-12-22 12:45 UTC (permalink / raw)
To: buildroot
Hi Fabio,
2012/12/21 Fabio Porcedda <fabio.porcedda@gmail.com>:
> - Use a more descriptive name, the same of the "toolchain" directory.
> - Add missing dependencies to be able to successfully use the target
> right after the configuration.
> - Move to a better position.
> - Documentation it in the help target.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
> Makefile | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 4b09437..458b8c5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config
>
> prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>
> +toolchain: prepare dirs dependencies $(BASE_TARGETS)
> +
> world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
Any reason to not make the world target depend on the toolchain and
$(TARGETS_ALL) targets?
IOW:
world: toolchain $(TARGETS_ALL)
Otherwise, it looks good to me with few words in the manual as already
mentioned by Arnout.
Regards,
--
Sam
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
2012-12-22 12:45 ` Samuel Martin
@ 2012-12-22 13:45 ` Fabio Porcedda
0 siblings, 0 replies; 13+ messages in thread
From: Fabio Porcedda @ 2012-12-22 13:45 UTC (permalink / raw)
To: buildroot
On Sat, Dec 22, 2012 at 1:45 PM, Samuel Martin <s.martin49@gmail.com> wrote:
> Hi Fabio,
>
> 2012/12/21 Fabio Porcedda <fabio.porcedda@gmail.com>:
>> - Use a more descriptive name, the same of the "toolchain" directory.
>> - Add missing dependencies to be able to successfully use the target
>> right after the configuration.
>> - Move to a better position.
>> - Documentation it in the help target.
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> ---
>> Makefile | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 4b09437..458b8c5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config
>>
>> prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>>
>> +toolchain: prepare dirs dependencies $(BASE_TARGETS)
>> +
>> world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
> Any reason to not make the world target depend on the toolchain and
> $(TARGETS_ALL) targets?
> IOW:
> world: toolchain $(TARGETS_ALL)
I've done exactly that in the following patch 2/2
> Otherwise, it looks good to me with few words in the manual as already
> mentioned by Arnout.
Thanks for the review
Best regards
--
Fabio Porcedda
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target
2012-12-21 10:36 [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
2012-12-21 10:36 ` [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain Fabio Porcedda
@ 2012-12-21 10:36 ` Fabio Porcedda
2012-12-21 11:57 ` Markos Chandras
2012-12-21 12:43 ` Arnout Vandecappelle
2013-01-07 12:29 ` [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
2 siblings, 2 replies; 13+ messages in thread
From: Fabio Porcedda @ 2012-12-21 10:36 UTC (permalink / raw)
To: buildroot
This is to remove redundancy and simplify the rule.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 458b8c5..296917e 100644
--- a/Makefile
+++ b/Makefile
@@ -379,7 +379,7 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf
toolchain: prepare dirs dependencies $(BASE_TARGETS)
-world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
+world: toolchain $(TARGETS_ALL)
.PHONY: all world toolchain dirs clean distclean source outputmakefile \
legal-info legal-info-prepare legal-info-clean \
--
1.8.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target
2012-12-21 10:36 ` [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target Fabio Porcedda
@ 2012-12-21 11:57 ` Markos Chandras
2012-12-21 12:43 ` Arnout Vandecappelle
1 sibling, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2012-12-21 11:57 UTC (permalink / raw)
To: buildroot
On 21 December 2012 10:36, Fabio Porcedda <fabio.porcedda@gmail.com> wrote:
> This is to remove redundancy and simplify the rule.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 458b8c5..296917e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -379,7 +379,7 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>
> toolchain: prepare dirs dependencies $(BASE_TARGETS)
>
> -world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
> +world: toolchain $(TARGETS_ALL)
>
> .PHONY: all world toolchain dirs clean distclean source outputmakefile \
> legal-info legal-info-prepare legal-info-clean \
> --
> 1.8.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Looks good to me
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
Regards,
Markos
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target
2012-12-21 10:36 ` [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target Fabio Porcedda
2012-12-21 11:57 ` Markos Chandras
@ 2012-12-21 12:43 ` Arnout Vandecappelle
1 sibling, 0 replies; 13+ messages in thread
From: Arnout Vandecappelle @ 2012-12-21 12:43 UTC (permalink / raw)
To: buildroot
On 21/12/12 11:36, Fabio Porcedda wrote:
> This is to remove redundancy and simplify the rule.
>
> Signed-off-by: Fabio Porcedda<fabio.porcedda@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(untested but trivial enough)
Regards,
Arnout
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 458b8c5..296917e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -379,7 +379,7 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>
> toolchain: prepare dirs dependencies $(BASE_TARGETS)
>
> -world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
> +world: toolchain $(TARGETS_ALL)
>
> .PHONY: all world toolchain dirs clean distclean source outputmakefile \
> legal-info legal-info-prepare legal-info-clean \
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target
2012-12-21 10:36 [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
2012-12-21 10:36 ` [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain Fabio Porcedda
2012-12-21 10:36 ` [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target Fabio Porcedda
@ 2013-01-07 12:29 ` Fabio Porcedda
2013-01-13 14:14 ` Samuel Martin
2 siblings, 1 reply; 13+ messages in thread
From: Fabio Porcedda @ 2013-01-07 12:29 UTC (permalink / raw)
To: buildroot
On Fri, Dec 21, 2012 at 11:36 AM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> Hi all,
> this patch set is to add a toolchain target to be able
> to build only the toolchain right after a defconfig or a clean.
>
> Best regards
>
> Fabio Porcedda (2):
> Makefile: rename cross target -> toolchain
> Makefile: use toolchain target in the world target
>
> Makefile | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> --
> 1.8.0
>
ping
--
Fabio Porcedda
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target
2013-01-07 12:29 ` [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
@ 2013-01-13 14:14 ` Samuel Martin
2013-01-13 21:28 ` Fabio Porcedda
0 siblings, 1 reply; 13+ messages in thread
From: Samuel Martin @ 2013-01-13 14:14 UTC (permalink / raw)
To: buildroot
Hi Fabio, all,
2013/1/7 Fabio Porcedda <fabio.porcedda@gmail.com>:
> On Fri, Dec 21, 2012 at 11:36 AM, Fabio Porcedda
> <fabio.porcedda@gmail.com> wrote:
>> Hi all,
>> this patch set is to add a toolchain target to be able
>> to build only the toolchain right after a defconfig or a clean.
>>
>> Best regards
>>
>> Fabio Porcedda (2):
>> Makefile: rename cross target -> toolchain
>> Makefile: use toolchain target in the world target
>>
Though it makes sense to me to squash these 2 patches into a single
one, you have my ack for the whole serie:
Acked-by: Samuel Martin <s.martin49@gmail.com>
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target
2013-01-13 14:14 ` Samuel Martin
@ 2013-01-13 21:28 ` Fabio Porcedda
0 siblings, 0 replies; 13+ messages in thread
From: Fabio Porcedda @ 2013-01-13 21:28 UTC (permalink / raw)
To: buildroot
On Sun, Jan 13, 2013 at 3:14 PM, Samuel Martin <s.martin49@gmail.com> wrote:
> Hi Fabio, all,
Hi Samuel,
> 2013/1/7 Fabio Porcedda <fabio.porcedda@gmail.com>:
>> On Fri, Dec 21, 2012 at 11:36 AM, Fabio Porcedda
>> <fabio.porcedda@gmail.com> wrote:
>>> Hi all,
>>> this patch set is to add a toolchain target to be able
>>> to build only the toolchain right after a defconfig or a clean.
>>>
>>> Best regards
>>>
>>> Fabio Porcedda (2):
>>> Makefile: rename cross target -> toolchain
>>> Makefile: use toolchain target in the world target
>>>
> Though it makes sense to me to squash these 2 patches into a single
> one, you have my ack for the whole serie:
> Acked-by: Samuel Martin <s.martin49@gmail.com>
Thanks for reviewing the patch set.
Now i think too that is better to squash them.
I will send a updated patch.
Best regards
--
Fabio Porcedda
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-01-13 21:28 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-21 10:36 [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
2012-12-21 10:36 ` [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain Fabio Porcedda
2012-12-21 12:00 ` Markos Chandras
2012-12-21 12:42 ` Arnout Vandecappelle
2012-12-21 14:15 ` Fabio Porcedda
2012-12-22 12:45 ` Samuel Martin
2012-12-22 13:45 ` Fabio Porcedda
2012-12-21 10:36 ` [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target Fabio Porcedda
2012-12-21 11:57 ` Markos Chandras
2012-12-21 12:43 ` Arnout Vandecappelle
2013-01-07 12:29 ` [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
2013-01-13 14:14 ` Samuel Martin
2013-01-13 21:28 ` Fabio Porcedda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox