From: "Stefan Fröberg" <stefan.froberg@petroprogram.com>
To: buildroot@busybox.net
Subject: [Buildroot] new <pkg>_CONFIG_FIXUP variable
Date: Wed, 09 Jan 2013 17:21:55 +0200 [thread overview]
Message-ID: <50ED8B13.7040701@petroprogram.com> (raw)
In-Reply-To: <20130109085412.3ec3662c@skate>
Hi Thomas
I tried that empty variable checking example you gave but it won't work.
If I remove DIVINE_CONFIG_FIXUP from divine.mk it will still spit the
"Fixing package configuration files" message
This is what it looks so far. Added your variable checking and removed
redundant '\ from sed line as Arnout said.
if test -n $($(PKG)_CONFIG_FIXUP) ; then \
$(call MESSAGE,"Fixing package configuration files") ;\
for file in $($(PKG)_CONFIG_FIXUP); do \
if [ -e $(STAGING_DIR)/usr/bin/$${file} ]; then \
$(SED) "s,^prefix=.*,prefix=$(STAGING_DIR)/usr,g" \
-e
"s,^exec_prefix=.*,exec_prefix=$(STAGING_DIR)/usr,g" \
$(STAGING_DIR)/usr/bin/$${file} ;\
fi \
done \
fi
$(Q)touch $@
And this is what happens:
test -z "/usr/bin" || /bin/mkdir -p
"/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr/bin"
test -z "/usr/lib/pkgconfig" || /bin/mkdir -p
"/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr/lib/pkgconfig"
/usr/bin/install -c 'divine-config'
'/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr/bin/divine-config'
/usr/bin/install -c -m 644 'divine.pc'
'/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr/lib/pkgconfig/divine.pc'
make[3]: Poistutaan hakemistosta
"/mnt/hee/new/buildroot-2012.08/output/build/divine-0.4.0"
make[2]: Poistutaan hakemistosta
"/mnt/hee/new/buildroot-2012.08/output/build/divine-0.4.0"
make[1]: Poistutaan hakemistosta
"/mnt/hee/new/buildroot-2012.08/output/build/divine-0.4.0"
for i in $(find
/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr/lib*
-name "*.la"); do cp -f $i $i~; /bin/sed -i -e "s:\(['=
]\)/usr:\\1/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr:g"
$i; done
if test -n ; then \
echo "^[[7m>>> divine 0.4.0 "Fixing package configuration files"^[[27m" ;\
for file in ; do \
if [ -e
/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr/bin/${file}
]; then \
/bin/sed -i -e
"s,^prefix=.*,prefix=/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr,g"
\
-e
"s,^exec_prefix=.*,exec_prefix=/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr,g"
\
/mnt/hee/new/buildroot-2012.08/output/host/usr/i586-unknown-linux-uclibc/sysroot/usr/bin/${file}
;\
fi \
done \
fi
^[[7m>>> divine 0.4.0 Fixing package configuration files^[[27m
^[[7m>>> divine 0.4.0 Installing to target^[[27m
PATH="/mnt/hee/new/buildroot-2012.08/output/host/bin:/mnt/hee/new/buildroot-2012.08/output/host/usr/bin:/mnt/hee/new/buildroot-2012.08/output/host/usr/sbin/:/root/perl5/bin:/root/perl5/bin:/root/perl5/bin:/usr/lib/ccache:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/root/bin"
PERLLIB="/mnt/hee/new/buildroot-2012.08/output/host/usr/lib/perl"
/usr/bin/make -j4 DESTDIR=/mnt/hee/new/buildroot-2012.08/output/target
install -C /mnt/hee/new/buildroot-2012.08/output/build/divine-0.4.0/
make[1]: Siirryt??n hakemistoon
"/mnt/hee/new/buildroot-2012.08/output/build/divine-0.4.0"
Making install in include
make[2]: Siirryt??n hakemistoon
"/mnt/hee/new/buildroot-2012.08/output/build/divine-0.4.0/include"
make[3]: Siirryt??n hakemistoon
"/mnt/hee/new/buildroot-2012.08/output/build/divine-0.4.0/include"
9.1.2013 9:54, Thomas Petazzoni kirjoitti:
> Dear Yann E. MORIN,
>
> On Wed, 9 Jan 2013 00:21:28 +0100, Yann E. MORIN wrote:
>
>> All in all, in my experience, that's roughly split in those four fourths.
>> Comunity work like here, and professional work alike.
> Agreed. In this specific case, I'd say about 5 lines of documentation
> are probably needed. I'm willing to provide the patch if needed.
>
> Thomas
That would be great!
Regards
Stefan
next prev parent reply other threads:[~2013-01-09 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 22:01 [Buildroot] new <pkg>_CONFIG_FIXUP variable Stefan Fröberg
2013-01-07 22:01 ` [Buildroot] [PATCH] new variable <pkg>_CONFIG_FIXUP Stefan Fröberg
2013-01-07 22:10 ` Thomas Petazzoni
2013-01-07 22:23 ` Stefan Fröberg
2013-01-07 22:42 ` Thomas Petazzoni
2013-01-08 20:53 ` Arnout Vandecappelle
2013-01-08 21:10 ` Thomas Petazzoni
2013-01-08 21:10 ` Arnout Vandecappelle
2013-01-07 22:10 ` [Buildroot] new <pkg>_CONFIG_FIXUP variable Yann E. MORIN
2013-01-07 22:27 ` Stefan Fröberg
2013-01-08 23:21 ` Yann E. MORIN
2013-01-09 7:54 ` Thomas Petazzoni
2013-01-09 15:21 ` Stefan Fröberg [this message]
2013-01-09 20:31 ` Arnout Vandecappelle
2013-01-10 0:16 ` Stefan Fröberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ED8B13.7040701@petroprogram.com \
--to=stefan.froberg@petroprogram.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox