Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] new <pkg>_CONFIG_FIXUP variable
Date: Wed, 09 Jan 2013 21:31:02 +0100	[thread overview]
Message-ID: <50EDD386.5030806@mind.be> (raw)
In-Reply-To: <50ED8B13.7040701@petroprogram.com>

On 01/09/13 16:21, Stefan Fr?berg wrote:
> Hi Thomas
>
> I tried that empty variable checking example you gave but it won't work.
> If I remove DIVINE_CONFIG_FIXUP from divine.mk it will still spit the
> "Fixing package configuration files" message
>
> This is what it looks so far. Added your variable checking and removed
> redundant '\ from sed line as Arnout said.
>
>      if test -n $($(PKG)_CONFIG_FIXUP) ; then \

  There should be quotes around "$($(PKG)_CONFIG_FIXUP)". test -n without 
arguments is true, test -n "" is false.

>          $(call MESSAGE,"Fixing package configuration files") ;\
>          for file in $($(PKG)_CONFIG_FIXUP); do \
>              if [ -e $(STAGING_DIR)/usr/bin/$${file} ]; then \

  This condition should be removed, as Thomas said.


  Regards,
  Arnout

>                  $(SED) "s,^prefix=.*,prefix=$(STAGING_DIR)/usr,g" \
>                      -e
> "s,^exec_prefix=.*,exec_prefix=$(STAGING_DIR)/usr,g" \
>                      $(STAGING_DIR)/usr/bin/$${file} ;\
>              fi \
>          done \
>      fi
>      $(Q)touch $@
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-01-09 20:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 22:01 [Buildroot] new <pkg>_CONFIG_FIXUP variable Stefan Fröberg
2013-01-07 22:01 ` [Buildroot] [PATCH] new variable <pkg>_CONFIG_FIXUP Stefan Fröberg
2013-01-07 22:10   ` Thomas Petazzoni
2013-01-07 22:23     ` Stefan Fröberg
2013-01-07 22:42       ` Thomas Petazzoni
2013-01-08 20:53         ` Arnout Vandecappelle
2013-01-08 21:10           ` Thomas Petazzoni
2013-01-08 21:10   ` Arnout Vandecappelle
2013-01-07 22:10 ` [Buildroot] new <pkg>_CONFIG_FIXUP variable Yann E. MORIN
2013-01-07 22:27   ` Stefan Fröberg
2013-01-08 23:21     ` Yann E. MORIN
2013-01-09  7:54       ` Thomas Petazzoni
2013-01-09 15:21         ` Stefan Fröberg
2013-01-09 20:31           ` Arnout Vandecappelle [this message]
2013-01-10  0:16             ` Stefan Fröberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EDD386.5030806@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox