Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 2/2] proxychains-ng: copy proxychains.conf to target dir
@ 2013-01-16 11:54 Stefan Fröberg
  2013-01-16 12:20 ` Peter Korsgaard
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Fröberg @ 2013-01-16 11:54 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
---
 package/proxychains-ng/proxychains-ng.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/proxychains-ng/proxychains-ng.mk b/package/proxychains-ng/proxychains-ng.mk
index 70d35b6..2d6e036 100644
--- a/package/proxychains-ng/proxychains-ng.mk
+++ b/package/proxychains-ng/proxychains-ng.mk
@@ -8,7 +8,7 @@ PROXYCHAINS_NG_SOURCE = proxychains-$(PROXYCHAINS_NG_VERSION).tar.bz2
 PROXYCHAINS_NG_SITE = http://downloads.sourceforge.net/project/proxychains-ng
 
 define PROXYCHAINS_NG_POST_INSTALL_TARGET
-	$(INSTALL) -m 755 $(@D)/src/proxychains.conf $(TARGET_DIR)/etc
+	$(INSTALL) -m 644 -D $(@D)/src/proxychains.conf $(TARGET_DIR)/etc/proxychains.conf
 endef
 
 PROXYCHAINS_NG_POST_INSTALL_TARGET_HOOKS += PROXYCHAINS_NG_POST_INSTALL_TARGET
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] proxychains-ng: copy proxychains.conf to target dir
  2013-01-16 11:54 [Buildroot] [PATCH 2/2] proxychains-ng: copy proxychains.conf to target dir Stefan Fröberg
@ 2013-01-16 12:20 ` Peter Korsgaard
  2013-01-16 12:24   ` Peter Korsgaard
  2013-01-16 12:27   ` Stefan Fröberg
  0 siblings, 2 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-01-16 12:20 UTC (permalink / raw)
  To: buildroot

>>>>> "Stefan" == Stefan Fr?berg <stefan.froberg@petroprogram.com> writes:

Committed, thanks.

2 nitpicks: It's a bit confusing to number a single patch as 2/2 - v2 of
a patch is normally called PATCHv2 or similar.

Secondly, we try to keep lines below 80 chars, so I've wrapped the
install line.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] proxychains-ng: copy proxychains.conf to target dir
  2013-01-16 12:20 ` Peter Korsgaard
@ 2013-01-16 12:24   ` Peter Korsgaard
  2013-01-16 12:27   ` Stefan Fröberg
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-01-16 12:24 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <jacmet@uclibc.org> writes:

>>>>> "Stefan" == Stefan Fr?berg <stefan.froberg@petroprogram.com> writes:
 Peter> Committed, thanks.

 Peter> 2 nitpicks: It's a bit confusing to number a single patch as 2/2 - v2 of
 Peter> a patch is normally called PATCHv2 or similar.

 Peter> Secondly, we try to keep lines below 80 chars, so I've wrapped the
 Peter> install line.

Ups, got sent too soon - You also sent this patch as a change relative
to the previous patch, but I haven't applied your earlier patch so you
should send it relative to trunk instead.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] proxychains-ng: copy proxychains.conf to target dir
  2013-01-16 12:20 ` Peter Korsgaard
  2013-01-16 12:24   ` Peter Korsgaard
@ 2013-01-16 12:27   ` Stefan Fröberg
  2013-01-16 12:33     ` Peter Korsgaard
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Fröberg @ 2013-01-16 12:27 UTC (permalink / raw)
  To: buildroot

16.1.2013 14:20, Peter Korsgaard kirjoitti:
>>>>>> "Stefan" == Stefan Fr?berg <stefan.froberg@petroprogram.com> writes:
> Committed, thanks.
>
> 2 nitpicks: It's a bit confusing to number a single patch as 2/2 - v2 of
> a patch is normally called PATCHv2 or similar.

Ok, sorry about that too.

> Secondly, we try to keep lines below 80 chars, so I've wrapped the
> install line.
>

Okay.
I use nano editor for doing my coding stuff because it's fast & simple.
How can I force it to automatically wrap in 80 chars ?

Thanks!

Stefan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] proxychains-ng: copy proxychains.conf to target dir
  2013-01-16 12:27   ` Stefan Fröberg
@ 2013-01-16 12:33     ` Peter Korsgaard
  0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-01-16 12:33 UTC (permalink / raw)
  To: buildroot

>>>>> "Stefan" == Stefan Fr?berg <stefan.froberg@petroprogram.com> writes:

Hi,

 Stefan> Okay.
 Stefan> I use nano editor for doing my coding stuff because it's fast &
 Stefan> simple.  How can I force it to automatically wrap in 80 chars ?

Sorry, I don't use nano so I don't know.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-01-16 12:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 11:54 [Buildroot] [PATCH 2/2] proxychains-ng: copy proxychains.conf to target dir Stefan Fröberg
2013-01-16 12:20 ` Peter Korsgaard
2013-01-16 12:24   ` Peter Korsgaard
2013-01-16 12:27   ` Stefan Fröberg
2013-01-16 12:33     ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox