[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Thierry Bultel]

Hi,

The generated "startx" has the host path for mcookie:



----------
    esac

     authdisplay=${display:-:0}

 
mcookie=`/nous/BASYSTEMES/Buildroot/output.imx6neon/host/usr/bin/mcookie`



     if test x"$mcookie" = x; then

--------------------------


... and because of that, the X server does not start on target.

It should be "/usr/bin/mcookie"



Regards
Thierry

[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Peter Korsgaard]

>>>>> "Thierry" == Thierry Bultel <thierry.bultel@wanadoo.fr> writes:

 Thierry> Hi,
 Thierry> The generated "startx" has the host path for mcookie:



 Thierry> ----------
 Thierry>    esac

 Thierry>     authdisplay=${display:-:0}


 Thierry> mcookie=`/nous/BASYSTEMES/Buildroot/output.imx6neon/host/usr/bin/mcookie`

What buildroot version are you using? It seems to be correct here with
current git:

grep bin/mcookie output/target/usr/bin/startx
    mcookie=`/usr/bin/mcookie`

-- 
Bye, Peter Korsgaard

[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Thierry Bultel]

Hi Peter,

I can reproduce it with the latest release:

thierry at thierry-desktop:/nous/BASYSTEMES/Buildroot2012.11/buildroot-2012.11$ 
cat output/target/usr/bin/startx | grep mcook
     mcookie=`/nous/BASYSTEMES/Buildroot2012.11/buildroot-2012.11/output

However, an important clue is that is has work once.
My build from scratch was OK. Then I have changed my .config, adding 
some packages, and then it was broken.

I am trying to reverse it step by step to understand what has happened.

Regards
Thierry

Le 04/12/2012 20:37, Peter Korsgaard a ?crit :
>>>>>> "Thierry" == Thierry Bultel <thierry.bultel@wanadoo.fr> writes:
>
>   Thierry> Hi,
>   Thierry> The generated "startx" has the host path for mcookie:
>
>
>
>   Thierry> ----------
>   Thierry>    esac
>
>   Thierry>     authdisplay=${display:-:0}
>
>
>   Thierry> mcookie=`/nous/BASYSTEMES/Buildroot/output.imx6neon/host/usr/bin/mcookie`
>
> What buildroot version are you using? It seems to be correct here with
> current git:
>
> grep bin/mcookie output/target/usr/bin/startx
>      mcookie=`/usr/bin/mcookie`
>

[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Thierry Bultel]

Hi,

Sorry for the long delay

The  bug is reproducible with latest release,
and I finally found out why.

The issue is that in xapp_xinit, 'configure' checks for 'mcookie', and 
the first time, founds it ... on the host side, ie the 
"/usr/bin/mcookie" of Ubuntu for instance. This is the path that is 
substituted in startx.

When rebuilding the xapp_xinit package, "mcookie" has been built by 
buildroot, in the xorg_server package. Thus "configure" finds it in our 
build directory, ie output/host/usr/bin/mcookie, which is not a target path.

A quick fix (not meaning it is the cleanest way) is simply to add

XAPP_XINIT_CONF_OPT += MCOOKIE=/usr/bin/mcookie

in xapp_xinit.mk

Thierry


Le 04/12/2012 20:37, Peter Korsgaard a ?crit :
>>>>>> "Thierry" == Thierry Bultel <thierry.bultel@wanadoo.fr> writes:
>
>   Thierry> Hi,
>   Thierry> The generated "startx" has the host path for mcookie:
>
>
>
>   Thierry> ----------
>   Thierry>    esac
>
>   Thierry>     authdisplay=${display:-:0}
>
>
>   Thierry> mcookie=`/nous/BASYSTEMES/Buildroot/output.imx6neon/host/usr/bin/mcookie`
>
> What buildroot version are you using? It seems to be correct here with
> current git:
>
> grep bin/mcookie output/target/usr/bin/startx
>      mcookie=`/usr/bin/mcookie`
>

[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Arnout Vandecappelle]

On 17/01/13 17:06, Thierry Bultel wrote:
> Hi,
>
> Sorry for the long delay
>
> The  bug is reproducible with latest release,
> and I finally found out why.
>
> The issue is that in xapp_xinit, 'configure' checks for 'mcookie', and
> the first time, founds it ... on the host side, ie the "/usr/bin/mcookie"
> of Ubuntu for instance. This is the path that is substituted in startx.
>
> When rebuilding the xapp_xinit package, "mcookie" has been built by
> buildroot, in the xorg_server package. Thus "configure" finds it in our
> build directory, ie output/host/usr/bin/mcookie, which is not a target path.
>
> A quick fix (not meaning it is the cleanest way) is simply to add
>
> XAPP_XINIT_CONF_OPT += MCOOKIE=/usr/bin/mcookie
>
> in xapp_xinit.mk

  That's a perfectly clean solution - on condition that mcookie is indeed 
installed on the target. I guess the option should therefore be in an

ifeq ($(BR2_PACKAGE_UTIL_LINUX),y)
XAPP_XINIT_CONF_OPT += MCOOKIE=/usr/bin/mcookie
endif

  Care to make a patch?

  Regards,
  Arnout

>
> Thierry
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Thomas Petazzoni]

Dear Arnout Vandecappelle,

On Sat, 19 Jan 2013 14:27:58 +0100, Arnout Vandecappelle wrote:

>   That's a perfectly clean solution - on condition that mcookie is indeed 
> installed on the target. I guess the option should therefore be in an
> 
> ifeq ($(BR2_PACKAGE_UTIL_LINUX),y)
> XAPP_XINIT_CONF_OPT += MCOOKIE=/usr/bin/mcookie
> endif
> 
>   Care to make a patch?

We also have a mcookie package in package/x11r7/mcookie/. I guess the
purpose was to avoid building the entire util-linux stuff just to get
mcookie. Maybe we need to decide whether we want to use one mcookie
solution (the standalone package) or the other (mcookie built as part
of util-linux), and stick to it. No?

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Arnout Vandecappelle]

On 19/01/13 14:42, Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle,
>
> On Sat, 19 Jan 2013 14:27:58 +0100, Arnout Vandecappelle wrote:
>
>>    That's a perfectly clean solution - on condition that mcookie is indeed
>> installed on the target. I guess the option should therefore be in an
>>
>> ifeq ($(BR2_PACKAGE_UTIL_LINUX),y)
>> XAPP_XINIT_CONF_OPT += MCOOKIE=/usr/bin/mcookie
>> endif
>>
>>    Care to make a patch?
>
> We also have a mcookie package in package/x11r7/mcookie/. I guess the
> purpose was to avoid building the entire util-linux stuff just to get
> mcookie. Maybe we need to decide whether we want to use one mcookie
> solution (the standalone package) or the other (mcookie built as part
> of util-linux), and stick to it. No?

  That would indeed be better... In my allpackage build, the mcookie that 
ends up in target/usr/bin is the one from util-linux...

  Since mcookie is not in busybox, it does make sense to have a separate 
source for it. However, it's only used by xserver and at that point the 
additional size of util-linux isn't really an issue anymore...

  So I think we can safely remove mcookie.

  Or leave things as is, even.


  BTW, shouldn't xapp_xinit depend on XORG_SERVER? xinit tries to start 
an X server... If xapp_xinit depens on XORG_SERVER then the condition I 
proposed is no longer necessary, because MCOOKIE will be selected.

  Regards,
  Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] xapp_init: bad substitution of mcookie path in startx

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 Arnout>  BTW, shouldn't xapp_xinit depend on XORG_SERVER? xinit tries
 Arnout> to start an X server... If xapp_xinit depens on XORG_SERVER
 Arnout> then the condition I proposed is no longer necessary, because
 Arnout> MCOOKIE will be selected.

That indeed seems sensible. Care to send a patch?

-- 
Bye, Peter Korsgaard