From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/6] toolchain/crosstool-ng: sprinkle with some calls to MESSAGE
Date: Sun, 20 Jan 2013 14:56:14 +0100 [thread overview]
Message-ID: <50FBF77E.3040106@mind.be> (raw)
In-Reply-To: <f69a7b3d3f92b370d81f7f99e03771eebdb7c134.1358379198.git.yann.morin.1998@free.fr>
On 01/17/13 00:41, Yann E. MORIN wrote:
> Thus, the failing step can be easily extracted by autobuilders,
> to ease with post-mortem analysis.
>
> Signed-off-by: "Yann E. MORIN"<yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> toolchain/toolchain-crosstool-ng/crosstool-ng.mk | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> index c09f732..be14e08 100644
> --- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> +++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> @@ -68,9 +68,9 @@ $(STAMP_DIR)/ct-ng-toolchain-installed: $(STAMP_DIR)/ct-ng-toolchain-built
> $(Q)mkdir -p $(TARGET_DIR)/lib
> $(Q)CTNG_TUPLE="$$( $(call ctng,show-tuple 2>&1) )"; \
> CTNG_SYSROOT="$(HOST_DIR)/usr/$${CTNG_TUPLE}/sysroot"; \
> + $(call MESSAGE,"Copy external toolchain libraries to target..."); \
You could correct this to "Copying".
> echo "CTNG_TUPLE='$${CTNG_TUPLE}'"; \
> echo "CTNG_SYSROOT='$${CTNG_SYSROOT}'"; \
What are these two echoes doing there? git blame points to you, Yann...
> - echo "Copy external toolchain libraries to target..."; \
> for libs in $(CTNG_LIBS_LIB); do \
> $(call copy_toolchain_lib_root,$${CTNG_SYSROOT},,lib,$$libs,/lib); \
> done; \
> @@ -85,6 +85,7 @@ $(STAMP_DIR)/ct-ng-toolchain-installed: $(STAMP_DIR)/ct-ng-toolchain-built
> # depending on the selected C library. Those deps are added later
>
> $(STAMP_DIR)/ct-ng-toolchain-built: $(CTNG_DIR)/.config
> + $(Q)$(call MESSAGE,"Building the toolchain")
Just to make things crystal clear when it appears in autobuilder results:
"Building the crosstool-ng toolchain"
Regards,
Arnout
> $(Q)$(call ctng,build.$(PARALLEL_JOBS))
> $(Q)printf "\n"
> $(Q)touch $@
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-01-20 13:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 23:41 [Buildroot] [pull request] Pull request for branch yem-instrument-build Yann E. MORIN
2013-01-16 23:41 ` [Buildroot] [PATCH 1/6] pkg-infra: log current message Yann E. MORIN
2013-01-17 15:22 ` Markos Chandras
2013-01-20 13:49 ` Arnout Vandecappelle
2013-01-20 14:10 ` Yann E. MORIN
2013-01-20 14:38 ` Thomas Petazzoni
2013-01-20 14:59 ` Yann E. MORIN
2013-01-16 23:41 ` [Buildroot] [PATCH 2/6] toolchain/external: sprinkle with some calls to MESSAGE Yann E. MORIN
2013-01-20 13:51 ` Arnout Vandecappelle
2013-01-16 23:41 ` [Buildroot] [PATCH 3/6] toolchain/crosstool-ng: " Yann E. MORIN
2013-01-20 13:56 ` Arnout Vandecappelle [this message]
2013-01-20 14:27 ` Yann E. MORIN
2013-01-16 23:41 ` [Buildroot] [PATCH 4/6] toolchain/gcc: " Yann E. MORIN
2013-01-18 16:13 ` Markos Chandras
2013-01-20 14:01 ` Arnout Vandecappelle
2013-01-16 23:41 ` [Buildroot] [PATCH 5/6] toolchain/kernel-headers: " Yann E. MORIN
2013-01-18 16:16 ` Markos Chandras
2013-01-20 14:04 ` Arnout Vandecappelle
2013-01-16 23:41 ` [Buildroot] [PATCH 6/6] toolchain/uClibc: " Yann E. MORIN
2013-01-18 16:12 ` Markos Chandras
2013-01-20 14:02 ` [Buildroot] [pull request] Pull request for branch yem-instrument-build Arnout Vandecappelle
2013-01-20 14:03 ` [Buildroot] [PATCH] fs/common.mk: delay evaluation of variables Arnout Vandecappelle
2013-01-20 19:59 ` Peter Korsgaard
2013-01-20 14:10 ` [Buildroot] [pull request] Pull request for branch yem-instrument-build Thomas Petazzoni
2013-01-20 14:22 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FBF77E.3040106@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox