From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fs/common.mk: delay evaluation of variables.
Date: Sun, 20 Jan 2013 20:59:15 +0100 [thread overview]
Message-ID: <87fw1veics.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1358690593-8163-1-git-send-email-arnout@mind.be> (Arnout Vandecappelle's message of "Sun, 20 Jan 2013 15:03:13 +0100")
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Arnout> This makes things easier to understand and more consistent with
Arnout> the pkg-infra. For example, it removes the need for '$$@' in
Arnout> the CMD variables of fs/*/*.mk.
Arnout> It also makes it possible to update the variables later,
Arnout> e.g. in the package override file.
Arnout> It also makes sure that the date will be recorded correctly in
Arnout> Yann E. Morin's patch that logs the MESSAGE macros to a file.
Arnout> The fs/*/*.mk must be updated as well because the '$@'
Arnout> shouldn't be quoted anymore in the CMD variables or the hooks.
Arnout> The $(eval ...) for the dependencies is redundant, because the
Arnout> $(ROOTFS_TARGET) variable is already eval'd. Note that it is
Arnout> only redundant if the evaluation of the uses of the variable is
Arnout> also delayed.
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-01-20 19:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 23:41 [Buildroot] [pull request] Pull request for branch yem-instrument-build Yann E. MORIN
2013-01-16 23:41 ` [Buildroot] [PATCH 1/6] pkg-infra: log current message Yann E. MORIN
2013-01-17 15:22 ` Markos Chandras
2013-01-20 13:49 ` Arnout Vandecappelle
2013-01-20 14:10 ` Yann E. MORIN
2013-01-20 14:38 ` Thomas Petazzoni
2013-01-20 14:59 ` Yann E. MORIN
2013-01-16 23:41 ` [Buildroot] [PATCH 2/6] toolchain/external: sprinkle with some calls to MESSAGE Yann E. MORIN
2013-01-20 13:51 ` Arnout Vandecappelle
2013-01-16 23:41 ` [Buildroot] [PATCH 3/6] toolchain/crosstool-ng: " Yann E. MORIN
2013-01-20 13:56 ` Arnout Vandecappelle
2013-01-20 14:27 ` Yann E. MORIN
2013-01-16 23:41 ` [Buildroot] [PATCH 4/6] toolchain/gcc: " Yann E. MORIN
2013-01-18 16:13 ` Markos Chandras
2013-01-20 14:01 ` Arnout Vandecappelle
2013-01-16 23:41 ` [Buildroot] [PATCH 5/6] toolchain/kernel-headers: " Yann E. MORIN
2013-01-18 16:16 ` Markos Chandras
2013-01-20 14:04 ` Arnout Vandecappelle
2013-01-16 23:41 ` [Buildroot] [PATCH 6/6] toolchain/uClibc: " Yann E. MORIN
2013-01-18 16:12 ` Markos Chandras
2013-01-20 14:02 ` [Buildroot] [pull request] Pull request for branch yem-instrument-build Arnout Vandecappelle
2013-01-20 14:03 ` [Buildroot] [PATCH] fs/common.mk: delay evaluation of variables Arnout Vandecappelle
2013-01-20 19:59 ` Peter Korsgaard [this message]
2013-01-20 14:10 ` [Buildroot] [pull request] Pull request for branch yem-instrument-build Thomas Petazzoni
2013-01-20 14:22 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw1veics.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox