* [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server
@ 2013-01-20 10:31 Arnout Vandecappelle
2013-01-20 10:31 ` [Buildroot] [PATCH 2/2] xapp_xinit depends on mcookie, not xserver_xorg-server Arnout Vandecappelle
2013-01-20 20:22 ` [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-01-20 10:31 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/x11r7/xapp_xinit/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
index 9ac2817..30981c3 100644
--- a/package/x11r7/xapp_xinit/Config.in
+++ b/package/x11r7/xapp_xinit/Config.in
@@ -1,5 +1,7 @@
config BR2_PACKAGE_XAPP_XINIT
bool "xinit"
+ # Runtime dependency: can't start an X server unless there is one
+ depends on BR2_PACKAGE_XSERVER_XORG_SERVER
select BR2_PACKAGE_XAPP_XAUTH
select BR2_PACKAGE_XLIB_LIBX11
help
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] xapp_xinit depends on mcookie, not xserver_xorg-server
2013-01-20 10:31 [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server Arnout Vandecappelle
@ 2013-01-20 10:31 ` Arnout Vandecappelle
2013-01-20 20:22 ` [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-01-20 10:31 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
mcookie is not actually used by the Xorg server; it is used by xinit to
generate a xauth cookie before starting the server.
Verified with 'ack-grep -a mcookie build/x*' in an output directory with all
packages selected. The only other package that matches is x11vnc: it does a
runtime check for mcookie and falls back on /dev/random if it's missing.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/x11r7/xapp_xinit/Config.in | 2 ++
package/x11r7/xserver_xorg-server/Config.in | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
index 30981c3..aede5d9 100644
--- a/package/x11r7/xapp_xinit/Config.in
+++ b/package/x11r7/xapp_xinit/Config.in
@@ -2,6 +2,8 @@ config BR2_PACKAGE_XAPP_XINIT
bool "xinit"
# Runtime dependency: can't start an X server unless there is one
depends on BR2_PACKAGE_XSERVER_XORG_SERVER
+ # Runtime dependency; mcookie is also in util-linux
+ select BR2_PACKAGE_MCOOKIE if !BR2_PACKAGE_UTIL_LINUX
select BR2_PACKAGE_XAPP_XAUTH
select BR2_PACKAGE_XLIB_LIBX11
help
diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
index 5b60398..21b0700 100644
--- a/package/x11r7/xserver_xorg-server/Config.in
+++ b/package/x11r7/xserver_xorg-server/Config.in
@@ -1,7 +1,6 @@
config BR2_PACKAGE_XSERVER_XORG_SERVER
bool "xorg-server"
select BR2_PACKAGE_LIBDRM if BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR
- select BR2_PACKAGE_MCOOKIE
# We need a SHA1 implementation. If either openssl or
# libgcrypt are already part of the build, we'll use one of
# them, otherwise, use the small libsha1 library.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server
2013-01-20 10:31 [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server Arnout Vandecappelle
2013-01-20 10:31 ` [Buildroot] [PATCH 2/2] xapp_xinit depends on mcookie, not xserver_xorg-server Arnout Vandecappelle
@ 2013-01-20 20:22 ` Peter Korsgaard
2013-01-21 7:14 ` Arnout Vandecappelle
1 sibling, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2013-01-20 20:22 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Arnout> ---
Arnout> package/x11r7/xapp_xinit/Config.in | 2 ++
Arnout> 1 file changed, 2 insertions(+)
Arnout> diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
Arnout> index 9ac2817..30981c3 100644
Arnout> --- a/package/x11r7/xapp_xinit/Config.in
Arnout> +++ b/package/x11r7/xapp_xinit/Config.in
Arnout> @@ -1,5 +1,7 @@
Arnout> config BR2_PACKAGE_XAPP_XINIT
Arnout> bool "xinit"
Arnout> + # Runtime dependency: can't start an X server unless there is one
Arnout> + depends on BR2_PACKAGE_XSERVER_XORG_SERVER
XAPP_XDM selects XINIT, so I also added the dependency here and
committed both patches, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server
2013-01-20 20:22 ` [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server Peter Korsgaard
@ 2013-01-21 7:14 ` Arnout Vandecappelle
0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-01-21 7:14 UTC (permalink / raw)
To: buildroot
On 01/20/13 21:22, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be> writes:
>
> Arnout> From: "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>
> Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
> Arnout> ---
> Arnout> package/x11r7/xapp_xinit/Config.in | 2 ++
> Arnout> 1 file changed, 2 insertions(+)
>
> Arnout> diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
> Arnout> index 9ac2817..30981c3 100644
> Arnout> --- a/package/x11r7/xapp_xinit/Config.in
> Arnout> +++ b/package/x11r7/xapp_xinit/Config.in
> Arnout> @@ -1,5 +1,7 @@
> Arnout> config BR2_PACKAGE_XAPP_XINIT
> Arnout> bool "xinit"
> Arnout> + # Runtime dependency: can't start an X server unless there is one
> Arnout> + depends on BR2_PACKAGE_XSERVER_XORG_SERVER
>
> XAPP_XDM selects XINIT, so I also added the dependency here and
> committed both patches, thanks.
And xdm obviously doesn't make much sense without an X server...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-21 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-20 10:31 [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server Arnout Vandecappelle
2013-01-20 10:31 ` [Buildroot] [PATCH 2/2] xapp_xinit depends on mcookie, not xserver_xorg-server Arnout Vandecappelle
2013-01-20 20:22 ` [Buildroot] [PATCH 1/2] xapp_xinit: only makes sense if there is an X server Peter Korsgaard
2013-01-21 7:14 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox