Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files
Date: Tue, 29 Jan 2013 18:50:41 +0100	[thread overview]
Message-ID: <51080BF1.3020009@mind.be> (raw)
In-Reply-To: <CAHXCMMK69aYc=Hebivu1wPJOn0CXMn9SHQCA=-G4_JAdaw5Sjg@mail.gmail.com>

On 29/01/13 08:14, Samuel Martin wrote:
>> >+                       $(SED)  "s,^\(exec_\)\?prefix=.*,\1prefix=$(STAGING_DIR)/usr,g" \
>> >+                               -e "s,-I/usr/,-I\${prefix}/usr/,g" \
>> >+                               -e "s,-L/usr/,-L\${exec_prefix}/usr/,g" \
> Well, just fixing the (exec_)?prefix may not be enough in some case:
> Some quick grepping in the package directory will show that includedir
> and libdir should be fixed as well.

  I wouldn't want to do too much in the generic fixup script.

  In fact, the -L substitution is not necessarily correct - some config 
scripts may not define ${exec_prefix}. I'd rather use $(STAGING_DIR) 
explicitly.

  BTW, Stefan: the $ should have been quoted ($$).

  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-01-29 17:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28 19:52 [Buildroot] [PATCH v3] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files Stefan Fröberg
2013-01-29  7:14 ` Samuel Martin
2013-01-29 17:50   ` Arnout Vandecappelle [this message]
2013-01-30 12:31     ` Stefan Fröberg
2013-01-30 12:33       ` Stefan Fröberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51080BF1.3020009@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox