From: "Stefan Fröberg" <stefan.froberg@petroprogram.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files
Date: Wed, 30 Jan 2013 14:31:15 +0200 [thread overview]
Message-ID: <51091293.1010108@petroprogram.com> (raw)
In-Reply-To: <51080BF1.3020009@mind.be>
29.1.2013 19:50, Arnout Vandecappelle kirjoitti:
> On 29/01/13 08:14, Samuel Martin wrote:
>>> >+ $(SED)
>>> "s,^\(exec_\)\?prefix=.*,\1prefix=$(STAGING_DIR)/usr,g" \
>>> >+ -e "s,-I/usr/,-I\${prefix}/usr/,g" \
>>> >+ -e
>>> "s,-L/usr/,-L\${exec_prefix}/usr/,g" \
>> Well, just fixing the (exec_)?prefix may not be enough in some case:
>> Some quick grepping in the package directory will show that includedir
>> and libdir should be fixed as well.
>
> I wouldn't want to do too much in the generic fixup script.
>
> In fact, the -L substitution is not necessarily correct - some config
> scripts may not define ${exec_prefix}. I'd rather use $(STAGING_DIR)
> explicitly.
>
> BTW, Stefan: the $ should have been quoted ($$).
>
> Regards,
> Arnout
>
So like this ?
-e 's,-I/usr/,-I$$(STAGING_DIR)/usr/,g" \
-e 's,-L/usr/,-L$$(STAGING_DIR)/usr/,g" \
I make one final v4 of that for FOSDEM then and that's that.
Regards
Stefan
next prev parent reply other threads:[~2013-01-30 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 19:52 [Buildroot] [PATCH v3] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files Stefan Fröberg
2013-01-29 7:14 ` Samuel Martin
2013-01-29 17:50 ` Arnout Vandecappelle
2013-01-30 12:31 ` Stefan Fröberg [this message]
2013-01-30 12:33 ` Stefan Fröberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51091293.1010108@petroprogram.com \
--to=stefan.froberg@petroprogram.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox