Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] crda: new package
@ 2013-02-19 12:46 Dimitrios Siganos
  2013-02-28  5:54 ` Baruch Siach
  0 siblings, 1 reply; 2+ messages in thread
From: Dimitrios Siganos @ 2013-02-19 12:46 UTC (permalink / raw)
  To: buildroot

Improved patch that supersedes the previous one I sent. In this one,
manpages are removed only if BR2_HAVE_DOCUMENTATION != y.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-crda-new-package.patch
Type: text/x-patch
Size: 6210 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130219/ea67d0f3/attachment.bin>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2] crda: new package
  2013-02-19 12:46 [Buildroot] [PATCH v2] crda: new package Dimitrios Siganos
@ 2013-02-28  5:54 ` Baruch Siach
  0 siblings, 0 replies; 2+ messages in thread
From: Baruch Siach @ 2013-02-28  5:54 UTC (permalink / raw)
  To: buildroot

Hi Dimitrios,

On Tue, Feb 19, 2013 at 12:46:06PM +0000, Dimitrios Siganos wrote:
> From 23f7a55f8c06a098c8d6bc8f56021f9954159419 Mon Sep 17 00:00:00 2001
> From: Dimitrios Siganos <dimitris@siganos.org>
> Date: Fri, 15 Feb 2013 11:52:25 +0000
> Subject: [PATCH 02/11] crda: new package
> 
> 
> Signed-off-by: Dimitrios Siganos <dimitris@siganos.org>
> ---
>  package/Config.in          |    1 +
>  package/crda/Config.in     |   12 ++++++++++
>  package/crda/crda.mk       |   32 ++++++++++++++++++++++++++
>  package/crda/keys-gcrypt.c |   53 ++++++++++++++++++++++++++++++++++++++++++++
>  package/crda/keys-ssl.c    |   38 +++++++++++++++++++++++++++++++

Please explain what these two .c files are, and why they are needed. Adding 
them as patches may be preferable, since you won't have to copy them 
explicitly.

[...]

> +CRDA_DEPENDENCIES = host-pkgconf libnl libgcrypt wireless-regdb

You need to add a 'select' for libnl, libgcrypt, and wireless-regdb in your 
Config.in.

> +CRDA_LICENSE := ISC
> +CRDA_LICENSE_FILES := LICENSE

Please use '=' only.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-28  5:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 12:46 [Buildroot] [PATCH v2] crda: new package Dimitrios Siganos
2013-02-28  5:54 ` Baruch Siach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox