* [Buildroot] [PATCH] new package: libwnck
@ 2013-02-21 18:06 Stefan Fröberg
2013-02-21 21:30 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Fröberg @ 2013-02-21 18:06 UTC (permalink / raw)
To: buildroot
libwnck
A window navigation construction kit
Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
---
package/Config.in | 1 +
package/libwnck/Config.in | 13 +++++++++++++
package/libwnck/libwnck.mk | 19 +++++++++++++++++++
3 files changed, 33 insertions(+), 0 deletions(-)
create mode 100644 package/libwnck/Config.in
create mode 100644 package/libwnck/libwnck.mk
diff --git a/package/Config.in b/package/Config.in
index 8588951..51e92a2 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -433,6 +433,7 @@ source "package/libraw/Config.in"
source "package/librsvg/Config.in"
source "package/libsvgtiny/Config.in"
source "package/libungif/Config.in"
+source "package/libwnck/Config.in"
source "package/opencv/Config.in"
source "package/pango/Config.in"
source "package/pixman/Config.in"
diff --git a/package/libwnck/Config.in b/package/libwnck/Config.in
new file mode 100644
index 0000000..42ca4fc
--- /dev/null
+++ b/package/libwnck/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LIBWNCK
+ bool "libwnck"
+ select BR2_PACKAGE_LIBGTK2
+ select BR2_PACKAGE_STARTUP_NOTIFICATION
+ help
+ libwnck is the Window Navigator Construction Kit, a library for use
+ in writing pagers, tasklists, and more generally applications that
+ are dealing with window management.
+ It tries hard to respect the Extended Window Manager Hints
+ specification (EMWH).
+
+ http://www.gnome.org
+
diff --git a/package/libwnck/libwnck.mk b/package/libwnck/libwnck.mk
new file mode 100644
index 0000000..54d1866
--- /dev/null
+++ b/package/libwnck/libwnck.mk
@@ -0,0 +1,19 @@
+#############################################################
+#
+# libwnck
+#
+#############################################################
+
+LIBWNCK_MAJOR_VERSION = 2.30
+LIBWNCK_MINOR_VERSION = 7
+LIBWNCK_VERSION = $(LIBWNCK_MAJOR_VERSION).$(LIBWNCK_MINOR_VERSION)
+LIBWNCK_SOURCE = libwnck-$(LIBWNCK_VERSION).tar.xz
+LIBWNCK_SITE = http://ftp.gnome.org/pub/gnome/sources/libwnck/$(LIBWNCK_MAJOR_VERSION)
+LIBWNCK_INSTALL_STAGING = YES
+LIBWNCK_LICENSE = LGPLv2.1+
+LIBWNCK_LICENSE_FILES = COPYING
+LIBWNCK_DEPENDENCIES = libgtk2 startup-notification
+
+$(eval $(autotools-package))
+
+
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] new package: libwnck
2013-02-21 18:06 [Buildroot] [PATCH] new package: libwnck Stefan Fröberg
@ 2013-02-21 21:30 ` Yann E. MORIN
2013-02-23 9:20 ` Arnout Vandecappelle
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2013-02-21 21:30 UTC (permalink / raw)
To: buildroot
Stefan, All,
On Thursday 21 February 2013 Stefan Fr?berg wrote:
> libwnck
^^^
Useless line.
> A window navigation construction kit
>
> Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
[--SNIP--]
> diff --git a/package/libwnck/Config.in b/package/libwnck/Config.in
> new file mode 100644
> index 0000000..42ca4fc
> --- /dev/null
> +++ b/package/libwnck/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LIBWNCK
> + bool "libwnck"
> + select BR2_PACKAGE_LIBGTK2
You have to inherit the dependencies for libgtk2:
depends on BR2_PACKAGE_XORG7||BR2_PACKAGE_DIRECTFB # libgtk2
depends on BR2_USE_WCHAR # glib2
depends on BR2_INSTALL_LIBSTDCPP # pango
But I'd prefer it it were a 'depends on BR2_PACKAGE_LIBGTK2' rather than
a 'select'.
And add a comment anyway to state why libwnck is not available.
> + select BR2_PACKAGE_STARTUP_NOTIFICATION
Ditto, you need to forward startyup-notification's dependencies.
Regards,
Yann E. MORIN, getting a bit tired of only doing reviews, tonight... ;-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] new package: libwnck
2013-02-21 21:30 ` Yann E. MORIN
@ 2013-02-23 9:20 ` Arnout Vandecappelle
0 siblings, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2013-02-23 9:20 UTC (permalink / raw)
To: buildroot
On 21/02/13 22:30, Yann E. MORIN wrote:
> But I'd prefer it it were a 'depends on BR2_PACKAGE_LIBGTK2' rather than
> a 'select'.
>
> And add a comment anyway to state why libwnck is not available.
The other packages that depend on libgtk2 don't have a comment...
Actually, I think all of them should be sorted under libgtk2, so
they're nicely indented and fold open when libgtk2 is selected.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-23 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-21 18:06 [Buildroot] [PATCH] new package: libwnck Stefan Fröberg
2013-02-21 21:30 ` Yann E. MORIN
2013-02-23 9:20 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox